Skip to content

Commit 156f72d

Browse files
authored
Merge branch 'master' into sort-active-default-value
2 parents ab48689 + 82359e0 commit 156f72d

File tree

3,333 files changed

+145534
-79484
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,333 files changed

+145534
-79484
lines changed

.bazelignore

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,10 @@
11
node_modules
2+
3+
integration/harness-e2e-cli/.angular
4+
integration/harness-e2e-cli/node_modules
5+
6+
integration/ng-update-v13/.angular
7+
integration/ng-update-v13/node_modules
8+
9+
integration/ng-add/.angular
10+
integration/ng-add/node_modules

.bazelrc

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -45,55 +45,58 @@ test --test_output=errors
4545

4646
# Configures script to do version stamping.
4747
# See https://docs.bazel.build/versions/master/user-manual.html#flag--workspace_status_command
48-
build:release --workspace_status_command="node ./tools/bazel-stamp-vars.js"
48+
build:release --workspace_status_command="yarn -s ng-dev release build-env-stamp --mode=release"
4949
build:release --stamp
5050

51-
build:snapshot-build --workspace_status_command="node ./tools/bazel-stamp-vars.js --snapshot"
51+
build:snapshot-build --workspace_status_command="yarn -s ng-dev release build-env-stamp --mode=snapshot"
5252
build:snapshot-build --stamp
5353

54-
################################
55-
# View Engine / Ivy toggle #
56-
################################
57-
build:view-engine --define=angular_ivy_enabled=False
58-
build:ivy --define=angular_ivy_enabled=True
54+
####################################
55+
# Bazel custom flags #
56+
####################################
57+
build --flag_alias=partial_compilation=@npm//@angular/bazel/src:partial_compilation
5958

60-
# Set Ivy as the default
61-
build --config=ivy
59+
##################################
60+
# Always enable Ivy compilation #
61+
##################################
62+
build --define=angular_ivy_enabled=True
6263

6364
################################
6465
# Remote Execution Setup #
6566
################################
6667

6768
# Use the Angular team internal GCP instance for remote execution.
68-
build:remote --remote_instance_name=projects/internal-200822/instances/default_instance
69-
build:remote --project_id=internal-200822
69+
build:remote --remote_instance_name=projects/internal-200822/instances/primary_instance
7070

7171
# Needed due to: https://github.com/bazelbuild/bazel/issues/7254
7272
build:remote --define=EXECUTOR=remote
7373

74-
# For remote execution, we use the `ubuntu16_04_clang` toolchain configurations. These only
75-
# support `k8` or `armeabi-v7a`. Since we run on remotely with `k8` containers, we need to
76-
# ensure that the proper CPU is configured so that the correct toolchain can be used.
77-
# https://github.com/bazelbuild/bazel-toolchains/blob/master/configs/ubuntu16_04_clang/10.0.0/bazel_2.1.0/cc/BUILD#L50
74+
# Since remote builds run within Google Cloud `k8`-based containers, we set the
75+
# host and target CPU accordingly.
7876
build:remote --cpu=k8
7977
build:remote --host_cpu=k8
8078

8179
# Setup the remote build execution servers.
8280
build:remote --remote_cache=remotebuildexecution.googleapis.com
8381
build:remote --remote_executor=remotebuildexecution.googleapis.com
84-
build:remote --auth_enabled=true
82+
build:remote --google_default_credentials=true
8583

8684
# Setup the toolchain and platform for the remote build execution. The platform
87-
# is automatically configured by the "rbe_autoconfig" rule in the project workpsace.
88-
build:remote --crosstool_top=@rbe_default//cc:toolchain
89-
build:remote --host_javabase=@rbe_default//java:jdk
90-
build:remote --javabase=@rbe_default//java:jdk
91-
build:remote --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8
92-
build:remote --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8
93-
build:remote --extra_execution_platforms=//tools:rbe_platform
94-
build:remote --host_platform=//tools:rbe_platform
95-
build:remote --platforms=//tools:rbe_platform
96-
build:remote --extra_toolchains=@rbe_default//config:cc-toolchain
85+
# is provided by the shared dev-infra package and targets k8 remote containers.
86+
build:remote --crosstool_top=@npm//@angular/dev-infra-private/bazel/remote-execution/cpp:cc_toolchain_suite
87+
build:remote --extra_toolchains=@npm//@angular/dev-infra-private/bazel/remote-execution/cpp:cc_toolchain
88+
build:remote --extra_execution_platforms=@npm//@angular/dev-infra-private/bazel/remote-execution:platform_with_network
89+
build:remote --host_platform=@npm//@angular/dev-infra-private/bazel/remote-execution:platform_with_network
90+
build:remote --platforms=@npm//@angular/dev-infra-private/bazel/remote-execution:platform_with_network
91+
92+
################################
93+
# Sandbox settings #
94+
################################
95+
96+
# By default, network access should be disabled unless explicitly granted for certain targets
97+
# using the `requires-network` tag. https://docs.bazel.build/versions/main/be/common-definitions.html
98+
build --sandbox_default_allow_network=false
99+
test --sandbox_default_allow_network=false
97100

98101
################################
99102
# --config=build-results #
@@ -104,6 +107,7 @@ build:remote --extra_toolchains=@rbe_default//config:cc-toolchain
104107
# that could cause builds to fail unnecessarily. If desired, build result uploading
105108
# can be manually uploaded, but given that the build event service server has been
106109
# less stable than the remote executors, we do not want to degrade CI stability.
110+
build:build-results --bes_instance_name=internal-200822
107111
build:build-results --bes_backend=buildeventservice.googleapis.com
108112
build:build-results --bes_timeout=60s
109113
build:build-results --bes_results_url="https://source.cloud.google.com/results/invocations/"

.bazelversion

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4.0.0
1+
5.0.0

0 commit comments

Comments
 (0)