fix(): Fixes ALL dartanalyzer problems (so far).

Author: hansl

src/components/button/button.spec.ts

@@ -1,15 +1,18 @@
+import {
+  inject,
+  injectAsync,
+  ComponentFixture,
+  TestComponentBuilder,
+  beforeEachProviders,
+} from 'angular2/testing';
 import {
   it,
   iit,
   describe,
   ddescribe,
   expect,
-  inject,
-  injectAsync,
-  TestComponentBuilder,
-  beforeEachProviders,
   beforeEach,
-} from 'angular2/testing';
+} from '../../core/facade/testing';
 import {provide, Component, DebugElement} from 'angular2/core';
 import {By} from 'angular2/platform/browser';
 

src/components/button/button.ts

@@ -1,4 +1,12 @@
-import {Component, ViewEncapsulation, Input, HostBinding, HostListener, ChangeDetectionStrategy} from 'angular2/core';
+import {
+  Component,
+  ViewEncapsulation,
+  Input,
+  HostBinding,
+  HostListener,
+  ChangeDetectionStrategy,
+} from 'angular2/core';
+import {TimerWrapper} from 'angular2/src/facade/async';
 
 // TODO(jelbourn): Ink ripples.
 // TODO(jelbourn): Make the `isMouseDown` stuff done with one global listener.
@@ -37,7 +45,7 @@ export class MdButton {
     // button continues to look :active after clicking.
     // @see http://marcysutton.com/button-focus-hell/
     this.isMouseDown = true;
-    setTimeout(() => { this.isMouseDown = false; }, 100);
+    TimerWrapper.setTimeout(() => { this.isMouseDown = false; }, 100);
   }
 
   setKeyboardFocus($event: any) {

src/components/sidenav/sidenav.spec.ts

@@ -1,30 +1,34 @@
+import {
+  inject,
+  injectAsync,
+  ComponentFixture,
+  TestComponentBuilder,
+  beforeEachProviders,
+} from 'angular2/testing';
 import {
   it,
   iit,
   describe,
   ddescribe,
   expect,
-  inject,
-  injectAsync,
-  TestComponentBuilder,
-  beforeEachProviders,
   beforeEach,
-} from 'angular2/testing';
+} from '../../core/facade/testing';
+import {
+  getComputedStyle
+} from '../../core/facade/html';
 import {provide, Component, DebugElement} from 'angular2/core';
 import {By} from 'angular2/platform/browser';
-
-import {MdSidenav, MdSidenavLayout, MD_SIDENAV_DIRECTIVES} from './sidenav';
-import {AsyncTestFn, FunctionWithParamTokens} from 'angular2/testing';
-import {ComponentFixture} from 'angular2/testing';
-import {EventEmitter} from 'angular2/core';
 import {Predicate} from 'angular2/src/facade/collection';
 import {PromiseWrapper} from 'angular2/src/facade/promise';
 import {TimerWrapper} from 'angular2/src/facade/async';
+import {MdSidenav, MdSidenavLayout, MD_SIDENAV_DIRECTIVES} from './sidenav';
 
 
 function wait(msec: number) {
   let completer = PromiseWrapper.completer();
-  TimerWrapper.setTimeout(completer.resolve, msec);
+  TimerWrapper.setTimeout(() => {
+    completer.resolve(null);
+  }, msec);
   return completer.promise;
 }
 
@@ -38,7 +42,7 @@ function waitOnEvent(fixture: ComponentFixture,
   let completer = PromiseWrapper.completer();
   let component: any = fixture.debugElement.query(by).componentInstance;
   component[propertyName].subscribe(() => {
-    completer.resolve();
+    completer.resolve(null);
   });
   return completer.promise;
 }
@@ -63,7 +67,7 @@ export function main() {
             testComponent = fixture.debugElement.componentInstance;
             fixture.detectChanges();
             return wait(1);
-          }).then((f) => {
+          }).then((_: any) => {
             let openButtonElement = fixture.debugElement.query(By.css('.open'));
             openButtonElement.nativeElement.click();
             fixture.detectChanges();
@@ -81,8 +85,8 @@ export function main() {
 
             let sidenavElement = fixture.debugElement.query(By.css('md-sidenav'));
             let sidenavBackdropElement = fixture.debugElement.query(By.css('.md-sidenav-backdrop'));
-            expect(window.getComputedStyle(sidenavElement.nativeElement).visibility).toEqual('visible');
-            expect(window.getComputedStyle(sidenavBackdropElement.nativeElement).visibility).toEqual('visible');
+            expect(getComputedStyle(sidenavElement.nativeElement).visibility).toEqual('visible');
+            expect(getComputedStyle(sidenavBackdropElement.nativeElement).visibility).toEqual('visible');
 
             // Close it.
             let closeButtonElement = fixture.debugElement.query(By.css('.close'));
@@ -107,10 +111,10 @@ export function main() {
 
             let sidenavElement = fixture.debugElement.query(By.css('md-sidenav'));
             let sidenavBackdropElement = fixture.debugElement.query(By.css('.md-sidenav-backdrop'));
-            expect(window.getComputedStyle(sidenavElement.nativeElement).visibility).toEqual('hidden');
-            expect(window.getComputedStyle(sidenavBackdropElement.nativeElement).visibility).toEqual('hidden');
+            expect(getComputedStyle(sidenavElement.nativeElement).visibility).toEqual('hidden');
+            expect(getComputedStyle(sidenavBackdropElement.nativeElement).visibility).toEqual('hidden');
           })
-          .then(done, done.fail);
+          .then((_: any) => { done(); });
       }, 8000);
 
       it('open() and close() return a promise that resolves after the animation ended',
@@ -149,7 +153,7 @@ export function main() {
             })
             .then((_: any) => promise)
             .then((_: any) => expect(called).toBe(true))
-            .then(done, done.fail);
+            .then((_: any) => { done(); });
         }, 8000);
 
       it('open() twice returns the same promise', (done: any) => {
@@ -175,15 +179,14 @@ export function main() {
             promise = sidenav.close();
             expect(sidenav.close()).toBe(promise);
           })
-          .then(done, done.fail);
+          .then((_: any) => { done(); });
       });
 
       it('open() then close() cancel animations when called too fast',
         (done: any) => {
           let fixture: ComponentFixture;
           let sidenav: MdSidenav;
 
-          let openPromise: Promise<void>;
           let closePromise: Promise<void>;
           let openCalled: boolean = false;
           let openCancelled: boolean = false;
@@ -194,7 +197,7 @@ export function main() {
               fixture = f;
               sidenav = fixture.debugElement.query(By.directive(MdSidenav)).componentInstance;
 
-              openPromise = sidenav.open().then((_: any) => {
+              sidenav.open().then((_: any) => {
                   openCalled = true;
                 },
                 () => {
@@ -208,7 +211,7 @@ export function main() {
             .then((_: any) => {
               closePromise = sidenav.close().then((_: any) => {
                 closeCalled = true;
-              }, done.fail);
+              });
               return wait(1);
             })
             .then((_: any) => {
@@ -220,17 +223,15 @@ export function main() {
               expect(openCancelled).toBe(true);
               expect(closeCalled).toBe(true);
             })
-            .then(done, done.fail);
+            .then((_: any) => { done(); });
         }, 8000);
 
       it('close() then open() cancel animations when called too fast',
         (done: any) => {
-          let testComponent: BasicTestApp;
           let fixture: ComponentFixture;
           let sidenav: MdSidenav;
 
           let openPromise: Promise<void>;
-          let closePromise: Promise<void>;
           let closeCalled: boolean = false;
           let closeCancelled: boolean = false;
           let openCalled: boolean = false;
@@ -250,10 +251,9 @@ export function main() {
             })
             .then((_: any) => {
               // Then close and check behavior.
-              closePromise = sidenav.close().then((_: any) => {
+              sidenav.close().then((_: any) => {
                   closeCalled = true;
-                },
-                () => {
+                }, () => {
                   closeCancelled = true;
                 });
             })
@@ -276,7 +276,7 @@ export function main() {
               expect(closeCancelled).toBe(true);
               expect(openCalled).toBe(true);
             })
-            .then(done, done.fail);
+            .then((_: any) => { done(); });
         }, 8000);
     });
   });

src/components/sidenav/sidenav.ts

@@ -3,7 +3,6 @@ import {
   Component,
   ContentChildren,
   ElementRef,
-  EventEmitter,
   Host,
   HostBinding,
   HostListener,
@@ -14,7 +13,8 @@ import {
   Type,
   ChangeDetectionStrategy
 } from 'angular2/core';
-import {PromiseWrapper} from 'angular2/src/facade/promise';
+import {PromiseWrapper, ObservableWrapper, EventEmitter} from 'angular2/src/facade/async';
+import {iterateListLike} from 'angular2/src/facade/collection';
 import {BaseException} from 'angular2/src/facade/exceptions';
 import {CONST_EXPR, isPresent} from 'angular2/src/facade/lang';
 import {Dir} from '../../directives/dir/dir';
@@ -128,9 +128,6 @@ export class MdSidenav {
       this.onCloseStart.emit(null);
     }
 
-    let emitter = isOpen ? this.onOpen : this.onClose;
-    let other = isOpen ? this.onClose : this.onOpen;
-
     if (isOpen) {
       if (this.openPromise_ == null) {
         let completer = PromiseWrapper.completer();
@@ -259,13 +256,13 @@ export class MdSidenavLayout implements AfterContentInit {
     // If a `Dir` directive exists up the tree, listen direction changes and update the left/right
     // properties to point to the proper start/end.
     if (dir_ != null) {
-      dir_.dirChange.subscribe(() => this.validateDrawers_());
+      dir_.dirChange.add(() => this.validateDrawers_());
     }
   }
 
   ngAfterContentInit() {
     // On changes, assert on consistency.
-    this.sidenavs_.changes.subscribe(() => this.validateDrawers_());
+    ObservableWrapper.subscribe(this.sidenavs_.changes, () => this.validateDrawers_());
     this.validateDrawers_();
   }
 
@@ -294,17 +291,17 @@ export class MdSidenavLayout implements AfterContentInit {
     }
 
     // Ensure that we have at most one start and one end sidenav.
-    this.sidenavs_.toArray().forEach(drawer => {
-      if (drawer.align == 'end') {
+    iterateListLike(this.sidenavs_, (sidenav: any) => {
+      if (sidenav.align == 'end') {
         if (this.end_ != null) {
           throw new MdDuplicatedSidenavException('end');
         }
-        this.end_ = drawer;
+        this.end_ = sidenav;
       } else {
         if (this.start_ != null) {
           throw new MdDuplicatedSidenavException('start');
         }
-        this.start_ = drawer;
+        this.start_ = sidenav;
       }
     });
 

src/core/annotations/one-of.dart

@@ -3,5 +3,5 @@
  * TODO(hansl): Implement this properly in Dart.
  */
 class OneOf {
-  const OneOf(List<string> values);
+  const OneOf(List<String> values);
 }

src/core/facade/html.dart

@@ -0,0 +1,5 @@
+import "dart:html";
+
+CssStyleDeclaration getComputedStyle(element, [String pseudoElement]) {
+  return element.getComputedStyle(pseudoElement);
+}

src/core/facade/html.ts

@@ -0,0 +1,4 @@
+
+export function getComputedStyle(element: HTMLElement, pseudoElt?: string) {
+  return window.getComputedStyle(element, pseudoElt);
+}