Commit 1f17456
committed
build: include
This will allow pnpm to identifiy dependencies like `parse5` to be
understood as non-dev dependencies, so that they are propagated with
`rules_js` even when `cdk` is linked as `npm_package`. This is necessary
when using the npm package of CDK in the Material schematic tests.
To do this we need to give up on our non-statically readable
substitutions for tslib and RxJS but this is acceptable as those don't
change often and the benefits of the pnpm workspace are more important.
We move `parse5` from `optionalDependencies` to `dependencies` so that
pnpm recognizes this as non-dev dependency for the runtime execution of
the CDK package. `parse5` doesn't have any native code, so
`optionalDependencies` vs `dependencies` doesn't make a difference.
Long-term we should consider simply bundling `parse5` here.src/cdk in pnpm workspace1 parent d2e154c commit 1f17456
File tree
17 files changed
+84
-127
lines changed- .aspect/rules/external_repository_action_cache
- src
- cdk-experimental
- cdk
- components-examples
- google-maps
- material-date-fns-adapter
- material-experimental
- material-luxon-adapter
- material-moment-adapter
- material
- schematics
- youtube-player
17 files changed
+84
-127
lines changedLines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
| 178 | + | |
178 | 179 | | |
179 | 180 | | |
180 | 181 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | 1 | | |
8 | 2 | | |
9 | 3 | | |
| |||
27 | 21 | | |
28 | 22 | | |
29 | 23 | | |
30 | | - | |
31 | | - | |
32 | 24 | | |
33 | 25 | | |
34 | | - | |
35 | | - | |
36 | 26 | | |
37 | 27 | | |
38 | 28 | | |
| |||
0 commit comments