refactor(multiple): Remove any in sort, stepper, table, timepicker, tooltip, tree

Author: jamOne-

goldens/material/stepper/index.api.md

@@ -50,14 +50,14 @@ export class MatStep extends CdkStep implements ErrorStateMatcher, AfterContentI
 }
 
 // @public
-export class MatStepContent {
+export class MatStepContent<C = unknown> {
     constructor(...args: unknown[]);
     // (undocumented)
-    _template: TemplateRef<any>;
+    _template: TemplateRef<C>;
     // (undocumented)
-    static ɵdir: i0.ɵɵDirectiveDeclaration<MatStepContent, "ng-template[matStepContent]", never, {}, {}, never, never, true, never>;
+    static ɵdir: i0.ɵɵDirectiveDeclaration<MatStepContent<any>, "ng-template[matStepContent]", never, {}, {}, never, never, true, never>;
     // (undocumented)
-    static ɵfac: i0.ɵɵFactoryDeclaration<MatStepContent, never>;
+    static ɵfac: i0.ɵɵFactoryDeclaration<MatStepContent<any>, never>;
 }
 
 // @public (undocumented)

goldens/material/timepicker/index.api.md

@@ -109,15 +109,15 @@ export class MatTimepickerInput<D> implements MatTimepickerConnectedInput<D>, Co
     // (undocumented)
     ngOnDestroy(): void;
     readonly openOnClick: InputSignalWithTransform<boolean, unknown>;
-    registerOnChange(fn: (value: any) => void): void;
+    registerOnChange(fn: (value: unknown) => void): void;
     registerOnTouched(fn: () => void): void;
     registerOnValidatorChange(fn: () => void): void;
     setDisabledState(isDisabled: boolean): void;
     readonly timepicker: InputSignal<MatTimepicker<D>>;
     timepickerValueAssigned(value: D | null): void;
     validate(control: AbstractControl): ValidationErrors | null;
     readonly value: ModelSignal<D | null>;
-    writeValue(value: any): void;
+    writeValue(value: unknown): void;
     // (undocumented)
     static ɵdir: i0.ɵɵDirectiveDeclaration<MatTimepickerInput<any>, "input[matTimepicker]", ["matTimepickerInput"], { "value": { "alias": "value"; "required": false; "isSignal": true; }; "timepicker": { "alias": "matTimepicker"; "required": true; "isSignal": true; }; "min": { "alias": "matTimepickerMin"; "required": false; "isSignal": true; }; "max": { "alias": "matTimepickerMax"; "required": false; "isSignal": true; }; "openOnClick": { "alias": "matTimepickerOpenOnClick"; "required": false; "isSignal": true; }; "disabledInput": { "alias": "disabled"; "required": false; "isSignal": true; }; }, { "value": "valueChange"; }, never, never, true, never>;
     // (undocumented)

goldens/material/tooltip/index.api.md

@@ -76,10 +76,10 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
         y: number;
     }): void;
     get tooltipClass(): string | string[] | Set<string> | {
-        [key: string]: any;
+        [key: string]: unknown;
     };
     set tooltipClass(value: string | string[] | Set<string> | {
-        [key: string]: any;
+        [key: string]: unknown;
     });
     // (undocumented)
     _tooltipInstance: TooltipComponent | null;
@@ -143,7 +143,7 @@ export class TooltipComponent implements OnDestroy {
     show(delay: number): void;
     _tooltip: ElementRef<HTMLElement>;
     tooltipClass: string | string[] | Set<string> | {
-        [key: string]: any;
+        [key: string]: unknown;
     };
     _triggerElement: HTMLElement;
     // (undocumented)

src/material/sort/sort.spec.ts

@@ -504,8 +504,8 @@ class SimpleMatSortApp {
   }
 }
 
-class FakeDataSource extends DataSource<any> {
-  connect(collectionViewer: CollectionViewer): Observable<any[]> {
+class FakeDataSource extends DataSource<never> {
+  connect(collectionViewer: CollectionViewer): Observable<never[]> {
     return collectionViewer.viewChange.pipe(map(() => []));
   }
   disconnect() {}

src/material/stepper/step-content.ts

@@ -14,8 +14,8 @@ import {Directive, TemplateRef, inject} from '@angular/core';
 @Directive({
   selector: 'ng-template[matStepContent]',
 })
-export class MatStepContent {
-  _template = inject<TemplateRef<any>>(TemplateRef);
+export class MatStepContent<C = unknown> {
+  _template = inject<TemplateRef<C>>(TemplateRef);
 
   constructor(...args: unknown[]);
   constructor() {}

src/material/table/table-data-source.ts

@@ -229,10 +229,14 @@ export class MatTableDataSource<T, P extends MatPaginator = MatPaginator> extend
    * @returns Whether the filter matches against the data
    */
   filterPredicate: (data: T, filter: string) => boolean = (data: T, filter: string): boolean => {
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) && typeof data !== 'object') {
+      throw new Error('Default implementation of filterPredicate requires data to be object.');
+    }
+
     // Transform the filter by converting it to lowercase and removing whitespace.
     const transformedFilter = filter.trim().toLowerCase();
     // Loops over the values in the array and returns true if any of them match the filter string
-    return Object.values(data as {[key: string]: any}).some(value =>
+    return Object.values(data as object).some(value =>
       `${value}`.toLowerCase().includes(transformedFilter),
     );
   };

src/material/table/table.spec.ts

@@ -16,9 +16,9 @@ describe('MatTable', () => {
       const data = fixture.componentInstance.dataSource!.data;
       expectTableToMatchContent(tableElement, [
         ['Column A', 'Column B', 'Column C'],
-        [data[0].a, data[0].b, data[0].c],
-        [data[1].a, data[1].b, data[1].c],
-        [data[2].a, data[2].b, data[2].c],
+        [data[0].a, data[0].b, data[0].c] as string[],
+        [data[1].a, data[1].b, data[1].c] as string[],
+        [data[2].a, data[2].b, data[2].c] as string[],
         ['fourth_row'],
         ['Footer A', 'Footer B', 'Footer C'],
       ]);
@@ -64,10 +64,10 @@ describe('MatTable', () => {
       const data = fixture.componentInstance.dataSource!.data;
       expectTableToMatchContent(tableElement, [
         ['Column A', 'Column B', 'Column C'],
-        [data[0].a, data[0].b, data[0].c],
-        [data[1].a, data[1].b, data[1].c],
-        [data[2].a, data[2].b, data[2].c],
-        [data[3].a, data[3].b, data[3].c],
+        [data[0].a, data[0].b, data[0].c] as string[],
+        [data[1].a, data[1].b, data[1].c] as string[],
+        [data[2].a, data[2].b, data[2].c] as string[],
+        [data[3].a, data[3].b, data[3].c] as string[],
       ]);
     });
 
@@ -159,9 +159,9 @@ describe('MatTable', () => {
     const data = fixture.componentInstance.dataSource!.data;
     expectTableToMatchContent(tableElement, [
       ['Column A', 'Column B', 'Column C'],
-      [data[0].a, data[0].b, data[0].c],
-      [data[1].a, data[1].b, data[1].c],
-      [data[2].a, data[2].b, data[2].c],
+      [data[0].a, data[0].b, data[0].c] as string[],
+      [data[1].a, data[1].b, data[1].c] as string[],
+      [data[2].a, data[2].b, data[2].c] as string[],
     ]);
   });
 
@@ -173,9 +173,9 @@ describe('MatTable', () => {
     const data = fixture.componentInstance.dataSource!.data;
     expectTableToMatchContent(tableElement, [
       ['Column A', 'Column B', 'Column C'],
-      [data[0].a, data[0].b, data[0].c],
-      [data[1].a, data[1].b, data[1].c],
-      [data[2].a, data[2].b, data[2].c],
+      [data[0].a, data[0].b, data[0].c] as string[],
+      [data[1].a, data[1].b, data[1].c] as string[],
+      [data[2].a, data[2].b, data[2].c] as string[],
     ]);
   });
 
@@ -357,7 +357,7 @@ describe('MatTable', () => {
       ]);
 
       // Change the filter to a falsy value that might come in from the view.
-      dataSource.filter = 0 as any;
+      dataSource.filter = 0 as unknown as string;
       flushMicrotasks();
       fixture.detectChanges();
       expectTableToMatchContent(tableElement, [
@@ -604,7 +604,7 @@ describe('MatTable', () => {
         ['Footer A', 'Footer B', 'Footer C'],
       ]);
 
-      dataSource.data = {} as any;
+      dataSource.data = {} as TestData[];
       fixture.changeDetectorRef.markForCheck();
       fixture.detectChanges();
       expectTableToMatchContent(tableElement, [
@@ -1108,7 +1108,7 @@ function getActualTableContent(tableElement: Element): string[][] {
   return actualTableContent.map(row => row.map(cell => cell.textContent!.trim()));
 }
 
-export function expectTableToMatchContent(tableElement: Element, expected: any[]) {
+export function expectTableToMatchContent(tableElement: Element, expected: string[][]) {
   const missedExpectations: string[] = [];
   function checkCellContent(actualCell: string, expectedCell: string) {
     if (actualCell !== expectedCell) {
@@ -1134,7 +1134,7 @@ export function expectTableToMatchContent(tableElement: Element, expected: any[]
     }
 
     row.forEach((actualCell, cellIndex) => {
-      const expectedCell = expectedRow ? expectedRow[cellIndex] : null;
+      const expectedCell = expectedRow[cellIndex];
       checkCellContent(actualCell, expectedCell);
     });
   });

src/material/timepicker/timepicker-input.ts

@@ -88,7 +88,7 @@ export class MatTimepickerInput<D>
   private _dateFormats = inject(MAT_DATE_FORMATS, {optional: true})!;
   private _formField = inject(MAT_FORM_FIELD, {optional: true});
 
-  private _onChange: ((value: any) => void) | undefined;
+  private _onChange: ((value: unknown) => void) | undefined;
   private _onTouched: (() => void) | undefined;
   private _validatorOnChange: (() => void) | undefined;
   private _cleanupClick: () => void;
@@ -195,7 +195,7 @@ export class MatTimepickerInput<D>
    * Implemented as a part of `ControlValueAccessor`.
    * @docs-private
    */
-  writeValue(value: any): void {
+  writeValue(value: unknown): void {
     // Note that we need to deserialize here, rather than depend on the value change effect,
     // because `getValidDateOrNull` will clobber the value if it's parseable, but not created by
     // the current adapter (see #30140).
@@ -207,7 +207,7 @@ export class MatTimepickerInput<D>
    * Implemented as a part of `ControlValueAccessor`.
    * @docs-private
    */
-  registerOnChange(fn: (value: any) => void): void {
+  registerOnChange(fn: (value: unknown) => void): void {
     this._onChange = fn;
   }
 

src/material/tooltip/tooltip.spec.ts

@@ -1386,7 +1386,7 @@ describe('MatTooltip', () => {
       fixture.detectChanges();
 
       const styles = fixture.nativeElement.querySelector('button').style;
-      expect(styles.touchAction || (styles as any).webkitUserDrag).toBe('none');
+      expect(styles.touchAction || styles.webkitUserDrag).toBe('none');
     });
 
     it('should allow native touch interactions if touch gestures are turned off', () => {
@@ -1395,7 +1395,7 @@ describe('MatTooltip', () => {
       fixture.detectChanges();
 
       const styles = fixture.nativeElement.querySelector('button').style;
-      expect(styles.touchAction || (styles as any).webkitUserDrag).toBeFalsy();
+      expect(styles.touchAction || styles.webkitUserDrag).toBeFalsy();
     });
 
     it('should allow text selection on inputs when gestures are set to auto', () => {
@@ -1407,13 +1407,13 @@ describe('MatTooltip', () => {
 
       expect(inputStyle.userSelect).toBeFalsy();
       expect(inputStyle.webkitUserSelect).toBeFalsy();
-      expect((inputStyle as any).msUserSelect).toBeFalsy();
-      expect((inputStyle as any).MozUserSelect).toBeFalsy();
+      expect(inputStyle.msUserSelect).toBeFalsy();
+      expect(inputStyle.MozUserSelect).toBeFalsy();
 
       expect(textareaStyle.userSelect).toBeFalsy();
       expect(textareaStyle.webkitUserSelect).toBeFalsy();
-      expect((textareaStyle as any).msUserSelect).toBeFalsy();
-      expect((textareaStyle as any).MozUserSelect).toBeFalsy();
+      expect(textareaStyle.msUserSelect).toBeFalsy();
+      expect(textareaStyle.MozUserSelect).toBeFalsy();
     });
 
     it('should disable text selection on inputs when gestures are set to on', () => {
@@ -1425,14 +1425,14 @@ describe('MatTooltip', () => {
       const inputUserSelect =
         inputStyle.userSelect ||
         inputStyle.webkitUserSelect ||
-        (inputStyle as any).msUserSelect ||
-        (inputStyle as any).MozUserSelect;
+        inputStyle.msUserSelect ||
+        inputStyle.MozUserSelect;
       const textareaStyle = fixture.componentInstance.textarea.nativeElement.style;
       const textareaUserSelect =
         textareaStyle.userSelect ||
         textareaStyle.webkitUserSelect ||
-        (textareaStyle as any).msUserSelect ||
-        (textareaStyle as any).MozUserSelect;
+        textareaStyle.msUserSelect ||
+        textareaStyle.MozUserSelect;
 
       expect(inputUserSelect).toBe('none');
       expect(textareaUserSelect).toBe('none');
@@ -1570,7 +1570,7 @@ describe('MatTooltip', () => {
 })
 class BasicTooltipDemo {
   position: TooltipPosition = 'below';
-  message: any = initialTooltipMessage;
+  message: string | number = initialTooltipMessage;
   showButton = true;
   showTooltipClass = false;
   tooltipDisabled = false;
@@ -1683,7 +1683,7 @@ class TooltipOnDraggableElement {
   imports: [MatTooltip],
 })
 class TooltipDemoWithoutPositionBinding {
-  message: any = initialTooltipMessage;
+  message: string = initialTooltipMessage;
   @ViewChild(MatTooltip) tooltip: MatTooltip;
   @ViewChild('button') button: ElementRef<HTMLButtonElement>;
 }
@@ -1705,7 +1705,7 @@ class TooltipDemoWithoutTooltipClassBinding {
   imports: [MatTooltip],
 })
 class TooltipDemoWithTooltipClassBinding {
-  message: any = initialTooltipMessage;
+  message: string = initialTooltipMessage;
   @ViewChild(MatTooltip) tooltip: MatTooltip;
   @ViewChild('button') button: ElementRef<HTMLButtonElement>;
 }

src/material/tooltip/tooltip.ts

@@ -55,6 +55,15 @@ import {ComponentPortal} from '@angular/cdk/portal';
 import {Observable, Subject} from 'rxjs';
 import {_animationsDisabled} from '../core';
 
+declare global {
+  interface CSSStyleDeclaration {
+    msUserSelect: string;
+    MozUserSelect: string;
+    webkitUserDrag: string;
+    webkitTapHighlightColor: string;
+  }
+}
+
 /** Possible positions for a tooltip. */
 export type TooltipPosition = 'left' | 'right' | 'above' | 'below' | 'before' | 'after';
 
@@ -194,7 +203,7 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
   private _position: TooltipPosition = 'below';
   private _positionAtOrigin: boolean = false;
   private _disabled: boolean = false;
-  private _tooltipClass: string | string[] | Set<string> | {[key: string]: any};
+  private _tooltipClass: string | string[] | Set<string> | {[key: string]: unknown};
   private _viewInitialized = false;
   private _pointerExitEventsInitialized = false;
   private readonly _tooltipComponent = TooltipComponent;
@@ -336,7 +345,7 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
     return this._tooltipClass;
   }
 
-  set tooltipClass(value: string | string[] | Set<string> | {[key: string]: any}) {
+  set tooltipClass(value: string | string[] | Set<string> | {[key: string]: unknown}) {
     this._tooltipClass = value;
     if (this._tooltipInstance) {
       this._setTooltipClass(this._tooltipClass);
@@ -701,7 +710,9 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
   }
 
   /** Updates the tooltip class */
-  private _setTooltipClass(tooltipClass: string | string[] | Set<string> | {[key: string]: any}) {
+  private _setTooltipClass(
+    tooltipClass: string | string[] | Set<string> | {[key: string]: unknown},
+  ) {
     if (this._tooltipInstance) {
       this._tooltipInstance.tooltipClass = tooltipClass;
       this._tooltipInstance._markForCheck();
@@ -889,20 +900,20 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
       // textareas, because it prevents the user from typing into them on iOS Safari.
       if (gestures === 'on' || (element.nodeName !== 'INPUT' && element.nodeName !== 'TEXTAREA')) {
         style.userSelect =
-          (style as any).msUserSelect =
+          style.msUserSelect =
           style.webkitUserSelect =
-          (style as any).MozUserSelect =
+          style.MozUserSelect =
             'none';
       }
 
       // If we have `auto` gestures and the element uses native HTML dragging,
       // we don't set `-webkit-user-drag` because it prevents the native behavior.
       if (gestures === 'on' || !element.draggable) {
-        (style as any).webkitUserDrag = 'none';
+        style.webkitUserDrag = 'none';
       }
 
       style.touchAction = 'none';
-      (style as any).webkitTapHighlightColor = 'transparent';
+      style.webkitTapHighlightColor = 'transparent';
     }
   }
 
@@ -963,7 +974,7 @@ export class TooltipComponent implements OnDestroy {
   message: string;
 
   /** Classes to be added to the tooltip. Supports the same syntax as `ngClass`. */
-  tooltipClass: string | string[] | Set<string> | {[key: string]: any};
+  tooltipClass: string | string[] | Set<string> | {[key: string]: unknown};
 
   /** The timeout ID of any current timer set to show the tooltip */
   private _showTimeoutId: ReturnType<typeof setTimeout> | undefined;