Skip to content

Commit 263a400

Browse files
committed
fix(youtube-player): use safevalues
1 parent f8ba137 commit 263a400

File tree

7 files changed

+1998
-1980
lines changed

7 files changed

+1998
-1980
lines changed

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
# Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
33
# This file should be checked into version control along with the pnpm-lock.yaml file.
44
.npmrc=-1406867100
5-
package.json=130765121
5+
package.json=441060861
66
patches/@angular__compiler-cli.patch=-65319555
7-
pnpm-lock.yaml=-266832367
7+
pnpm-lock.yaml=1755183230
88
pnpm-workspace.yaml=14857322
99
src/cdk/package.json=-908433069
10-
yarn.lock=230420156
10+
yarn.lock=-1568260908

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@
6565
"rxjs": "^6.6.7",
6666
"rxjs-tslint-rules": "^4.34.8",
6767
"tslib": "^2.3.1",
68-
"zone.js": "~0.15.0"
68+
"zone.js": "~0.15.0",
69+
"safevalues": "^1.2.0"
6970
},
7071
"devDependencies": {
7172
"@angular-devkit/build-angular": "^20.0.0-next.3",

pnpm-lock.yaml

Lines changed: 1981 additions & 1973 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/youtube-player/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ ng_project(
3838
"//:node_modules/@angular/core",
3939
"//:node_modules/@types/youtube",
4040
"//:node_modules/rxjs",
41+
"//:node_modules/safevalues",
4142
"//src:dev_mode_types",
4243
],
4344
)

src/youtube-player/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
"homepage": "https://github.com/angular/components/tree/main/src/youtube-player#readme",
1919
"dependencies": {
2020
"@types/youtube": "^0.1.0",
21-
"tslib": "^2.3.0"
21+
"tslib": "^2.3.0",
22+
"safevalues": "^1.2.0"
2223
},
2324
"peerDependencies": {
2425
"@angular/core": "0.0.0-NG",

src/youtube-player/youtube-player.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ import {
3232
EventEmitter,
3333
} from '@angular/core';
3434
import {isPlatformBrowser} from '@angular/common';
35+
import {trustedResourceUrl} from 'safevalues';
36+
import {setScriptSrc} from 'safevalues/dom';
3537
import {Observable, of as observableOf, Subject, BehaviorSubject, fromEventPattern} from 'rxjs';
3638
import {takeUntil, switchMap} from 'rxjs/operators';
3739
import {PlaceholderImageQuality, YouTubePlayerPlaceholder} from './youtube-player-placeholder';
@@ -743,7 +745,7 @@ function loadApi(nonce: string | null): void {
743745
}
744746

745747
// We can use `document` directly here, because this logic doesn't run outside the browser.
746-
const url = 'https://www.youtube.com/iframe_api';
748+
const url = trustedResourceUrl`https://www.youtube.com/iframe_api`;
747749
const script = document.createElement('script');
748750
const callback = (event: Event) => {
749751
script.removeEventListener('load', callback);
@@ -759,7 +761,7 @@ function loadApi(nonce: string | null): void {
759761
};
760762
script.addEventListener('load', callback);
761763
script.addEventListener('error', callback);
762-
(script as any).src = url;
764+
setScriptSrc(script, url);
763765
script.async = true;
764766

765767
if (nonce) {

yarn.lock

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12963,6 +12963,11 @@ safe-stable-stringify@^2.3.1:
1296312963
resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a"
1296412964
integrity sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==
1296512965

12966+
safevalues@^1.2.0:
12967+
version "1.2.0"
12968+
resolved "https://registry.yarnpkg.com/safevalues/-/safevalues-1.2.0.tgz#f9e646d6ebf31788004ef192d2a7d646c9896bb2"
12969+
integrity sha512-zIsuhjYvJCjfsfjoim2ab6gLKFYAnTiDSJGh0cC3T44L/4kNLL90hBG2BzrXPrHA3f8Ms8FSJ1mljKH5dVR1cw==
12970+
1296612971
1296712972
version "16.0.5"
1296812973
resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-16.0.5.tgz#257bc90119ade066851cafe7f2c3f3504c7cda98"

0 commit comments

Comments
 (0)