Skip to content

Commit 29be768

Browse files
devversionmmalerba
authored andcommitted
build: re-add theming scss bundle to material package (#17278)
Re-adds the `_theming.scss` bundle the to the Material release package. We previously switched it to a simple sass file that did not bundle all imported mixins. We need to switch it back to a bundle since we observed that importing individual files is slower than accessing the bundled sass file.
1 parent ef5d9cb commit 29be768

File tree

6 files changed

+123
-123
lines changed

6 files changed

+123
-123
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@
142142
"rollup-plugin-alias": "^1.4.0",
143143
"rollup-plugin-node-resolve": "^3.0.3",
144144
"run-sequence": "^1.2.2",
145-
"scss-bundle": "^2.0.1-beta.7",
145+
"scss-bundle": "^2.5.1",
146146
"selenium-webdriver": "^3.6.0",
147147
"send": "^0.17.1",
148148
"shelljs": "^0.8.3",

src/material/BUILD.bazel

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package(default_visibility = ["//visibility:public"])
22

3+
load("@npm//scss-bundle:index.bzl", "scss_bundle")
4+
load("//src/cdk:config.bzl", "CDK_SCSS_LIBS")
35
load(
46
"//src/material:config.bzl",
57
"MATERIAL_ENTRYPOINTS",
@@ -19,14 +21,26 @@ filegroup(
1921
srcs = ["//src/material/%s:overview" % name for name in MATERIAL_ENTRYPOINTS],
2022
)
2123

24+
scss_bundle(
25+
name = "theming_bundle",
26+
outs = ["_theming.scss"],
27+
args = [
28+
"--entry=$(location //src/material/core:theming/_all-theme.scss)",
29+
"--verbosity=Errors",
30+
"--dedupe=./src/**/*.scss",
31+
"--dest=$(location :_theming.scss)",
32+
],
33+
data = CDK_SCSS_LIBS + MATERIAL_SCSS_LIBS + ["//src/material/core:theming/_all-theme.scss"],
34+
)
35+
2236
# Creates the @angular/material package published to npm.
2337
ng_package(
2438
name = "npm_package",
2539
srcs = [
26-
"_theming.scss",
2740
"package.json",
2841
],
2942
data = [
43+
":theming_bundle",
3044
"//src/material/core:theming_scss_lib",
3145
"//src/material/prebuilt-themes:deeppurple-amber",
3246
"//src/material/prebuilt-themes:indigo-pink",

src/material/_theming.scss

Lines changed: 0 additions & 3 deletions
This file was deleted.

tools/sass-bundle.ts

Lines changed: 0 additions & 35 deletions
This file was deleted.

tools/sass_bundle.bzl

Lines changed: 0 additions & 71 deletions
This file was deleted.

yarn.lock

Lines changed: 107 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1191,7 +1191,7 @@
11911191
"@types/serve-static" "*"
11921192
chokidar "^2.1.2"
11931193

1194-
"@types/chokidar@*":
1194+
"@types/chokidar@*", "@types/chokidar@^1.7.5":
11951195
version "1.7.5"
11961196
resolved "https://registry.yarnpkg.com/@types/chokidar/-/chokidar-1.7.5.tgz#1fa78c8803e035bed6d98e6949e514b133b0c9b6"
11971197
integrity sha512-PDkSRY7KltW3M60hSBlerxI8SFPXsO3AL/aRVsO4Kh9IHRW74Ih75gUuTd/aE4LSSFqypb10UIX3QzOJwBQMGQ==
@@ -1303,6 +1303,18 @@
13031303
resolved "https://registry.yarnpkg.com/@types/jju/-/jju-1.4.1.tgz#0a39f5f8e84fec46150a7b9ca985c3f89ad98e9f"
13041304
integrity sha512-LFt+YA7Lv2IZROMwokZKiPNORAV5N3huMs3IKnzlE430HWhWYZ8b+78HiwJXJJP1V2IEjinyJURuRJfGoaFSIA==
13051305

1306+
"@types/lodash.debounce@^4.0.4":
1307+
version "4.0.6"
1308+
resolved "https://registry.yarnpkg.com/@types/lodash.debounce/-/lodash.debounce-4.0.6.tgz#c5a2326cd3efc46566c47e4c0aa248dc0ee57d60"
1309+
integrity sha512-4WTmnnhCfDvvuLMaF3KV4Qfki93KebocUF45msxhYyjMttZDQYzHkO639ohhk8+oco2cluAFL3t5+Jn4mleylQ==
1310+
dependencies:
1311+
"@types/lodash" "*"
1312+
1313+
"@types/lodash@*":
1314+
version "4.14.141"
1315+
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.141.tgz#d81f4d0c562abe28713406b571ffb27692a82ae6"
1316+
integrity sha512-v5NYIi9qEbFEUpCyikmnOYe4YlP8BMUdTcNCAquAKzu+FA7rZ1onj9x80mbnDdOW/K5bFf3Tv5kJplP33+gAbQ==
1317+
13061318
"@types/long@^4.0.0":
13071319
version "4.0.0"
13081320
resolved "https://registry.yarnpkg.com/@types/long/-/long-4.0.0.tgz#719551d2352d301ac8b81db732acb6bdc28dbdef"
@@ -3018,6 +3030,15 @@ cliui@^4.0.0:
30183030
strip-ansi "^4.0.0"
30193031
wrap-ansi "^2.0.0"
30203032

3033+
cliui@^5.0.0:
3034+
version "5.0.0"
3035+
resolved "https://registry.yarnpkg.com/cliui/-/cliui-5.0.0.tgz#deefcfdb2e800784aa34f46fa08e06851c7bbbc5"
3036+
integrity sha512-PYeGSEmmHM6zvoef2w8TPzlrnNpXIjTipYK780YswmIP9vjxmd6Y2a3CB2Ks6/AU8NHjZugXvo8w3oWM2qnwXA==
3037+
dependencies:
3038+
string-width "^3.1.0"
3039+
strip-ansi "^5.2.0"
3040+
wrap-ansi "^5.1.0"
3041+
30213042
clone-regexp@^2.1.0:
30223043
version "2.2.0"
30233044
resolved "https://registry.yarnpkg.com/clone-regexp/-/clone-regexp-2.2.0.tgz#7d65e00885cd8796405c35a737e7a86b7429e36f"
@@ -8381,6 +8402,11 @@ nan@^2.12.1:
83818402
resolved "https://registry.yarnpkg.com/nan/-/nan-2.13.2.tgz#f51dc7ae66ba7d5d55e1e6d4d8092e802c9aefe7"
83828403
integrity sha512-TghvYc72wlMGMVMluVo9WRJc0mB8KxxF/gZ4YYFy7V2ZQX9l7rgbPg7vjS9mt6U5HXODVFVI2bOduCzwOMv/lw==
83838404

8405+
nan@^2.13.2:
8406+
version "2.14.0"
8407+
resolved "https://registry.yarnpkg.com/nan/-/nan-2.14.0.tgz#7818f722027b2459a86f0295d434d1fc2336c52c"
8408+
integrity sha512-INOFj37C7k3AfaNTtX8RhsTw7qRy7eLET14cROi9+5HAVbbHuIWUHEauBv5qT4Av2tWasiTY1Jw6puUNqRJXQg==
8409+
83848410
nanomatch@^1.2.9:
83858411
version "1.2.13"
83868412
resolved "https://registry.yarnpkg.com/nanomatch/-/nanomatch-1.2.13.tgz#b87a8aa4fc0de8fe6be88895b38983ff265bd119"
@@ -8517,6 +8543,29 @@ node-releases@^1.1.23:
85178543
dependencies:
85188544
semver "^5.3.0"
85198545

8546+
node-sass@^4.10.0:
8547+
version "4.12.0"
8548+
resolved "https://registry.yarnpkg.com/node-sass/-/node-sass-4.12.0.tgz#0914f531932380114a30cc5fa4fa63233a25f017"
8549+
integrity sha512-A1Iv4oN+Iel6EPv77/HddXErL2a+gZ4uBeZUy+a8O35CFYTXhgA8MgLCWBtwpGZdCvTvQ9d+bQxX/QC36GDPpQ==
8550+
dependencies:
8551+
async-foreach "^0.1.3"
8552+
chalk "^1.1.1"
8553+
cross-spawn "^3.0.0"
8554+
gaze "^1.0.0"
8555+
get-stdin "^4.0.1"
8556+
glob "^7.0.3"
8557+
in-publish "^2.0.0"
8558+
lodash "^4.17.11"
8559+
meow "^3.7.0"
8560+
mkdirp "^0.5.1"
8561+
nan "^2.13.2"
8562+
node-gyp "^3.8.0"
8563+
npmlog "^4.0.0"
8564+
request "^2.88.0"
8565+
sass-graph "^2.2.4"
8566+
stdout-stream "^1.4.0"
8567+
"true-case-path" "^1.0.2"
8568+
85208569
node-sass@^4.11.0:
85218570
version "4.11.0"
85228571
resolved "https://registry.yarnpkg.com/node-sass/-/node-sass-4.11.0.tgz#183faec398e9cbe93ba43362e2768ca988a6369a"
@@ -8542,7 +8591,7 @@ node-sass@^4.11.0:
85428591
stdout-stream "^1.4.0"
85438592
"true-case-path" "^1.0.2"
85448593

8545-
node-sass@^4.8.3, node-sass@^4.9.0:
8594+
node-sass@^4.8.3:
85468595
version "4.10.0"
85478596
resolved "https://registry.yarnpkg.com/node-sass/-/node-sass-4.10.0.tgz#dcc2b364c0913630945ccbf7a2bbf1f926effca4"
85488597
integrity sha512-fDQJfXszw6vek63Fe/ldkYXmRYK/QS6NbvM3i5oEo9ntPDy4XX7BcKZyTKv+/kSSxRtXXc7l+MSwEmYc0CSy6Q==
@@ -9507,9 +9556,9 @@ progress@^2.0.0:
95079556
integrity sha512-/OLz5F9beZUWwSHZDreXgap1XShX6W+DCHQCqwCF7uZ88s6uTlD2cR3JBE77SegCmNtb1Idst+NfmwcdU6KVhw==
95089557

95099558
promise@^8.0.1:
9510-
version "8.0.2"
9511-
resolved "https://registry.yarnpkg.com/promise/-/promise-8.0.2.tgz#9dcd0672192c589477d56891271bdc27547ae9f0"
9512-
integrity sha512-EIyzM39FpVOMbqgzEHhxdrEhtOSDOtjMZQ0M6iVfCE+kWNgCkAyOdnuCWqfmflylftfadU6FkiMgHZA2kUzwRw==
9559+
version "8.0.3"
9560+
resolved "https://registry.yarnpkg.com/promise/-/promise-8.0.3.tgz#f592e099c6cddc000d538ee7283bb190452b0bf6"
9561+
integrity sha512-HeRDUL1RJiLhyA0/grn+PTShlBAcLuh/1BJGtrvjwbvRDCTLLMEz9rOGCV+R3vHY4MixIuoMEd9Yq/XvsTPcjw==
95139562
dependencies:
95149563
asap "~2.0.6"
95159564

@@ -10421,18 +10470,22 @@ sax@>=0.6.0, sax@^1.2.4:
1042110470
resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9"
1042210471
integrity sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw==
1042310472

10424-
scss-bundle@^2.0.1-beta.7:
10425-
version "2.4.0"
10426-
resolved "https://registry.yarnpkg.com/scss-bundle/-/scss-bundle-2.4.0.tgz#2a09479646ced84f918224c9095210de1ef838f5"
10427-
integrity sha512-wK+plVq1aLhWaldyXIfRgnMk1ylvWn//pirqzL5HyFrS7ysfvKSn+z48Mg5W7cAV6IXjcDjf1naJ6RF5Xbb39Q==
10473+
scss-bundle@^2.5.1:
10474+
version "2.5.1"
10475+
resolved "https://registry.yarnpkg.com/scss-bundle/-/scss-bundle-2.5.1.tgz#def470dcac93484c7e40a6d4f657498ee5400934"
10476+
integrity sha512-n5gUfBqbPDuP7LYxG7Oi51jeyErzqhLOtofQl9ctYi8DRwGYpnCJIOl+9L3/o5O5srfM80ADLF/wYg11NUnh3Q==
1042810477
dependencies:
10478+
"@types/chokidar" "^1.7.5"
10479+
"@types/lodash.debounce" "^4.0.4"
1042910480
archy "^1.0.0"
10481+
chokidar "^2.0.4"
1043010482
fs-extra "^5.0.0"
1043110483
globs "^0.1.3"
10432-
node-sass "^4.9.0"
10484+
lodash.debounce "^4.0.8"
10485+
node-sass "^4.10.0"
1043310486
pretty-bytes "^4.0.2"
1043410487
promise "^8.0.1"
10435-
yargs "^11.0.0"
10488+
yargs "^13.1.0"
1043610489

1043710490
scss-tokenizer@^0.2.3:
1043810491
version "0.2.3"
@@ -11151,6 +11204,15 @@ string-width@^3.0.0:
1115111204
is-fullwidth-code-point "^2.0.0"
1115211205
strip-ansi "^5.0.0"
1115311206

11207+
string-width@^3.1.0:
11208+
version "3.1.0"
11209+
resolved "https://registry.yarnpkg.com/string-width/-/string-width-3.1.0.tgz#22767be21b62af1081574306f69ac51b62203961"
11210+
integrity sha512-vafcv6KjVZKSgz06oM/H6GDBrAtz8vdhQakGjFIvNrHA6y3HCF1CInLy+QLq8dTJPQ1b+KDUqDFctkdRW44e1w==
11211+
dependencies:
11212+
emoji-regex "^7.0.1"
11213+
is-fullwidth-code-point "^2.0.0"
11214+
strip-ansi "^5.1.0"
11215+
1115411216
string-width@^4.1.0:
1115511217
version "4.1.0"
1115611218
resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.1.0.tgz#ba846d1daa97c3c596155308063e075ed1c99aff"
@@ -11231,7 +11293,7 @@ strip-ansi@^5.0.0:
1123111293
dependencies:
1123211294
ansi-regex "^4.0.0"
1123311295

11234-
strip-ansi@^5.2.0:
11296+
strip-ansi@^5.1.0, strip-ansi@^5.2.0:
1123511297
version "5.2.0"
1123611298
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-5.2.0.tgz#8c9a536feb6afc962bdfa5b104a5091c1ad9c0ae"
1123711299
integrity sha512-DuRs1gKbBqsMKIZlrffwlug8MHkcnpjs5VPmL1PAh+mA30U0DTotfDZ0d2UUsXpPmPmMMJ6W773MaA3J+lbiWA==
@@ -12611,6 +12673,15 @@ wrap-ansi@^2.0.0:
1261112673
string-width "^1.0.1"
1261212674
strip-ansi "^3.0.1"
1261312675

12676+
wrap-ansi@^5.1.0:
12677+
version "5.1.0"
12678+
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-5.1.0.tgz#1fd1f67235d5b6d0fee781056001bfb694c03b09"
12679+
integrity sha512-QC1/iN/2/RPVJ5jYK8BGttj5z83LmSKmvbvrXPNCLZSEb32KKVDJDl/MOt2N01qU2H/FkzEa9PKto1BqDjtd7Q==
12680+
dependencies:
12681+
ansi-styles "^3.2.0"
12682+
string-width "^3.0.0"
12683+
strip-ansi "^5.0.0"
12684+
1261412685
wrappy@1:
1261512686
version "1.0.2"
1261612687
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f"
@@ -12749,6 +12820,14 @@ yargs-parser@^13.0.0:
1274912820
camelcase "^5.0.0"
1275012821
decamelize "^1.2.0"
1275112822

12823+
yargs-parser@^13.1.1:
12824+
version "13.1.1"
12825+
resolved "https://registry.yarnpkg.com/yargs-parser/-/yargs-parser-13.1.1.tgz#d26058532aa06d365fe091f6a1fc06b2f7e5eca0"
12826+
integrity sha512-oVAVsHz6uFrg3XQheFII8ESO2ssAf9luWuAd6Wexsu4F3OtIW0o8IribPXYrD4WC24LWtPrJlGy87y5udK+dxQ==
12827+
dependencies:
12828+
camelcase "^5.0.0"
12829+
decamelize "^1.2.0"
12830+
1275212831
yargs-parser@^4.1.0, yargs-parser@^4.2.0:
1275312832
version "4.2.1"
1275412833
resolved "https://registry.yarnpkg.com/yargs-parser/-/yargs-parser-4.2.1.tgz#29cceac0dc4f03c6c87b4a9f217dd18c9f74871c"
@@ -12862,6 +12941,22 @@ yargs@^11.0.0:
1286212941
y18n "^3.2.1"
1286312942
yargs-parser "^9.0.2"
1286412943

12944+
yargs@^13.1.0:
12945+
version "13.3.0"
12946+
resolved "https://registry.yarnpkg.com/yargs/-/yargs-13.3.0.tgz#4c657a55e07e5f2cf947f8a366567c04a0dedc83"
12947+
integrity sha512-2eehun/8ALW8TLoIl7MVaRUrg+yCnenu8B4kBlRxj3GJGDKU1Og7sMXPNm1BYyM1DOJmTZ4YeN/Nwxv+8XJsUA==
12948+
dependencies:
12949+
cliui "^5.0.0"
12950+
find-up "^3.0.0"
12951+
get-caller-file "^2.0.1"
12952+
require-directory "^2.1.1"
12953+
require-main-filename "^2.0.0"
12954+
set-blocking "^2.0.0"
12955+
string-width "^3.0.0"
12956+
which-module "^2.0.0"
12957+
y18n "^4.0.0"
12958+
yargs-parser "^13.1.1"
12959+
1286512960
yargs@^3.32.0:
1286612961
version "3.32.0"
1286712962
resolved "https://registry.yarnpkg.com/yargs/-/yargs-3.32.0.tgz#03088e9ebf9e756b69751611d2a5ef591482c995"

0 commit comments

Comments
 (0)