Skip to content

Commit 39a5776

Browse files
crisbetojosephperrott
authored andcommitted
chore(drag-drop): fix leftover cdkDrop references (#13629)
1 parent 8e324c8 commit 39a5776

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

src/cdk/drag-drop/drag-drop-registry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ type PointerEventHandler = (event: TouchEvent | MouseEvent) => void;
2323
* instances, and manages global event listeners on the `document`.
2424
* @docs-private
2525
*/
26-
// Note: this class is generic, rather than referencing CdkDrag and CdkDrop directly, in order to
27-
// avoid circular imports. If we were to reference them here, importing the registry into the
26+
// Note: this class is generic, rather than referencing CdkDrag and CdkDropList directly, in order
27+
// to avoid circular imports. If we were to reference them here, importing the registry into the
2828
// classes that are registering themselves will introduce a circular import.
2929
@Injectable({providedIn: 'root'})
3030
export class DragDropRegistry<I, C extends {id: string}> implements OnDestroy {

src/cdk/drag-drop/drag-drop.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ by the directives:
5757

5858
| Selector | Description |
5959
|---------------------|--------------------------------------------------------------------------|
60-
| `.cdk-drop-list` | Corresponds to the `cdkDropList` container. |
60+
| `.cdk-drop-list` | Corresponds to the `cdkDropList` container. |
6161
| `.cdk-drag` | Corresponds to a `cdkDrag` instance. |
6262
| `.cdk-drag-preview` | This is the element that will be rendered next to the user's cursor as they're dragging an item in a sortable list. By default the element looks exactly like the element that is being dragged. |
6363
| `.cdk-drag-placeholder` | This is element that will be shown instead of the real element as it's being dragged inside a `cdkDropList`. By default this will look exactly like the element that is being sorted. |

src/cdk/drag-drop/drag.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export function CDK_DRAG_CONFIG_FACTORY(): CdkDragConfig {
7777
return {dragStartThreshold: 5, pointerDirectionChangeThreshold: 5};
7878
}
7979

80-
/** Element that can be moved inside a CdkDrop container. */
80+
/** Element that can be moved inside a CdkDropList container. */
8181
@Directive({
8282
selector: '[cdkDrag]',
8383
exportAs: 'cdkDrag',

src/cdk/drag-drop/drop-list-container.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export interface CdkDropListContainer<T = any> {
6464
}
6565

6666
/**
67-
* Injection token that is used to provide a CdkDrop instance to CdkDrag.
67+
* Injection token that is used to provide a CdkDropList instance to CdkDrag.
6868
* Used for avoiding circular imports.
6969
*/
7070
export const CDK_DROP_LIST_CONTAINER =
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
<div class="container">
22
<h2>To do</h2>
33

4-
<div cdkDrop #todoList="cdkDrop" [cdkDropData]="todo" [cdkDropConnectedTo]="doneList" class="list"
5-
(cdkDropDropped)="drop($event)">
4+
<div cdkDropList #todoList="cdkDropList" [cdkDropListData]="todo"
5+
[cdkDropListConnectedTo]="doneList" class="list" (cdkDropListDropped)="drop($event)">
66
<div class="list-item" *ngFor="let item of todo" cdkDrag>{{item}}</div>
77
</div>
88
</div>
99

1010
<div class="container">
1111
<h2>Done</h2>
1212

13-
<div cdkDrop #doneList="cdkDrop" [cdkDropData]="done" [cdkDropConnectedTo]="todoList" class="list"
14-
(cdkDropDropped)="drop($event)">
13+
<div cdkDropList #doneList="cdkDropList" [cdkDropListData]="done"
14+
[cdkDropListConnectedTo]="todoList" class="list" (cdkDropListDropped)="drop($event)">
1515
<div class="list-item" *ngFor="let item of done" cdkDrag>{{item}}</div>
1616
</div>
1717
</div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<div cdkDropList cdkDropOrientation="horizontal" class="example-list" (cdkDropListDropped)="drop($event)">
1+
<div cdkDropList cdkDropListOrientation="horizontal" class="example-list" (cdkDropListDropped)="drop($event)">
22
<div class="example-box" *ngFor="let timePeriod of timePeriods" cdkDrag>{{timePeriod}}</div>
33
</div>

0 commit comments

Comments
 (0)