Skip to content

Commit 4009fb9

Browse files
committed
fix(): remove all async/waiting from the sidenav specs.
1 parent 3070a71 commit 4009fb9

File tree

5 files changed

+245
-263
lines changed

5 files changed

+245
-263
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
/**
2+
* We separate transitions to be able to disable them in unit tests, by simply not loading this file.
3+
*/
4+
@import "variables";
5+
6+
7+
:host {
8+
transition: margin-left $swift-ease-out-duration $swift-ease-out-timing-function,
9+
margin-right $swift-ease-out-duration $swift-ease-out-timing-function;
10+
11+
& > .md-sidenav-backdrop {
12+
&.md-sidenav-shown {
13+
transition: background-color $swift-ease-out-duration $swift-ease-out-timing-function;
14+
}
15+
}
16+
17+
& > md-content {
18+
transition: margin-left $swift-ease-out-duration $swift-ease-out-timing-function,
19+
margin-right $swift-ease-out-duration $swift-ease-out-timing-function,
20+
left $swift-ease-out-duration $swift-ease-out-timing-function,
21+
right $swift-ease-out-duration $swift-ease-out-timing-function;
22+
}
23+
24+
> md-sidenav {
25+
transition: transform $swift-ease-out-duration $swift-ease-out-timing-function;
26+
}
27+
}

src/components/sidenav/sidenav.scss

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ $md-sidenav-push-background-color: md-color($md-background, dialog) !default;
5858
// Hide the sidenavs when they're closed.
5959
overflow-x: hidden;
6060

61-
transition: margin-left $swift-ease-out-duration $swift-ease-out-timing-function,
62-
margin-right $swift-ease-out-duration $swift-ease-out-timing-function;
63-
6461
& > .md-sidenav-backdrop {
6562
position: absolute;
6663
top: 0;
@@ -83,18 +80,13 @@ $md-sidenav-push-background-color: md-color($md-background, dialog) !default;
8380
&.md-sidenav-shown {
8481
visibility: visible;
8582
background-color: $md-sidenav-backdrop-color;
86-
transition: background-color $swift-ease-out-duration $swift-ease-out-timing-function;
8783
}
8884
}
8985

9086
& > md-content {
9187
@include md-stacking-context();
9288

9389
display: block;
94-
transition: margin-left $swift-ease-out-duration $swift-ease-out-timing-function,
95-
margin-right $swift-ease-out-duration $swift-ease-out-timing-function,
96-
left $swift-ease-out-duration $swift-ease-out-timing-function,
97-
right $swift-ease-out-duration $swift-ease-out-timing-function;
9890
}
9991

10092
> md-sidenav {
@@ -108,8 +100,6 @@ $md-sidenav-push-background-color: md-color($md-background, dialog) !default;
108100

109101
background-color: $md-sidenav-background-color;
110102

111-
transition: transform $swift-ease-out-duration $swift-ease-out-timing-function;
112-
113103
@include md-sidenav-transition(0, -100%);
114104

115105
&.md-sidenav-push {

0 commit comments

Comments
 (0)