Skip to content

Commit 481a204

Browse files
committed
refactor(aria/tabs): underscore pattern props only for internal usage
1 parent b3cd710 commit 481a204

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/aria/tabs/tabs.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -307,10 +307,10 @@ export class Tab implements HasElement, OnInit, OnDestroy {
307307
readonly id = input(inject(_IdGenerator).getId('ng-tab-', true));
308308

309309
/** The parent TabList UIPattern. */
310-
readonly tablist = computed(() => this._tabList._pattern);
310+
private readonly _tablistPattern = computed(() => this._tabList._pattern);
311311

312312
/** The TabPanel UIPattern associated with the tab */
313-
readonly tabpanel = computed(() =>
313+
private readonly _tabpanelPattern = computed(() =>
314314
this._tabs._unorderedTabpanelPatterns().find(tabpanel => tabpanel.value() === this.value()),
315315
);
316316

@@ -329,8 +329,8 @@ export class Tab implements HasElement, OnInit, OnDestroy {
329329
/** The Tab UIPattern. */
330330
readonly _pattern: TabPattern = new TabPattern({
331331
...this,
332-
tablist: this.tablist,
333-
tabpanel: this.tabpanel,
332+
tablist: this._tablistPattern,
333+
tabpanel: this._tabpanelPattern,
334334
expanded: signal(false),
335335
element: () => this.element,
336336
});
@@ -400,7 +400,7 @@ export class TabPanel implements OnInit, OnDestroy {
400400
readonly id = input(inject(_IdGenerator).getId('ng-tabpanel-', true));
401401

402402
/** The Tab UIPattern associated with the tabpanel */
403-
readonly tab = computed(() =>
403+
private readonly _tabPattern = computed(() =>
404404
this._Tabs._tabPatterns()?.find(tab => tab.value() === this.value()),
405405
);
406406

@@ -413,6 +413,7 @@ export class TabPanel implements OnInit, OnDestroy {
413413
/** The TabPanel UIPattern. */
414414
readonly _pattern: TabPanelPattern = new TabPanelPattern({
415415
...this,
416+
tab: this._tabPattern,
416417
});
417418

418419
constructor() {

0 commit comments

Comments
 (0)