Skip to content

Commit 49f2ed1

Browse files
devversionmmalerba
authored andcommitted
test: disambiguate MDC component test names (#17674)
Currently the MDC-based component tests are copied from the non-MDC based component. The top-level describe name has not be changed to contain MDC in the most cases. This causes duplicate tests and it's difficult to tell from which component a test failure originates from.
1 parent 320f387 commit 49f2ed1

23 files changed

+24
-24
lines changed

src/material-experimental/mdc-button/button.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {MatButtonModule, MatButton} from './index';
55
import {MatRipple, ThemePalette} from '@angular/material/core';
66

77

8-
describe('MatButton', () => {
8+
describe('MDC-based MatButton', () => {
99

1010
beforeEach(async(() => {
1111
TestBed.configureTestingModule({

src/material-experimental/mdc-checkbox/checkbox.e2e.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {browser, by, element, Key} from 'protractor';
22

3-
describe('MDC checkbox', () => {
3+
describe('MDC-based checkbox', () => {
44
describe('check behavior', () => {
55
beforeEach(async () => await browser.get('/mdc-checkbox'));
66

src/material-experimental/mdc-checkbox/checkbox.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
import {MAT_CHECKBOX_DEFAULT_OPTIONS} from '@angular/material/checkbox';
1919

2020

21-
describe('MatCheckbox', () => {
21+
describe('MDC-based MatCheckbox', () => {
2222
let fixture: ComponentFixture<any>;
2323

2424
function createComponent<T>(componentType: Type<T>, extraDeclarations: Type<any>[] = []) {

src/material-experimental/mdc-chips/chip-grid.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ import {
4646
} from './index';
4747

4848

49-
describe('MatChipGrid', () => {
49+
describe('MDC-based MatChipGrid', () => {
5050
let fixture: ComponentFixture<any>;
5151
let chipGridDebugElement: DebugElement;
5252
let chipGridNativeElement: HTMLElement;

src/material-experimental/mdc-chips/chip-input.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
} from './index';
2323

2424

25-
describe('MatChipInput', () => {
25+
describe('MDC-based MatChipInput', () => {
2626
let fixture: ComponentFixture<any>;
2727
let testChipInput: TestChipInput;
2828
let inputDebugElement: DebugElement;

src/material-experimental/mdc-chips/chip-listbox.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {Subject} from 'rxjs';
3131
import {MatChip, MatChipListbox, MatChipOption, MatChipsModule} from './index';
3232

3333

34-
describe('MatChipListbox', () => {
34+
describe('MDC-based MatChipListbox', () => {
3535
let fixture: ComponentFixture<any>;
3636
let chipListboxDebugElement: DebugElement;
3737
let chipListboxNativeElement: HTMLElement;

src/material-experimental/mdc-chips/chip-option.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
} from './index';
1616

1717

18-
describe('Option Chips', () => {
18+
describe('MDC-based Option Chips', () => {
1919
let fixture: ComponentFixture<any>;
2020
let chipDebugElement: DebugElement;
2121
let chipNativeElement: HTMLElement;

src/material-experimental/mdc-chips/chip-remove.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {By} from '@angular/platform-browser';
44
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
55
import {MatChip, MatChipsModule} from './index';
66

7-
describe('Chip Remove', () => {
7+
describe('MDC-based Chip Remove', () => {
88
let fixture: ComponentFixture<TestChip>;
99
let testChip: TestChip;
1010
let chipDebugElement: DebugElement;

src/material-experimental/mdc-chips/chip-row.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {Subject} from 'rxjs';
1313
import {MatChipEvent, MatChipGrid, MatChipRow, MatChipsModule} from './index';
1414

1515

16-
describe('Row Chips', () => {
16+
describe('MDC-based Row Chips', () => {
1717
let fixture: ComponentFixture<any>;
1818
let chipDebugElement: DebugElement;
1919
let chipNativeElement: HTMLElement;

src/material-experimental/mdc-chips/chip-set.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {By} from '@angular/platform-browser';
55
import {MatChip, MatChipSet, MatChipsModule} from './index';
66

77

8-
describe('MatChipSet', () => {
8+
describe('MDC-based MatChipSet', () => {
99
beforeEach(async(() => {
1010
TestBed.configureTestingModule({
1111
imports: [MatChipsModule, CommonModule],

0 commit comments

Comments
 (0)