Skip to content

Commit 4aaa6eb

Browse files
authored
fix(material-experimental/mdc-core): consolidate mdc theming code under mdc-core (#25084)
The theming code for mdc is currently scattered across mdc-theming, mdc-color, mdc-density, mdc-typography, and mdc-helpers. This PR consolidates it all under mdc-core to better match the way our entry points are organized in @angular/material
1 parent 427e99a commit 4aaa6eb

File tree

161 files changed

+718
-728
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

161 files changed

+718
-728
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,9 @@
103103
/src/material-experimental/mdc-card/** @mmalerba
104104
/src/material-experimental/mdc-checkbox/** @mmalerba
105105
/src/material-experimental/mdc-chips/** @mmalerba
106-
/src/material-experimental/mdc-color/** @andrewseguin @devversion
107106
/src/material-experimental/mdc-core/** @crisbeto
108-
/src/material-experimental/mdc-density/** @devversion
109107
/src/material-experimental/mdc-dialog/** @devversion
110108
/src/material-experimental/mdc-form-field/** @devversion @mmalerba
111-
/src/material-experimental/mdc-helpers/** @mmalerba
112109
/src/material-experimental/mdc-input/** @devversion @mmalerba
113110
/src/material-experimental/mdc-list/** @mmalerba @devversion
114111
/src/material-experimental/mdc-menu/** @crisbeto
@@ -123,8 +120,6 @@
123120
/src/material-experimental/mdc-tabs/** @crisbeto
124121
/src/material-experimental/mdc-tooltip/** @crisbeto
125122
/src/material-experimental/mdc-table/** @andrewseguin
126-
/src/material-experimental/mdc-theming/** @mmalerba
127-
/src/material-experimental/mdc-typography/** @mmalerba
128123
/src/material-experimental/menubar/** @jelbourn
129124
/src/material-experimental/popover-edit/** @andrewseguin
130125
/src/material-experimental/selection/** @andrewseguin

.ng-dev/commit-message.mts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,9 @@ export const commitMessage: CommitMessageConfig = {
4545
'material-experimental/mdc-card',
4646
'material-experimental/mdc-checkbox',
4747
'material-experimental/mdc-chips',
48-
'material-experimental/mdc-color',
4948
'material-experimental/mdc-core',
50-
'material-experimental/mdc-density',
5149
'material-experimental/mdc-dialog',
5250
'material-experimental/mdc-form-field',
53-
'material-experimental/mdc-helpers',
5451
'material-experimental/mdc-input',
5552
'material-experimental/mdc-list',
5653
'material-experimental/mdc-menu',
@@ -65,8 +62,6 @@ export const commitMessage: CommitMessageConfig = {
6562
'material-experimental/mdc-table',
6663
'material-experimental/mdc-tabs',
6764
'material-experimental/mdc-tooltip',
68-
'material-experimental/mdc-theming',
69-
'material-experimental/mdc-typography',
7065
'material-experimental/menubar',
7166
'material-experimental/popover-edit',
7267
'material-experimental/selection',

scripts/migrate-sass-modules.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ migrate('material/core/**/_*.scss', materialPrefixes, true);
6666
commentOutMdc('material-experimental/**/*.scss');
6767

6868
// Migrate all of the MDC partials.
69-
migrate('material-experimental/mdc-helpers/**/_*.scss', mdcPrefixes, true);
69+
migrate('material-experimental/mdc-core/mdc-helpers/**/_*.scss', mdcPrefixes, true);
7070
migrate('material-experimental/mdc-core/**/_*.scss', mdcPrefixes, true, ['**/_core.scss']);
7171
migrate('material-experimental/**/_*.scss', mdcPrefixes, true);
7272

src/material-experimental/BUILD.bazel

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ ts_library(
2020
sass_library(
2121
name = "theming_scss_lib",
2222
srcs = MATERIAL_EXPERIMENTAL_SCSS_LIBS + [
23-
"//src/material-experimental/mdc-color",
24-
"//src/material-experimental/mdc-density",
25-
"//src/material-experimental/mdc-helpers",
26-
"//src/material-experimental/mdc-theming",
27-
"//src/material-experimental/mdc-typography",
23+
"//src/material-experimental/mdc-core/color",
24+
"//src/material-experimental/mdc-core/density",
25+
"//src/material-experimental/mdc-core/mdc-helpers",
26+
"//src/material-experimental/mdc-core/theming",
27+
"//src/material-experimental/mdc-core/typography",
2828
],
2929
)
3030

src/material-experimental/_index.scss

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
// Structural
2-
@forward './mdc-helpers/focus-indicators' as mdc-* show mdc-strong-focus-indicators;
2+
@forward './mdc-core/mdc-helpers/focus-indicators' as mdc-* show mdc-strong-focus-indicators;
33
@forward './mdc-core/elevation' as mdc-* show mdc-elevation, mdc-overridable-elevation;
44

55
// Theme bundles
6-
@forward './mdc-theming/all-theme' show all-mdc-component-themes;
7-
@forward './mdc-color/all-color' show all-mdc-component-colors;
8-
@forward './mdc-typography/all-typography' show all-mdc-component-typographies,
6+
@forward './mdc-core/theming/all-theme' show all-mdc-component-themes;
7+
@forward './mdc-core/color/all-color' show all-mdc-component-colors;
8+
@forward './mdc-core/typography/all-typography' show all-mdc-component-typographies,
99
define-mdc-typography-config;
10-
@forward './mdc-density/all-density' show all-mdc-component-densities;
10+
@forward './mdc-core/density/all-density' show all-mdc-component-densities;
1111

1212
// Component themes
1313
@forward './column-resize/column-resize-theme' as column-resize-* show column-resize-color,
@@ -18,7 +18,7 @@
1818
// MDC-related themes
1919
@forward './mdc-core/core-theme' as mdc-core-* show mdc-core-theme, mdc-core-color,
2020
mdc-core-density, mdc-core-typography;
21-
@forward './mdc-helpers/focus-indicators-theme' as mdc-strong-focus-indicators-* show
21+
@forward './mdc-core/mdc-helpers/focus-indicators-theme' as mdc-strong-focus-indicators-* show
2222
mdc-strong-focus-indicators-color, mdc-strong-focus-indicators-theme;
2323
@forward './mdc-core/option/option-theme' as mdc-option-* show mdc-option-color,
2424
mdc-option-typography, mdc-option-density, mdc-option-theme;

src/material-experimental/mdc-autocomplete/BUILD.bazel

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ sass_library(
2727
srcs = glob(["**/_*.scss"]),
2828
deps = [
2929
"//src/material:sass_lib",
30-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
31-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
30+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_helpers_scss_lib",
31+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_scss_deps_lib",
3232
],
3333
)
3434

@@ -40,8 +40,8 @@ sass_binary(
4040
],
4141
deps = [
4242
"//src/cdk:sass_lib",
43-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
44-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
43+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_helpers_scss_lib",
44+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_scss_deps_lib",
4545
],
4646
)
4747

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
@forward '../mdc-helpers/mdc-helpers.import';
2-
@forward '../mdc-helpers/mdc-helpers';
1+
@forward '../mdc-core/mdc-helpers/mdc-helpers.import';
2+
@forward '../mdc-core/mdc-helpers/mdc-helpers';
33
@forward 'autocomplete-theme' as mat-mdc-autocomplete-*;
44

5-
@import '../mdc-helpers/mdc-helpers';
5+
@import '../mdc-core/mdc-helpers/mdc-helpers';

src/material-experimental/mdc-autocomplete/_autocomplete-theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@use '@material/menu-surface/mixins' as mdc-menu-surface;
33
@use '@material/list/evolution-mixins' as mdc-list;
44

5-
@use '../mdc-helpers/mdc-helpers';
5+
@use '../mdc-core/mdc-helpers/mdc-helpers';
66

77
@mixin color($config-or-theme) {
88
$config: mat.get-color-config($config-or-theme);

src/material-experimental/mdc-button/BUILD.bazel

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ sass_library(
3636
srcs = glob(["**/_*.scss"]),
3737
deps = [
3838
"//src/material:sass_lib",
39-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
40-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
39+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_helpers_scss_lib",
40+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_scss_deps_lib",
4141
],
4242
)
4343

@@ -55,8 +55,8 @@ sass_binary(
5555
deps = [
5656
":button_base_scss_lib",
5757
"//src/material:sass_lib",
58-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
59-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
58+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_helpers_scss_lib",
59+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_scss_deps_lib",
6060
],
6161
)
6262

@@ -78,8 +78,8 @@ sass_binary(
7878
deps = [
7979
":button_base_scss_lib",
8080
"//src/material:sass_lib",
81-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
82-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
81+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_helpers_scss_lib",
82+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_scss_deps_lib",
8383
],
8484
)
8585

@@ -92,8 +92,8 @@ sass_binary(
9292
deps = [
9393
":button_base_scss_lib",
9494
"//src/material:sass_lib",
95-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
96-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
95+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_helpers_scss_lib",
96+
"//src/material-experimental/mdc-core/mdc-helpers:mdc_scss_deps_lib",
9797
],
9898
)
9999

src/material-experimental/mdc-button/_button-base.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@use '@angular/material' as mat;
33
@use '@material/touch-target' as mdc-touch-target;
44

5-
@use '../mdc-helpers/mdc-helpers';
5+
@use '../mdc-core/mdc-helpers/mdc-helpers';
66

77
// Adds styles necessary to provide stateful interactions with the button. This includes providing
88
// content for the state container's ::before and ::after so that they can be given a background

0 commit comments

Comments
 (0)