Skip to content

Commit 4ce635d

Browse files
crisbetommalerba
authored andcommitted
build: column resize examples not set up consistently (#19672)
All of the column resize examples were called `*-demo` which is inconsistent with the rest of the examples and will probably break if we decided to expose it to the docs site. Note that the setup is still a bit inconsistent, because we have different modules for each example that have to be imported separately, but this is due to a limitation in the column resize API where users import a different module depending on whether resizing is enabled by default. I've left a TODO to fix it eventually when we've had the chance to clean up the public API.
1 parent e2a579a commit 4ce635d

15 files changed

+71
-45
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ import {NgModule} from '@angular/core';
1010
import {MatTableModule} from '@angular/material/table';
1111
import {MatDefaultEnabledColumnResizeModule} from '@angular/material-experimental/column-resize';
1212

13-
import {DefaultEnabledColumnResizeFlexDemo} from './default-enabled-column-resize-flex-demo';
13+
import {DefaultEnabledColumnResizeFlexExample} from './default-enabled-column-resize-flex-example';
1414

1515
@NgModule({
1616
imports: [
1717
MatDefaultEnabledColumnResizeModule,
1818
MatTableModule,
1919
],
20-
declarations: [DefaultEnabledColumnResizeFlexDemo],
21-
exports: [DefaultEnabledColumnResizeFlexDemo],
20+
declarations: [DefaultEnabledColumnResizeFlexExample],
21+
exports: [DefaultEnabledColumnResizeFlexExample],
2222
})
23-
export class DefaultEnabledColumnResizeFlexDemoModule {
23+
export class DefaultEnabledColumnResizeFlexExampleModule {
2424
}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ const ELEMENT_DATA: PeriodicElement[] = [
4242
* @title Default-enabled column resize with a flex-based mat-table.
4343
*/
4444
@Component({
45-
selector: 'default-enabled-column-resize-flex-demo',
46-
templateUrl: 'default-enabled-column-resize-flex-demo.html',
47-
styleUrls: ['default-enabled-column-resize-flex-demo.css'],
45+
selector: 'default-enabled-column-resize-flex-example',
46+
templateUrl: 'default-enabled-column-resize-flex-example.html',
47+
styleUrls: ['default-enabled-column-resize-flex-example.css'],
4848
})
49-
export class DefaultEnabledColumnResizeFlexDemo {
49+
export class DefaultEnabledColumnResizeFlexExample {
5050
displayedColumns: string[] = ['position', 'name', 'weight', 'symbol'];
5151
dataSource = ELEMENT_DATA;
5252
}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ import {NgModule} from '@angular/core';
1010
import {MatTableModule} from '@angular/material/table';
1111
import {MatDefaultEnabledColumnResizeModule} from '@angular/material-experimental/column-resize';
1212

13-
import {DefaultEnabledColumnResizeDemo} from './default-enabled-column-resize-demo';
13+
import {DefaultEnabledColumnResizeExample} from './default-enabled-column-resize-example';
1414

1515
@NgModule({
1616
imports: [
1717
MatDefaultEnabledColumnResizeModule,
1818
MatTableModule,
1919
],
20-
declarations: [DefaultEnabledColumnResizeDemo],
21-
exports: [DefaultEnabledColumnResizeDemo],
20+
declarations: [DefaultEnabledColumnResizeExample],
21+
exports: [DefaultEnabledColumnResizeExample],
2222
})
23-
export class DefaultEnabledColumnResizeDemoModule {
23+
export class DefaultEnabledColumnResizeExampleModule {
2424
}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ const ELEMENT_DATA: PeriodicElement[] = [
4242
* @title Default-enabled column resize with a table-based mat-table.
4343
*/
4444
@Component({
45-
selector: 'default-enabled-column-resize-demo',
46-
templateUrl: 'default-enabled-column-resize-demo.html',
47-
styleUrls: ['default-enabled-column-resize-demo.css'],
45+
selector: 'default-enabled-column-resize-example',
46+
templateUrl: 'default-enabled-column-resize-example.html',
47+
styleUrls: ['default-enabled-column-resize-example.css'],
4848
})
49-
export class DefaultEnabledColumnResizeDemo {
49+
export class DefaultEnabledColumnResizeExample {
5050
displayedColumns: string[] = ['position', 'name', 'weight', 'symbol'];
5151
dataSource = ELEMENT_DATA;
5252
}
Lines changed: 32 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,40 @@
1+
import {NgModule} from '@angular/core';
2+
import {OptInColumnResizeExampleModule} from './opt-in/opt-in-column-resize-example-module';
3+
import {
4+
DefaultEnabledColumnResizeExampleModule,
5+
} from './default-enabled/default-enabled-column-resize-example-module';
6+
import {
7+
DefaultEnabledColumnResizeFlexExampleModule,
8+
} from './default-enabled-flex/default-enabled-column-resize-flex-example-module';
9+
110
export {
2-
DefaultEnabledColumnResizeDemo
3-
} from './default-enabled/default-enabled-column-resize-demo';
11+
DefaultEnabledColumnResizeExample
12+
} from './default-enabled/default-enabled-column-resize-example';
413
export {
5-
DefaultEnabledColumnResizeDemoModule
6-
} from './default-enabled/default-enabled-column-resize-demo-module';
14+
DefaultEnabledColumnResizeExampleModule
15+
} from './default-enabled/default-enabled-column-resize-example-module';
716

817
export {
9-
DefaultEnabledColumnResizeFlexDemo
10-
} from './default-enabled-flex/default-enabled-column-resize-flex-demo';
18+
DefaultEnabledColumnResizeFlexExample
19+
} from './default-enabled-flex/default-enabled-column-resize-flex-example';
1120
export {
12-
DefaultEnabledColumnResizeFlexDemoModule
13-
} from './default-enabled-flex/default-enabled-column-resize-flex-demo-module';
21+
DefaultEnabledColumnResizeFlexExampleModule
22+
} from './default-enabled-flex/default-enabled-column-resize-flex-example-module';
1423

1524
export {
16-
OptInColumnResizeDemo
17-
} from './opt-in/opt-in-column-resize-demo';
25+
OptInColumnResizeExample
26+
} from './opt-in/opt-in-column-resize-example';
1827
export {
19-
OptInColumnResizeDemoModule
20-
} from './opt-in/opt-in-column-resize-demo-module';
28+
OptInColumnResizeExampleModule
29+
} from './opt-in/opt-in-column-resize-example-module';
30+
31+
32+
@NgModule({
33+
exports: [
34+
DefaultEnabledColumnResizeExampleModule,
35+
DefaultEnabledColumnResizeFlexExampleModule,
36+
OptInColumnResizeExampleModule,
37+
],
38+
})
39+
export class ColumnResizeExamplesModule {
40+
}

src/components-examples/material-experimental/column-resize/opt-in/opt-in-column-resize-demo-module.ts renamed to src/components-examples/material-experimental/column-resize/opt-in/opt-in-column-resize-example-module.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ import {NgModule} from '@angular/core';
1010
import {MatTableModule} from '@angular/material/table';
1111
import {MatColumnResizeModule} from '@angular/material-experimental/column-resize';
1212

13-
import {OptInColumnResizeDemo} from './opt-in-column-resize-demo';
13+
import {OptInColumnResizeExample} from './opt-in-column-resize-example';
1414

1515
@NgModule({
1616
imports: [
1717
MatColumnResizeModule,
1818
MatTableModule,
1919
],
20-
declarations: [OptInColumnResizeDemo],
21-
exports: [OptInColumnResizeDemo],
20+
declarations: [OptInColumnResizeExample],
21+
exports: [OptInColumnResizeExample],
2222
})
23-
export class OptInColumnResizeDemoModule {
23+
export class OptInColumnResizeExampleModule {
2424
}

0 commit comments

Comments
 (0)