build: update public API golden infra and move to goldens/

* Moves the public API goldens to `goldens/`
* Switches us to the `npm_package` variant of the golden testing rule.
  This variant is more future proof and will work well with the
  `rules_js` migration (as it takes arbitrary Bazel tree artifacts)

Author: devversion

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -2,7 +2,7 @@
 # Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-2023857461
-package.json=-1367474012
-pnpm-lock.yaml=-811131462
+package.json=-1482816862
+pnpm-lock.yaml=-2100360822
 pnpm-workspace.yaml=1711114604
-yarn.lock=-1654078010
+yarn.lock=-1734434772

.bazelrc

@@ -91,9 +91,9 @@ build:remote --google_default_credentials=true
 
 # Setup the toolchain and platform for the remote build execution. The platform
 # is provided by the shared dev-infra package and targets k8 remote containers.
-build:remote --extra_execution_platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
-build:remote --host_platform=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
-build:remote --platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
+build:remote --extra_execution_platforms=@devinfra//bazel/remote-execution:platform_with_network
+build:remote --host_platform=@devinfra//bazel/remote-execution:platform_with_network
+build:remote --platforms=@devinfra//bazel/remote-execution:platform_with_network
 
 ################################
 #  Sandbox settings            #

.github/CODEOWNERS

@@ -13,4 +13,3 @@
 /.github/ISSUE_TEMPLATE/**          @angular/components-googlers
 
 /tools/                             @angular/dev-infra-components
-/tools/public_api_guard/**/*.md     @angular/components-googlers

.github/workflows/ci.yml

@@ -64,7 +64,7 @@ jobs:
       - name: Install node modules
         run: yarn install --frozen-lockfile
       - name: Check API Goldens
-        run: yarn bazel test tools/public_api_guard/...
+        run: yarn bazel test goldens/...
       - uses: ./.github/actions/slack
         if: failure()
         with:

.github/workflows/pr.yml

@@ -65,7 +65,7 @@ jobs:
       - name: Install node modules
         run: yarn install --frozen-lockfile
       - name: Check API Goldens
-        run: yarn bazel test tools/public_api_guard/...
+        run: yarn bazel test goldens/...
 
   e2e:
     runs-on: ubuntu-latest

DEV_ENVIRONMENT.md

@@ -66,7 +66,7 @@ packages locally and test them by either of the following ways:
 ### Approving public API changes
 If you're making changes to a public API, they need to be propagated to our public API golden files.
 To save the changes you can run `yarn approve-api <target>` and to review the changes, you can look
-at the file under `tools/public_api_guard/<target>.d.ts`.
+at the file under `goldens/<package>/<entry-point>.api.md`.
 
 
 ### Disabling Git hooks
@@ -86,7 +86,7 @@ export HUSKY=0
 
 A set of environment variables is made available within the dev-app. Such variables
 will be injected into the dev-app, so that e.g. API keys can be used for development
-without requiring secrets to be committed. 
+without requiring secrets to be committed.
 
 The following variables are currently used in the dev-app:
 

WORKSPACE

@@ -113,6 +113,7 @@ yarn_install(
         "//:.yarnrc",
         "//:tools/postinstall/apply-patches.js",
         "//:tools/postinstall/patches/@angular+bazel+20.0.0-next.1.patch",
+        "//:tools/postinstall/patches/@angular+build-tooling+0.0.0-335a273d3eb2a73c51efb97930fc1e0cd72e0d32.patch",
         "//:tools/postinstall/patches/@bazel+concatjs+5.8.1.patch",
     ],
     # Currently disabled due to:
@@ -203,7 +204,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 
 git_repository(
     name = "devinfra",
-    commit = "47572aba6019f368057c00966ac7ce354b1d65bc",
+    commit = "cc73dde52b557f831cc3b6e48daf8c3b542a33df",
     remote = "https://github.com/angular/dev-infra.git",
 )
 
@@ -217,7 +218,7 @@ setup_dependencies_2()
 
 git_repository(
     name = "rules_angular",
-    commit = "b1e419e5f6b5e897c07260780cfef2b0aac128fb",
+    commit = "e10bf488aca18c159399f4c1163324a40f45a5dc",
     remote = "https://github.com/devversion/rules_angular.git",
 )
 

goldens/BUILD.bazel

@@ -1,4 +1,38 @@
+load("@devinfra//bazel/api-golden:index.bzl", "api_golden_test_npm_package")
+
 exports_files([
     "size-test.yaml",
     "tsec-exemption.json",
 ])
+
+api_golden_test_npm_package(
+    name = "cdk_api",
+    data = glob(["cdk/**"]) + [
+        "//src/cdk:npm_package",
+    ],
+    golden_dir = "angular_material/goldens/cdk",
+    npm_package = "angular_material/src/cdk/npm_package",
+)
+
+api_golden_test_npm_package(
+    name = "material_api",
+    data = glob(["material/**"]) + ["//src/material:npm_package"],
+    golden_dir = "angular_material/goldens/material",
+    npm_package = "angular_material/src/material/npm_package",
+)
+
+api_golden_test_npm_package(
+    name = "google_maps_api",
+    data = glob(["google-maps/**"]) + ["//src/google-maps:npm_package"],
+    golden_dir = "angular_material/goldens/google-maps",
+    npm_package = "angular_material/src/google-maps/npm_package",
+    types = ["@npm//@types/google.maps"],
+)
+
+api_golden_test_npm_package(
+    name = "youtube_player_api",
+    data = glob(["youtube-player/**"]) + ["//src/youtube-player:npm_package"],
+    golden_dir = "angular_material/goldens/youtube-player",
+    npm_package = "angular_material/src/youtube-player/npm_package",
+    types = ["@npm//@types/youtube"],
+)

tools/public_api_guard/cdk/a11y.md renamed to goldens/cdk/a11y/index.api.md

@@ -1,4 +1,4 @@
-## API Report File for "components-srcs"
+## API Report File for "@angular/cdk_a11y"
 
 > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
 
@@ -30,7 +30,7 @@ export class A11yModule {
     // (undocumented)
     static ɵinj: i0.ɵɵInjectorDeclaration<A11yModule>;
     // (undocumented)
-    static ɵmod: i0.ɵɵNgModuleDeclaration<A11yModule, never, [typeof i1.ObserversModule, typeof i2.CdkAriaLive, typeof i3.CdkTrapFocus, typeof i4.CdkMonitorFocus], [typeof i2.CdkAriaLive, typeof i3.CdkTrapFocus, typeof i4.CdkMonitorFocus]>;
+    static ɵmod: i0.ɵɵNgModuleDeclaration<A11yModule, never, [typeof ObserversModule, typeof CdkAriaLive, typeof CdkTrapFocus, typeof CdkMonitorFocus], [typeof CdkAriaLive, typeof CdkTrapFocus, typeof CdkMonitorFocus]>;
 }
 
 // @public (undocumented)

tools/public_api_guard/cdk/accordion.md renamed to goldens/cdk/accordion/index.api.md

@@ -1,4 +1,4 @@
-## API Report File for "components-srcs"
+## API Report File for "@angular/cdk_accordion"
 
 > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
 
@@ -74,7 +74,7 @@ export class CdkAccordionModule {
     // (undocumented)
     static ɵinj: i0.ɵɵInjectorDeclaration<CdkAccordionModule>;
     // (undocumented)
-    static ɵmod: i0.ɵɵNgModuleDeclaration<CdkAccordionModule, never, [typeof i1.CdkAccordion, typeof i2.CdkAccordionItem], [typeof i1.CdkAccordion, typeof i2.CdkAccordionItem]>;
+    static ɵmod: i0.ɵɵNgModuleDeclaration<CdkAccordionModule, never, [typeof CdkAccordion, typeof CdkAccordionItem], [typeof CdkAccordion, typeof CdkAccordionItem]>;
 }
 
 // (No @packageDocumentation comment for this package)