test(multiple): remove unnecessary e2e tests

As discussed, these changes remove the e2e tests that were testing the same functionality as the unit tests. These tests didn't help us to catch any additional issues and were increasing our maintenance cost. I've left in a few tests that make sense to run as e2e (e.g. virtual scrolling and scroll blocking). I've also removed some shared utilities that either weren't used or had one call site left.

Author: crisbeto

src/cdk-experimental/scrolling/BUILD.bazel

@@ -39,15 +39,11 @@ ng_web_test_suite(
 ng_e2e_test_library(
     name = "e2e_test_sources",
     srcs = glob(["**/*.e2e.spec.ts"]),
-    deps = [
-        "//src/cdk/testing/private/e2e",
-    ],
 )
 
 e2e_test_suite(
     name = "e2e_tests",
     deps = [
         ":e2e_test_sources",
-        "//src/cdk/testing/private/e2e",
     ],
 )

src/cdk/overlay/BUILD.bazel

@@ -75,16 +75,12 @@ ng_web_test_suite(
 ng_e2e_test_library(
     name = "e2e_test_sources",
     srcs = glob(["**/*.e2e.spec.ts"]),
-    deps = [
-        "//src/cdk/testing/private/e2e",
-    ],
 )
 
 e2e_test_suite(
     name = "e2e_tests",
     deps = [
         ":e2e_test_sources",
-        "//src/cdk/testing/private/e2e",
     ],
 )
 

src/cdk/overlay/scroll/block-scroll-strategy.e2e.spec.ts

@@ -1,5 +1,4 @@
 import {browser, Key, element, by} from 'protractor';
-import {getScrollPosition} from '../../testing/private/e2e';
 
 describe('scroll blocking', () => {
   beforeEach(() => browser.get('/block-scroll-strategy'));
@@ -116,3 +115,20 @@ async function clickOn(id: string) {
 async function scrollPage(x: number, y: number) {
   await browser.executeScript(`window.scrollTo(${x}, ${y});`);
 }
+
+/**
+ * Determines the current scroll position of the page.
+ */
+async function getScrollPosition(): Promise<{x: number; y: number}> {
+  const snippet = `
+    var documentRect = document.documentElement.getBoundingClientRect();
+    var x = -documentRect.left || document.body.scrollLeft || window.scrollX ||
+             document.documentElement.scrollLeft || 0;
+    var y = -documentRect.top || document.body.scrollTop || window.scrollY ||
+             document.documentElement.scrollTop || 0;
+
+    return {x: x, y: y};
+  `;
+
+  return await browser.executeScript(snippet);
+}

src/cdk/testing/private/e2e/BUILD.bazel

@@ -24,7 +24,6 @@ ng_module(
     testonly = True,
     srcs = glob(
         ["**/*.ts"],
-        exclude = ["test-util/**"],
     ),
     assets = glob(
         [
@@ -35,31 +34,12 @@ ng_module(
     ),
     deps = [
         "//src/cdk-experimental/scrolling",
-        "//src/cdk/dialog",
-        "//src/cdk/drag-drop",
         "//src/cdk/overlay",
         "//src/cdk/scrolling",
         "//src/cdk/testing/tests:test_components",
         "//src/components-examples/private",
-        "//src/material/button",
-        "//src/material/card",
-        "//src/material/checkbox",
-        "//src/material/chips",
         "//src/material/core",
-        "//src/material/dialog",
-        "//src/material/grid-list",
-        "//src/material/icon",
-        "//src/material/input",
-        "//src/material/menu",
-        "//src/material/progress-bar",
-        "//src/material/progress-spinner",
-        "//src/material/radio",
-        "//src/material/select",
-        "//src/material/sidenav",
-        "//src/material/slide-toggle",
         "//src/material/slider",
-        "//src/material/table",
-        "//src/material/tabs",
         "@npm//@angular/animations",
         "@npm//@angular/core",
         "@npm//@angular/forms",