Skip to content

Commit 688443a

Browse files
amysortommalerba
amysorto
authored and
mmalerba
committed
feat(material/schematics): add tabs styles migrator and tests
1 parent 19008ef commit 688443a

File tree

4 files changed

+300
-2
lines changed

4 files changed

+300
-2
lines changed

‎integration/mdc-migration/golden/src/styles.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ $sample-project-theme: mat.define-light-theme((
3232
// Alternatively, you can import and @include the theme mixins for each component
3333
// that you are using.
3434
@include mat.all-component-themes($sample-project-theme);
35+
@include mat.mdc-tabs-theme($sample-project-theme);
36+
@include mat.mdc-tabs-typography($sample-project-theme);
3537
@include mat.mdc-table-theme($sample-project-theme);
3638
@include mat.mdc-table-typography($sample-project-theme);
3739
@include mat.mdc-slider-theme($sample-project-theme);

‎src/material/schematics/ng-generate/mdc-migration/rules/components/tabs/tabs-styles.spec.ts

Lines changed: 259 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,259 @@
1+
import {createTestApp, patchDevkitTreeToExposeTypeScript} from '@angular/cdk/schematics/testing';
2+
import {SchematicTestRunner, UnitTestTree} from '@angular-devkit/schematics/testing';
3+
import {createNewTestRunner, migrateComponents, THEME_FILE} from '../test-setup-helper';
4+
5+
describe('tabs styles', () => {
6+
let runner: SchematicTestRunner;
7+
let cliAppTree: UnitTestTree;
8+
9+
async function runMigrationTest(oldFileContent: string, newFileContent: string) {
10+
cliAppTree.create(THEME_FILE, oldFileContent);
11+
const tree = await migrateComponents(['tabs'], runner, cliAppTree);
12+
expect(tree.readContent(THEME_FILE)).toBe(newFileContent);
13+
}
14+
15+
beforeEach(async () => {
16+
runner = createNewTestRunner();
17+
cliAppTree = patchDevkitTreeToExposeTypeScript(await createTestApp(runner));
18+
});
19+
20+
describe('mixin migrations', () => {
21+
it('should replace the old theme with the new ones', async () => {
22+
await runMigrationTest(
23+
`
24+
@use '@angular/material' as mat;
25+
$theme: ();
26+
@include mat.tabs-theme($theme);
27+
`,
28+
`
29+
@use '@angular/material' as mat;
30+
$theme: ();
31+
@include mat.mdc-tabs-theme($theme);
32+
@include mat.mdc-tabs-typography($theme);
33+
`,
34+
);
35+
});
36+
37+
it('should use the correct namespace', async () => {
38+
await runMigrationTest(
39+
`
40+
@use '@angular/material' as arbitrary;
41+
$theme: ();
42+
@include arbitrary.tabs-theme($theme);
43+
`,
44+
`
45+
@use '@angular/material' as arbitrary;
46+
$theme: ();
47+
@include arbitrary.mdc-tabs-theme($theme);
48+
@include arbitrary.mdc-tabs-typography($theme);
49+
`,
50+
);
51+
});
52+
53+
it('should handle updating multiple themes', async () => {
54+
await runMigrationTest(
55+
`
56+
@use '@angular/material' as mat;
57+
$light-theme: ();
58+
$dark-theme: ();
59+
@include mat.tabs-theme($light-theme);
60+
@include mat.tabs-theme($dark-theme);
61+
`,
62+
`
63+
@use '@angular/material' as mat;
64+
$light-theme: ();
65+
$dark-theme: ();
66+
@include mat.mdc-tabs-theme($light-theme);
67+
@include mat.mdc-tabs-typography($light-theme);
68+
@include mat.mdc-tabs-theme($dark-theme);
69+
@include mat.mdc-tabs-typography($dark-theme);
70+
`,
71+
);
72+
});
73+
74+
it('should add correct theme if all-component-themes mixin included', async () => {
75+
await runMigrationTest(
76+
`
77+
@use '@angular/material' as mat;
78+
$theme: ();
79+
@include mat.all-component-themes($theme);
80+
`,
81+
`
82+
@use '@angular/material' as mat;
83+
$theme: ();
84+
@include mat.all-component-themes($theme);
85+
@include mat.mdc-tabs-theme($theme);
86+
@include mat.mdc-tabs-typography($theme);
87+
`,
88+
);
89+
});
90+
91+
it('should add multiple themes for multiple all-component-themes mixins', async () => {
92+
await runMigrationTest(
93+
`
94+
@use '@angular/material' as mat;
95+
$light-theme: ();
96+
$dark-theme: ();
97+
@include mat.all-component-themes($light-theme);
98+
@include mat.all-component-themes($dark-theme);
99+
`,
100+
`
101+
@use '@angular/material' as mat;
102+
$light-theme: ();
103+
$dark-theme: ();
104+
@include mat.all-component-themes($light-theme);
105+
@include mat.mdc-tabs-theme($light-theme);
106+
@include mat.mdc-tabs-typography($light-theme);
107+
@include mat.all-component-themes($dark-theme);
108+
@include mat.mdc-tabs-theme($dark-theme);
109+
@include mat.mdc-tabs-typography($dark-theme);
110+
`,
111+
);
112+
});
113+
114+
it('should preserve whitespace', async () => {
115+
await runMigrationTest(
116+
`
117+
@use '@angular/material' as mat;
118+
$theme: ();
119+
120+
121+
@include mat.tabs-theme($theme);
122+
123+
124+
`,
125+
`
126+
@use '@angular/material' as mat;
127+
$theme: ();
128+
129+
130+
@include mat.mdc-tabs-theme($theme);
131+
@include mat.mdc-tabs-typography($theme);
132+
133+
134+
`,
135+
);
136+
});
137+
});
138+
139+
describe('selector migrations', () => {
140+
it('should update the legacy mat-tab classname', async () => {
141+
await runMigrationTest(
142+
`
143+
.mat-tab {
144+
height: 50px;
145+
}
146+
`,
147+
`
148+
.mat-mdc-tab {
149+
height: 50px;
150+
}
151+
`,
152+
);
153+
});
154+
155+
it('should update multiple legacy classnames', async () => {
156+
await runMigrationTest(
157+
`
158+
.mat-tab {
159+
height: 50px;
160+
}
161+
.mat-tab-body {
162+
padding: 25px;
163+
}
164+
`,
165+
`
166+
.mat-mdc-tab {
167+
height: 50px;
168+
}
169+
.mat-mdc-tab-body {
170+
padding: 25px;
171+
}
172+
`,
173+
);
174+
});
175+
176+
it('should update a legacy classname w/ multiple selectors', async () => {
177+
await runMigrationTest(
178+
`
179+
.some-class.mat-tab, .another-class {
180+
height: 50px;
181+
}
182+
`,
183+
`
184+
.some-class.mat-mdc-tab, .another-class {
185+
height: 50px;
186+
}
187+
`,
188+
);
189+
});
190+
191+
it('should preserve the whitespace of multiple selectors', async () => {
192+
await runMigrationTest(
193+
`
194+
.some-class,
195+
.mat-tab,
196+
.another-class { height: 50px; }
197+
`,
198+
`
199+
.some-class,
200+
.mat-mdc-tab,
201+
.another-class { height: 50px; }
202+
`,
203+
);
204+
});
205+
206+
it('should add comment for potentially deprecated selector', async () => {
207+
await runMigrationTest(
208+
`
209+
.mat-tab-label-content {
210+
color: red;
211+
}
212+
`,
213+
`
214+
/* TODO: The following rule targets internal classes of tabs that may no longer apply for the MDC version. */
215+
216+
.mat-tab-label-content {
217+
color: red;
218+
}
219+
`,
220+
);
221+
});
222+
223+
it('should add comment for potentially deprecated multi-line selector', async () => {
224+
await runMigrationTest(
225+
`
226+
.some-class
227+
.mat-tab-label-content {
228+
color: red;
229+
}
230+
`,
231+
`
232+
/* TODO: The following rule targets internal classes of tabs that may no longer apply for the MDC version. */
233+
234+
.some-class
235+
.mat-tab-label-content {
236+
color: red;
237+
}
238+
`,
239+
);
240+
});
241+
242+
it('should update the legacy mat-tab class and add comment for potentially deprecated selector', async () => {
243+
await runMigrationTest(
244+
`
245+
.mat-tab.some-class, .mat-tab-label-content {
246+
padding: 25px;
247+
}
248+
`,
249+
`
250+
/* TODO: The following rule targets internal classes of tabs that may no longer apply for the MDC version. */
251+
252+
.mat-mdc-tab.some-class, .mat-tab-label-content {
253+
padding: 25px;
254+
}
255+
`,
256+
);
257+
});
258+
});
259+
});

‎src/material/schematics/ng-generate/mdc-migration/rules/components/tabs/tabs-styles.ts

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
/**
2+
* @license
3+
* Copyright Google LLC All Rights Reserved.
4+
*
5+
* Use of this source code is governed by an MIT-style license that can be
6+
* found in the LICENSE file at https://angular.io/license
7+
*/
8+
9+
import {ClassNameChange, StyleMigrator} from '../../style-migrator';
10+
11+
export class TabsStylesMigrator extends StyleMigrator {
12+
component = 'tabs';
13+
14+
deprecatedPrefixes = ['mat-tabs', 'mat-tab'];
15+
16+
mixinChanges = [
17+
{
18+
old: 'tabs-theme',
19+
new: ['mdc-tabs-theme', 'mdc-tabs-typography'],
20+
},
21+
];
22+
23+
classChanges: ClassNameChange[] = [
24+
{old: '.mat-tab', new: '.mat-mdc-tab'},
25+
{old: '.mat-tab-body', new: '.mat-mdc-tab-body'},
26+
{old: '.mat-tab-group', new: '.mat-mdc-tab-group'},
27+
{old: '.mat-tab-header', new: '.mat-mdc-tab-header'},
28+
{old: '.mat-tab-nav-bar', new: '.mat-mdc-tab-nav-bar'},
29+
{old: '.mat-tab-link', new: '.mat-mdc-tab-link'},
30+
];
31+
}

‎src/material/schematics/ng-generate/mdc-migration/rules/index.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9+
import {StyleMigrator} from './style-migrator';
10+
import {TemplateMigrator} from './template-migrator';
11+
912
import {ButtonRuntimeMigrator} from './components/button/button-runtime';
1013
import {ButtonStylesMigrator} from './components/button/button-styles';
1114
import {CardStylesMigrator} from './components/card/card-styles';
@@ -22,9 +25,8 @@ import {RadioStylesMigrator} from './components/radio/radio-styles';
2225
import {RuntimeMigrator} from './runtime-migrator';
2326
import {SlideToggleStylesMigrator} from './components/slide-toggle/slide-toggle-styles';
2427
import {SliderStylesMigrator} from './components/slider/slider-styles';
25-
import {StyleMigrator} from './style-migrator';
2628
import {TableStylesMigrator} from './components/table/table-styles';
27-
import {TemplateMigrator} from './template-migrator';
29+
import {TabsStylesMigrator} from './components/tabs/tabs-styles';
2830

2931
/** Contains the migrators to migrate a single component. */
3032
export interface ComponentMigrator {
@@ -93,4 +95,8 @@ export const MIGRATORS: ComponentMigrator[] = [
9395
component: 'table',
9496
styles: new TableStylesMigrator(),
9597
},
98+
{
99+
component: 'tabs',
100+
styles: new TabsStylesMigrator(),
101+
},
96102
];

0 commit comments

Comments
 (0)