build: fix mdc-migration schematic node tests failing esbuild

devversion · mmalerba · commit 6e460762c2ec · 2022-07-15T09:08:30.000-07:00
Fixes that the ESBuild spec-bundling fails for the MDC migration
schematic unit tests (which transitively tries loading `fsevents`)
diff --git a/src/material/schematics/ng-generate/mdc-migration/BUILD.bazel b/src/material/schematics/ng-generate/mdc-migration/BUILD.bazel
@@ -66,6 +66,9 @@ ts_library(
 
 spec_bundle(
     name = "unit_tests_bundle",
+    # Exclude the `node` devkit entry-point to avoid bundling native modules like
+    # `chokidar` and `fsevents`. These rely on native bindings and break with ESBuild.
+    external = ["@angular-devkit/core/node"],
     platform = "node",
     deps = [":unit_tests_lib"],
 )

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,9 @@ ts_library(`
`66`	`66`
`67`	`67`	`spec_bundle(`
`68`	`68`	`name = "unit_tests_bundle",`
	`69`	+ # Exclude the `node` devkit entry-point to avoid bundling native modules like
	`70`	+ # `chokidar` and `fsevents`. These rely on native bindings and break with ESBuild.
	`71`	`+ external = ["@angular-devkit/core/node"],`
`69`	`72`	`platform = "node",`
`70`	`73`	`deps = [":unit_tests_lib"],`
`71`	`74`	`)`