Skip to content

Commit 7294c6e

Browse files
authored
build: ensure component owners are assigned to public API changes (#28573)
Currently everything under `/tools` is set to be owned by dev infra which means that if a public API golden doesn't have an owner, it falls back to dev infra. These changes assign all directories in `tools` *except* the goldens to dev infra so that the owners linting can pick up any missing files. I've also redistributed the public API golden owners so they match the component owners, and I've added myself to the owners for the Tslint and Stylelint rules.
1 parent 66d0f2d commit 7294c6e

File tree

1 file changed

+57
-16
lines changed

1 file changed

+57
-16
lines changed

.github/CODEOWNERS

Lines changed: 57 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
/src/material/checkbox/** @mmalerba
1010
/src/material/chips/** @mmalerba @crisbeto @zarend
1111
/src/material/datepicker/** @mmalerba @crisbeto @zarend
12-
/src/material/dialog/** @devversion
12+
/src/material/dialog/** @devversion @crisbeto
1313
/src/material/divider/** @andrewseguin @crisbeto
1414
/src/material/expansion/** @andrewseguin
1515
/src/material/form-field/** @devversion @mmalerba
@@ -212,54 +212,95 @@
212212
/.yarn/** @devversion @josephperrott
213213
/scripts/** @devversion @josephperrott
214214
/test/** @devversion @josephperrott
215-
/tools/** @devversion @josephperrott
215+
/tools/* @devversion @josephperrott
216+
/tools/angular/** @devversion @josephperrott
217+
/tools/dgeni/** @devversion @josephperrott
218+
/tools/example-module/** @devversion @josephperrott
219+
/tools/highlight-files/** @devversion @josephperrott
220+
/tools/markdown-to-html/** @devversion @josephperrott
221+
/tools/mdc-deps/** @devversion @josephperrott
222+
/tools/package-docs-content/** @devversion @josephperrott
223+
/tools/postcss/** @devversion @josephperrott
224+
/tools/postinstall/** @devversion @josephperrott
225+
/tools/region-parser/** @devversion @josephperrott
226+
/tools/release-checks/** @devversion @josephperrott
227+
/tools/sass/** @devversion @josephperrott
228+
/tools/server-test/** @devversion @josephperrott
229+
/tools/stylelint/** @devversion @josephperrott @crisbeto
230+
/tools/tslint-rules/** @devversion @josephperrott @crisbeto
231+
232+
# Only the root of the API guard, the rest of the files
233+
# should be distributed among the component owners.
234+
/tools/public_api_guard/* @devversion @josephperrott
216235

217236
# Public API golden files
237+
/tools/public_api_guard/cdk/* @andrewseguin
218238
/tools/public_api_guard/cdk/a11y** @jelbourn @devversion
219239
/tools/public_api_guard/cdk/accordion** @andrewseguin
220240
/tools/public_api_guard/cdk/bidi** @andrewseguin
221-
/tools/public_api_guard/cdk/cdk** @andrewseguin
222241
/tools/public_api_guard/cdk/clipboard** @andrewseguin
223242
/tools/public_api_guard/cdk/coercion** @andrewseguin
224243
/tools/public_api_guard/cdk/collections** @crisbeto @andrewseguin
244+
/tools/public_api_guard/cdk/dialog** @jelbourn @crisbeto
225245
/tools/public_api_guard/cdk/drag-drop** @crisbeto
226246
/tools/public_api_guard/cdk/keycodes** @andrewseguin
227247
/tools/public_api_guard/cdk/layout** @andrewseguin
248+
/tools/public_api_guard/cdk/listbox** @jelbourn
249+
/tools/public_api_guard/cdk/menu** @mmalerba @crisbeto
228250
/tools/public_api_guard/cdk/observers** @andrewseguin @crisbeto
229-
/tools/public_api_guard/cdk/overlay** @andrewseguin @crisbeto
251+
/tools/public_api_guard/cdk/overlay** @jelbourn @crisbeto
230252
/tools/public_api_guard/cdk/platform** @andrewseguin @devversion
231253
/tools/public_api_guard/cdk/portal** @andrewseguin
254+
/tools/public_api_guard/cdk/schematics** @devversion @andrewseguin
232255
/tools/public_api_guard/cdk/scrolling** @andrewseguin @crisbeto
233256
/tools/public_api_guard/cdk/stepper** @mmalerba
234257
/tools/public_api_guard/cdk/table** @andrewseguin
235258
/tools/public_api_guard/cdk/testing** @mmalerba @devversion
236259
/tools/public_api_guard/cdk/text-field** @mmalerba
237260
/tools/public_api_guard/cdk/tree** @jelbourn @andrewseguin
238-
/tools/public_api_guard/google-maps/** @crisbeto
261+
262+
/tools/public_api_guard/material/* @andrewseguin
239263
/tools/public_api_guard/material/autocomplete** @crisbeto
240-
/tools/public_api_guard/material/badge** @andrewseguin
241-
/tools/public_api_guard/material/bottom-sheet** @andrewseguin @crisbeto
264+
/tools/public_api_guard/material/badge** @jelbourn
265+
/tools/public_api_guard/material/bottom-sheet** @jelbourn @crisbeto
242266
/tools/public_api_guard/material/button-toggle** @andrewseguin
243-
/tools/public_api_guard/material/chips** @andrewseguin
244-
/tools/public_api_guard/material/chips/testing** @andrewseguin
245-
/tools/public_api_guard/material/core** @andrewseguin
267+
/tools/public_api_guard/material/button** @andrewseguin
268+
/tools/public_api_guard/material/card** @mmalerba
269+
/tools/public_api_guard/material/checkbox** @mmalerba
270+
/tools/public_api_guard/material/chips** @mmalerba @crisbeto @zarend
246271
/tools/public_api_guard/material/datepicker** @mmalerba @crisbeto @zarend
272+
/tools/public_api_guard/material/dialog** @devversion @crisbeto
247273
/tools/public_api_guard/material/divider** @andrewseguin @crisbeto
248274
/tools/public_api_guard/material/expansion** @andrewseguin
249-
/tools/public_api_guard/material/form-field** @mmalerba
275+
/tools/public_api_guard/material/form-field** @devversion @mmalerba
250276
/tools/public_api_guard/material/grid-list** @andrewseguin
251277
/tools/public_api_guard/material/icon** @andrewseguin
252-
/tools/public_api_guard/material/list** @andrewseguin @crisbeto @devversion
253-
/tools/public_api_guard/material/material** @andrewseguin
278+
/tools/public_api_guard/material/input** @devversion @mmalerba
279+
/tools/public_api_guard/material/list** @mmalerba @devversion
254280
/tools/public_api_guard/material/menu** @crisbeto
255-
/tools/public_api_guard/material/radio** @andrewseguin @devversion
281+
/tools/public_api_guard/material/paginator** @crisbeto
282+
/tools/public_api_guard/material/prebuilt-themes** @andrewseguin
283+
/tools/public_api_guard/material/progress-bar** @andrewseguin
284+
/tools/public_api_guard/material/progress-spinner** @andrewseguin
285+
/tools/public_api_guard/material/radio** @mmalerba
286+
/tools/public_api_guard/material/schematics** @devversion @andrewseguin
287+
/tools/public_api_guard/material/select** @crisbeto
288+
/tools/public_api_guard/material/select** @crisbeto
256289
/tools/public_api_guard/material/sidenav** @mmalerba
257-
/tools/public_api_guard/material/slider** @mmalerba
290+
/tools/public_api_guard/material/slide-toggle** @crisbeto
291+
/tools/public_api_guard/material/slider** @devversion
292+
/tools/public_api_guard/material/snack-bar** @andrewseguin
258293
/tools/public_api_guard/material/sort** @andrewseguin
259294
/tools/public_api_guard/material/stepper** @mmalerba
295+
/tools/public_api_guard/material/table** @andrewseguin
296+
/tools/public_api_guard/material/tabs** @crisbeto
297+
/tools/public_api_guard/material/testing** @andrewseguin
260298
/tools/public_api_guard/material/toolbar** @devversion
299+
/tools/public_api_guard/material/tooltip** @andrewseguin
261300
/tools/public_api_guard/material/tree** @jelbourn @andrewseguin
262-
/tools/public_api_guard/youtube-player/** @andrewseguin
301+
302+
/tools/public_api_guard/youtube-player/** @crisbeto
303+
/tools/public_api_guard/google-maps/** @crisbeto
263304

264305
# Misc
265306
/.github/** @devversion @josephperrott

0 commit comments

Comments
 (0)