Skip to content

Commit 7b076c1

Browse files
committed
refactor(google-maps): fix strict property initialization errors
Updates the code to be compatible with strict property initialization.
1 parent 7db7a32 commit 7b076c1

File tree

24 files changed

+120
-119
lines changed

24 files changed

+120
-119
lines changed

src/google-maps/deprecated-map-marker-clusterer/deprecated-map-marker-clusterer.spec.ts

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -345,27 +345,27 @@ describe('DeprecatedMapMarkerClusterer', () => {
345345
imports: [GoogleMap, MapMarker, DeprecatedMapMarkerClusterer],
346346
})
347347
class TestApp {
348-
@ViewChild(DeprecatedMapMarkerClusterer) markerClusterer: DeprecatedMapMarkerClusterer;
349-
350-
ariaLabelFn: AriaLabelFn;
351-
averageCenter: boolean;
352-
batchSize: number;
353-
batchSizeIE: number;
354-
calculator: Calculator;
355-
clusterClass: string;
356-
enableRetinaIcons: boolean;
357-
gridSize: number;
358-
ignoreHidden: boolean;
359-
imageExtension: string;
360-
imagePath: string;
361-
imageSizes: number[];
362-
maxZoom: number;
363-
minimumClusterSize: number;
364-
styles: ClusterIconStyle[];
365-
title: string;
366-
zIndex: number;
367-
zoomOnClick: boolean;
368-
options: MarkerClustererOptions;
348+
@ViewChild(DeprecatedMapMarkerClusterer) markerClusterer!: DeprecatedMapMarkerClusterer;
349+
350+
ariaLabelFn!: AriaLabelFn;
351+
averageCenter!: boolean;
352+
batchSize!: number;
353+
batchSizeIE!: number;
354+
calculator!: Calculator;
355+
clusterClass!: string;
356+
enableRetinaIcons!: boolean;
357+
gridSize!: number;
358+
ignoreHidden!: boolean;
359+
imageExtension!: string;
360+
imagePath!: string;
361+
imageSizes!: number[];
362+
maxZoom!: number;
363+
minimumClusterSize!: number;
364+
styles!: ClusterIconStyle[];
365+
title!: string;
366+
zIndex!: number;
367+
zoomOnClick!: boolean;
368+
options!: MarkerClustererOptions;
369369

370370
state = 'state1';
371371

src/google-maps/deprecated-map-marker-clusterer/deprecated-map-marker-clusterer.ts

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -82,105 +82,105 @@ export class DeprecatedMapMarkerClusterer
8282
set averageCenter(averageCenter: boolean) {
8383
this._averageCenter = averageCenter;
8484
}
85-
private _averageCenter: boolean;
85+
private _averageCenter: boolean | undefined;
8686

8787
@Input() batchSize?: number;
8888

8989
@Input()
9090
set batchSizeIE(batchSizeIE: number) {
9191
this._batchSizeIE = batchSizeIE;
9292
}
93-
private _batchSizeIE: number;
93+
private _batchSizeIE!: number;
9494

9595
@Input()
9696
set calculator(calculator: Calculator) {
9797
this._calculator = calculator;
9898
}
99-
private _calculator: Calculator;
99+
private _calculator!: Calculator;
100100

101101
@Input()
102102
set clusterClass(clusterClass: string) {
103103
this._clusterClass = clusterClass;
104104
}
105-
private _clusterClass: string;
105+
private _clusterClass!: string;
106106

107107
@Input()
108108
set enableRetinaIcons(enableRetinaIcons: boolean) {
109109
this._enableRetinaIcons = enableRetinaIcons;
110110
}
111-
private _enableRetinaIcons: boolean;
111+
private _enableRetinaIcons: boolean | undefined;
112112

113113
@Input()
114114
set gridSize(gridSize: number) {
115115
this._gridSize = gridSize;
116116
}
117-
private _gridSize: number;
117+
private _gridSize!: number;
118118

119119
@Input()
120120
set ignoreHidden(ignoreHidden: boolean) {
121121
this._ignoreHidden = ignoreHidden;
122122
}
123-
private _ignoreHidden: boolean;
123+
private _ignoreHidden: boolean | undefined;
124124

125125
@Input()
126126
set imageExtension(imageExtension: string) {
127127
this._imageExtension = imageExtension;
128128
}
129-
private _imageExtension: string;
129+
private _imageExtension!: string;
130130

131131
@Input()
132132
set imagePath(imagePath: string) {
133133
this._imagePath = imagePath;
134134
}
135-
private _imagePath: string;
135+
private _imagePath!: string;
136136

137137
@Input()
138138
set imageSizes(imageSizes: number[]) {
139139
this._imageSizes = imageSizes;
140140
}
141-
private _imageSizes: number[];
141+
private _imageSizes!: number[];
142142

143143
@Input()
144144
set maxZoom(maxZoom: number) {
145145
this._maxZoom = maxZoom;
146146
}
147-
private _maxZoom: number;
147+
private _maxZoom!: number;
148148

149149
@Input()
150150
set minimumClusterSize(minimumClusterSize: number) {
151151
this._minimumClusterSize = minimumClusterSize;
152152
}
153-
private _minimumClusterSize: number;
153+
private _minimumClusterSize!: number;
154154

155155
@Input()
156156
set styles(styles: ClusterIconStyle[]) {
157157
this._styles = styles;
158158
}
159-
private _styles: ClusterIconStyle[];
159+
private _styles!: ClusterIconStyle[];
160160

161161
@Input()
162162
set title(title: string) {
163163
this._title = title;
164164
}
165-
private _title: string;
165+
private _title!: string;
166166

167167
@Input()
168168
set zIndex(zIndex: number) {
169169
this._zIndex = zIndex;
170170
}
171-
private _zIndex: number;
171+
private _zIndex!: number;
172172

173173
@Input()
174174
set zoomOnClick(zoomOnClick: boolean) {
175175
this._zoomOnClick = zoomOnClick;
176176
}
177-
private _zoomOnClick: boolean;
177+
private _zoomOnClick: boolean | undefined;
178178

179179
@Input()
180180
set options(options: MarkerClustererOptions) {
181181
this._options = options;
182182
}
183-
private _options: MarkerClustererOptions;
183+
private _options!: MarkerClustererOptions;
184184

185185
/**
186186
* See
@@ -201,7 +201,7 @@ export class DeprecatedMapMarkerClusterer
201201
@Output()
202202
readonly clusterClick: Observable<Cluster> = this._eventManager.getLazyEmitter<Cluster>('click');
203203

204-
@ContentChildren(MapMarker, {descendants: true}) _markers: QueryList<MapMarker>;
204+
@ContentChildren(MapMarker, {descendants: true}) _markers!: QueryList<MapMarker>;
205205

206206
/**
207207
* The underlying MarkerClusterer object.

src/google-maps/google-map/google-map.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -447,14 +447,14 @@ describe('GoogleMap', () => {
447447
imports: [GoogleMap],
448448
})
449449
class TestApp {
450-
@ViewChild(GoogleMap) map: GoogleMap;
451-
height: string | number | null;
452-
width: string | number | null;
453-
center: google.maps.LatLngLiteral;
454-
zoom: number;
455-
options: google.maps.MapOptions;
456-
mapTypeId: google.maps.MapTypeId;
457-
mapId: string;
450+
@ViewChild(GoogleMap) map!: GoogleMap;
451+
height!: string | number | null;
452+
width!: string | number | null;
453+
center!: google.maps.LatLngLiteral;
454+
zoom!: number;
455+
options!: google.maps.MapOptions;
456+
mapTypeId!: google.maps.MapTypeId;
457+
mapId!: string;
458458

459459
handleClick(event: google.maps.MapMouseEvent) {}
460460
handleCenterChanged() {}

src/google-maps/google-map/google-map.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
6161
private readonly _elementRef = inject(ElementRef);
6262
private _ngZone = inject(NgZone);
6363
private _eventManager = new MapEventManager(inject(NgZone));
64-
private _mapEl: HTMLElement;
65-
private _existingAuthFailureCallback: GoogleMapsWindow['gm_authFailure'];
64+
private _mapEl!: HTMLElement;
65+
private _existingAuthFailureCallback!: GoogleMapsWindow['gm_authFailure'];
6666

6767
/**
6868
* The underlying google.maps.Map object
@@ -96,13 +96,13 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
9696
set center(center: google.maps.LatLngLiteral | google.maps.LatLng) {
9797
this._center = center;
9898
}
99-
private _center: google.maps.LatLngLiteral | google.maps.LatLng;
99+
private _center!: google.maps.LatLngLiteral | google.maps.LatLng;
100100

101101
@Input()
102102
set zoom(zoom: number) {
103103
this._zoom = zoom;
104104
}
105-
private _zoom: number;
105+
private _zoom!: number;
106106

107107
@Input()
108108
set options(options: google.maps.MapOptions) {

src/google-maps/map-advanced-marker/map-advanced-marker.spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,13 @@ describe('MapAdvancedMarker', () => {
180180
imports: [GoogleMap, MapAdvancedMarker],
181181
})
182182
class TestApp {
183-
@ViewChild(MapAdvancedMarker) advancedMarker: MapAdvancedMarker;
184-
title: string;
185-
position: google.maps.LatLng | google.maps.LatLngLiteral;
186-
content: Node | google.maps.marker.PinElement;
187-
gmpDraggable: boolean;
188-
zIndex: number;
189-
options: google.maps.marker.AdvancedMarkerElementOptions;
183+
@ViewChild(MapAdvancedMarker) advancedMarker!: MapAdvancedMarker;
184+
title!: string;
185+
position!: google.maps.LatLng | google.maps.LatLngLiteral;
186+
content!: Node | google.maps.marker.PinElement;
187+
gmpDraggable!: boolean;
188+
zIndex!: number;
189+
options!: google.maps.marker.AdvancedMarkerElementOptions;
190190

191191
handleClick() {}
192192
handleDblclick() {}

src/google-maps/map-advanced-marker/map-advanced-marker.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export class MapAdvancedMarker
6464
set title(title: string) {
6565
this._title = title;
6666
}
67-
private _title: string;
67+
private _title!: string;
6868

6969
/**
7070
* Sets the AdvancedMarkerElement's position. An AdvancedMarkerElement may be constructed without a position, but will not be displayed until its position is provided - for example, by a user's actions or choices. An AdvancedMarkerElement's position can be provided by setting AdvancedMarkerElement.position if not provided at the construction.
@@ -81,7 +81,7 @@ export class MapAdvancedMarker
8181
) {
8282
this._position = position;
8383
}
84-
private _position: google.maps.LatLngLiteral | google.maps.LatLng;
84+
private _position!: google.maps.LatLngLiteral | google.maps.LatLng;
8585

8686
/**
8787
* The DOM Element backing the visual of an AdvancedMarkerElement.
@@ -92,7 +92,7 @@ export class MapAdvancedMarker
9292
set content(content: Node | google.maps.marker.PinElement | null) {
9393
this._content = content;
9494
}
95-
private _content: Node | null;
95+
private _content: Node | null = null;
9696

9797
/**
9898
* If true, the AdvancedMarkerElement can be dragged.
@@ -103,7 +103,7 @@ export class MapAdvancedMarker
103103
set gmpDraggable(draggable: boolean) {
104104
this._draggable = draggable;
105105
}
106-
private _draggable: boolean;
106+
private _draggable: boolean | undefined;
107107

108108
/**
109109
* Options for constructing an AdvancedMarkerElement.
@@ -113,7 +113,7 @@ export class MapAdvancedMarker
113113
set options(options: google.maps.marker.AdvancedMarkerElementOptions) {
114114
this._options = options;
115115
}
116-
private _options: google.maps.marker.AdvancedMarkerElementOptions;
116+
private _options!: google.maps.marker.AdvancedMarkerElementOptions;
117117

118118
/**
119119
* AdvancedMarkerElements on the map are prioritized by zIndex, with higher values indicating higher display.
@@ -123,7 +123,7 @@ export class MapAdvancedMarker
123123
set zIndex(zIndex: number) {
124124
this._zIndex = zIndex;
125125
}
126-
private _zIndex: number;
126+
private _zIndex!: number;
127127

128128
/**
129129
* This event is fired when the AdvancedMarkerElement element is clicked.
@@ -192,7 +192,7 @@ export class MapAdvancedMarker
192192
*
193193
* See developers.google.com/maps/documentation/javascript/reference/advanced-markers#AdvancedMarkerElement
194194
*/
195-
advancedMarker: google.maps.marker.AdvancedMarkerElement;
195+
advancedMarker!: google.maps.marker.AdvancedMarkerElement;
196196

197197
constructor(...args: unknown[]);
198198
constructor() {}

src/google-maps/map-circle/map-circle.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,10 +169,10 @@ describe('MapCircle', () => {
169169
imports: [GoogleMap, MapCircle],
170170
})
171171
class TestApp {
172-
@ViewChild(MapCircle) circle: MapCircle;
173-
options: google.maps.CircleOptions;
174-
center: google.maps.LatLngLiteral;
175-
radius: number;
172+
@ViewChild(MapCircle) circle!: MapCircle;
173+
options!: google.maps.CircleOptions;
174+
center!: google.maps.LatLngLiteral;
175+
radius!: number;
176176

177177
handleCenterChange() {}
178178

src/google-maps/map-directions-renderer/map-directions-renderer.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,9 @@ describe('MapDirectionsRenderer', () => {
139139
imports: [GoogleMap, MapDirectionsRenderer],
140140
})
141141
class TestApp {
142-
@ViewChild(MapDirectionsRenderer) directionsRenderer: MapDirectionsRenderer;
143-
options: google.maps.DirectionsRendererOptions;
144-
directions: google.maps.DirectionsResult;
142+
@ViewChild(MapDirectionsRenderer) directionsRenderer!: MapDirectionsRenderer;
143+
options!: google.maps.DirectionsRendererOptions;
144+
directions!: google.maps.DirectionsResult;
145145

146146
handleDirectionsChanged() {}
147147
}

src/google-maps/map-directions-renderer/map-directions-renderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class MapDirectionsRenderer implements OnInit, OnChanges, OnDestroy {
4545
set directions(directions: google.maps.DirectionsResult) {
4646
this._directions = directions;
4747
}
48-
private _directions: google.maps.DirectionsResult;
48+
private _directions!: google.maps.DirectionsResult;
4949

5050
/**
5151
* See developers.google.com/maps/documentation/javascript/reference/directions
@@ -55,7 +55,7 @@ export class MapDirectionsRenderer implements OnInit, OnChanges, OnDestroy {
5555
set options(options: google.maps.DirectionsRendererOptions) {
5656
this._options = options;
5757
}
58-
private _options: google.maps.DirectionsRendererOptions;
58+
private _options!: google.maps.DirectionsRendererOptions;
5959

6060
/**
6161
* See developers.google.com/maps/documentation/javascript/reference/directions

src/google-maps/map-ground-overlay/map-ground-overlay.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ describe('MapGroundOverlay', () => {
171171
imports: [GoogleMap, MapGroundOverlay],
172172
})
173173
class TestApp {
174-
@ViewChild(MapGroundOverlay) groundOverlay: MapGroundOverlay;
174+
@ViewChild(MapGroundOverlay) groundOverlay!: MapGroundOverlay;
175175
url!: string;
176176
bounds!: google.maps.LatLngBoundsLiteral;
177177
clickable = false;

0 commit comments

Comments
 (0)