Skip to content

Commit 7f05567

Browse files
committed
fix(cdk/tree): revert signal changes for tests
1 parent c747ceb commit 7f05567

File tree

3 files changed

+25
-24
lines changed

3 files changed

+25
-24
lines changed

src/cdk/tree/tree-using-legacy-key-manager.spec.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {Component, viewChildren, ElementRef} from '@angular/core';
1+
import {Component, QueryList, ViewChildren, ElementRef} from '@angular/core';
22
import {ComponentFixture, TestBed} from '@angular/core/testing';
33
import {of} from 'rxjs';
44
import {CdkTreeModule} from './tree-module';
@@ -15,11 +15,12 @@ describe('CdkTree when provided LegacyTreeKeyManager', () => {
1515

1616
fixture = TestBed.createComponent(SimpleCdkTreeApp);
1717
fixture.detectChanges();
18+
fixture.detectChanges();
1819
});
1920

2021
describe('with default node options', () => {
2122
it('renders nodes with tabindex attribute of -1', () => {
22-
const treeItems = fixture.componentInstance.treeNodes();
23+
const treeItems = fixture.componentInstance.treeNodes;
2324

2425
expect(treeItems.map(x => `${x.nativeElement.getAttribute('tabindex')}`).join(', '))
2526
.withContext('tabindex of tree nodes')
@@ -29,14 +30,14 @@ describe('CdkTree when provided LegacyTreeKeyManager', () => {
2930

3031
describe('when focusing the second node', () => {
3132
beforeEach(() => {
32-
const treeItems = fixture.componentInstance.treeNodes();
33+
const treeItems = fixture.componentInstance.treeNodes;
3334

34-
treeItems[1]!.nativeElement.focus();
35+
treeItems.get(1)!.nativeElement.focus();
3536
fixture.detectChanges();
3637
});
3738

3839
it('does not change tabindex of nodes', () => {
39-
const treeItems = fixture.componentInstance.treeNodes();
40+
const treeItems = fixture.componentInstance.treeNodes;
4041

4142
expect(treeItems.map(x => `${x.nativeElement.getAttribute('tabindex')}`).join(', '))
4243
.withContext('tabindex of tree nodes')
@@ -46,9 +47,9 @@ describe('CdkTree when provided LegacyTreeKeyManager', () => {
4647

4748
describe('when clicking the second node', () => {
4849
beforeEach(() => {
49-
const treeItems = fixture.componentInstance.treeNodes();
50+
const treeItems = fixture.componentInstance.treeNodes;
5051

51-
treeItems[1]!.nativeElement.click();
52+
treeItems.get(1)!.nativeElement.click();
5253
fixture.detectChanges();
5354
});
5455

@@ -57,7 +58,7 @@ describe('CdkTree when provided LegacyTreeKeyManager', () => {
5758
});
5859

5960
it('does not change tabindex of nodes', () => {
60-
const treeItems = fixture.componentInstance.treeNodes();
61+
const treeItems = fixture.componentInstance.treeNodes;
6162

6263
expect(treeItems.map(x => `${x.nativeElement.getAttribute('tabindex')}`).join(', '))
6364
.withContext('tabindex of tree nodes')
@@ -88,5 +89,5 @@ class SimpleCdkTreeApp {
8889

8990
dataSource = of([new MinimalTestData('apple'), new MinimalTestData('banana')]);
9091

91-
readonly treeNodes = viewChildren<ElementRef<HTMLElement>>('node');
92+
@ViewChildren('node') treeNodes: QueryList<ElementRef<HTMLElement>>;
9293
}

src/cdk/tree/tree-with-tree-control.spec.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import {
1313
TrackByFunction,
1414
Type,
1515
EventEmitter,
16-
viewChildren,
17-
viewChild,
16+
ViewChildren,
17+
QueryList,
1818
} from '@angular/core';
1919

2020
import {CollectionViewer, DataSource} from '@angular/cdk/collections';
@@ -81,7 +81,7 @@ describe('CdkTree with TreeControl', () => {
8181
const fixture = TestBed.createComponent(SimpleCdkTreeApp);
8282
fixture.detectChanges();
8383
const spy = jasmine.createSpy('completeSpy');
84-
const subscription = fixture.componentInstance.tree().viewChange.subscribe({complete: spy});
84+
const subscription = fixture.componentInstance.tree.viewChange.subscribe({complete: spy});
8585

8686
fixture.destroy();
8787
expect(spy).toHaveBeenCalled();
@@ -101,7 +101,7 @@ describe('CdkTree with TreeControl', () => {
101101

102102
component = fixture.componentInstance;
103103
dataSource = component.dataSource as FakeDataSource;
104-
tree = component.tree();
104+
tree = component.tree;
105105
treeElement = fixture.nativeElement.querySelector('cdk-tree');
106106
});
107107

@@ -216,7 +216,8 @@ describe('CdkTree with TreeControl', () => {
216216
});
217217

218218
it('should be able to set zero as the indent level', () => {
219-
component.paddingNodes().forEach(node => (node.level = 0));
219+
fixture.detectChanges();
220+
component.paddingNodes.forEach(node => (node.level = 0));
220221

221222
const data = dataSource.data;
222223

@@ -1473,8 +1474,8 @@ class SimpleCdkTreeApp {
14731474
dataSource: FakeDataSource | null = new FakeDataSource(this.treeControl);
14741475
indent: number | string = 28;
14751476

1476-
readonly tree = viewChild.required<CdkTree<TestData>>(CdkTree);
1477-
readonly paddingNodes = viewChildren(CdkTreeNodePadding);
1477+
@ViewChild(CdkTree) tree: CdkTree<TestData>;
1478+
@ViewChildren(CdkTreeNodePadding) paddingNodes: QueryList<CdkTreeNodePadding<TestData>>;
14781479
}
14791480

14801481
@Component({

src/cdk/tree/tree.spec.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import {
1818
ViewChildren,
1919
inject,
2020
ElementRef,
21-
viewChildren,
22-
viewChild,
2321
} from '@angular/core';
2422

2523
import {Direction, Directionality} from '@angular/cdk/bidi';
@@ -88,7 +86,7 @@ describe('CdkTree', () => {
8886
const fixture = TestBed.createComponent(SimpleCdkTreeApp);
8987
fixture.detectChanges();
9088
const spy = jasmine.createSpy('completeSpy');
91-
const subscription = fixture.componentInstance.tree().viewChange.subscribe({complete: spy});
89+
const subscription = fixture.componentInstance.tree.viewChange.subscribe({complete: spy});
9290

9391
fixture.destroy();
9492
expect(spy).toHaveBeenCalled();
@@ -109,7 +107,7 @@ describe('CdkTree', () => {
109107

110108
component = fixture.componentInstance;
111109
dataSource = component.dataSource as FakeDataSource;
112-
tree = component.tree();
110+
tree = component.tree;
113111
treeElement = fixture.nativeElement.querySelector('cdk-tree');
114112
});
115113

@@ -224,7 +222,8 @@ describe('CdkTree', () => {
224222
});
225223

226224
it('should be able to set zero as the indent level', () => {
227-
component.paddingNodes().forEach(node => (node.level = 0));
225+
fixture.detectChanges();
226+
component.paddingNodes.forEach(node => (node.level = 0));
228227

229228
const data = dataSource.data;
230229

@@ -1690,11 +1689,11 @@ class SimpleCdkTreeApp {
16901689
dataSource: FakeDataSource | null = new FakeDataSource();
16911690
indent: number | string = 28;
16921691

1693-
readonly tree = viewChild.required<CdkTree<TestData>>(CdkTree);
1694-
readonly paddingNodes = viewChildren(CdkTreeNodePadding);
1692+
@ViewChild(CdkTree) tree: CdkTree<TestData>;
1693+
@ViewChildren(CdkTreeNodePadding) paddingNodes: QueryList<CdkTreeNodePadding<TestData>>;
16951694

16961695
expandAll() {
1697-
this.tree().expandAll();
1696+
this.tree.expandAll();
16981697
}
16991698
}
17001699

0 commit comments

Comments
 (0)