Skip to content

Commit 821830d

Browse files
alan-agius4devversion
authored andcommitted
build: adopt moduleResolution: "bundler"
This commit updates the TypeScript configuration across the project to use `moduleResolution: "bundler"`. This modernizes our module resolution strategy to align with current TypeScript best practices and bundler behaviors. The following changes are included: - Updated `tsconfig.json` files to set `moduleResolution` to `"bundler"`. - Updated the `rules_angular` bazel dependency to a version compatible with these changes. - Adjusted related test files and golden files to reflect the new module resolution strategy.
1 parent 6fba204 commit 821830d

File tree

12 files changed

+136
-114
lines changed

12 files changed

+136
-114
lines changed

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ git_override(
3232
bazel_dep(name = "rules_angular")
3333
git_override(
3434
module_name = "rules_angular",
35-
commit = "4010ef96de0c46db7764adc2f262258c9de3d718",
35+
commit = "399f782a14ecfd7de7c2736ec7f4f631b6a1b582",
3636
remote = "https://github.com/devversion/rules_angular.git",
3737
)
3838

docs/src/assets/stackblitz/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"declaration": false,
99
"downlevelIteration": true,
1010
"experimentalDecorators": true,
11-
"moduleResolution": "node",
11+
"moduleResolution": "bundler",
1212
"importHelpers": true,
1313
"target": "es2022",
1414
"module": "es2020",

docs/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"declaration": false,
1010
"downlevelIteration": true,
1111
"experimentalDecorators": true,
12-
"module": "es2020",
13-
"moduleResolution": "node",
12+
"module": "es2022",
13+
"moduleResolution": "bundler",
1414
"importHelpers": true,
1515
"target": "ES2022",
1616
"typeRoots": ["node_modules/@types"],

integration/harness-e2e-cli/e2e/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
"compilerOptions": {
33
"module": "es2020",
44
"target": "es2020",
5-
"moduleResolution": "node"
5+
"moduleResolution": "bundler"
66
}
77
}

integration/harness-e2e-cli/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"declaration": false,
1515
"downlevelIteration": true,
1616
"experimentalDecorators": true,
17-
"moduleResolution": "node",
17+
"moduleResolution": "bundler",
1818
"importHelpers": true,
1919
"target": "es2017",
2020
"module": "es2020",

integration/ng-add-standalone/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"declaration": false,
1414
"downlevelIteration": true,
1515
"experimentalDecorators": true,
16-
"moduleResolution": "node",
16+
"moduleResolution": "bundler",
1717
"importHelpers": false,
1818
"target": "es2017",
1919
"module": "es2020",

integration/ng-add/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"declaration": false,
1414
"downlevelIteration": true,
1515
"experimentalDecorators": true,
16-
"moduleResolution": "node",
16+
"moduleResolution": "bundler",
1717
"importHelpers": false,
1818
"target": "es2017",
1919
"module": "es2020",

integration/ts-compat/helpers.mjs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ export async function runTypeScriptCompatibilityTest(tscBinPath) {
2323
'--lib',
2424
'es2015,dom',
2525
testFilePath,
26+
'--moduleResolution',
27+
'bundler',
28+
'--module',
29+
'es2022',
2630
];
2731
// Run `tsc` to compile the project. The stdout/stderr output is inherited, so that
2832
// warnings and errors are printed to the console.

integration/yarn-pnp-compat/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"declaration": false,
1515
"downlevelIteration": true,
1616
"experimentalDecorators": true,
17-
"moduleResolution": "node",
17+
"moduleResolution": "bundler",
1818
"importHelpers": true,
1919
"target": "es2017",
2020
"module": "es2020",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
"prettier": "^3.5.3",
130130
"protractor": "^7.0.0",
131131
"requirejs": "^2.3.6",
132-
"rollup": "^4.0.0",
132+
"rollup": "^4.52.3",
133133
"rollup-plugin-dts": "6.2.3",
134134
"rollup-plugin-sourcemaps2": "0.5.4",
135135
"sass": "^1.80.6",

0 commit comments

Comments
 (0)