Skip to content

Commit 88b718e

Browse files
authored
build: remove init test environment calls from harness examples (#23853)
Removes the init test environment calls from the harness examples. This is meant to make the examples a little more readable, and easier to integrate within CLI projects (especially when are starting to use a plain CLI project as foundation for our StackBlitz examples). The CLI sets up the test environment in a global test init file, so we should make this assumption in our examples as well. This also helps with reducing duplication in our code base.
1 parent 4579377 commit 88b718e

File tree

70 files changed

+38
-351
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+38
-351
lines changed

src/components-examples/material-experimental/mdc-table/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,5 @@ ng_test_library(
5858

5959
ng_web_test_suite(
6060
name = "unit_tests",
61-
exclude_init_script = True,
6261
deps = [":unit_tests_lib"],
6362
)

src/components-examples/material-experimental/mdc-table/table-harness/table-harness-example.spec.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
1-
import {TestBed, ComponentFixture} from '@angular/core/testing';
1+
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatTableHarness} from '@angular/material/table/testing';
44
import {HarnessLoader, parallel} from '@angular/cdk/testing';
5-
import {
6-
BrowserDynamicTestingModule,
7-
platformBrowserDynamicTesting,
8-
} from '@angular/platform-browser-dynamic/testing';
95
import {MatTableModule} from '@angular/material/table';
106
import {TableHarnessExample} from './table-harness-example';
117

128
describe('TableHarnessExample', () => {
139
let fixture: ComponentFixture<TableHarnessExample>;
1410
let loader: HarnessLoader;
1511

16-
beforeAll(() => {
17-
TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
18-
});
19-
2012
beforeEach(async () => {
2113
await TestBed.configureTestingModule({
2214
imports: [MatTableModule],

src/components-examples/material/autocomplete/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,5 @@ ng_test_library(
5252

5353
ng_web_test_suite(
5454
name = "unit_tests",
55-
exclude_init_script = True,
5655
deps = [":unit_tests_lib"],
5756
)

src/components-examples/material/autocomplete/autocomplete-harness/autocomplete-harness-example.spec.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
1-
import {TestBed, ComponentFixture} from '@angular/core/testing';
1+
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatAutocompleteHarness} from '@angular/material/autocomplete/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
5-
import {
6-
BrowserDynamicTestingModule,
7-
platformBrowserDynamicTesting,
8-
} from '@angular/platform-browser-dynamic/testing';
95
import {MatAutocompleteModule} from '@angular/material/autocomplete';
106
import {AutocompleteHarnessExample} from './autocomplete-harness-example';
117

128
describe('AutocompleteHarnessExample', () => {
139
let fixture: ComponentFixture<AutocompleteHarnessExample>;
1410
let loader: HarnessLoader;
1511

16-
beforeAll(() => {
17-
TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
18-
});
19-
2012
beforeEach(async () => {
2113
await TestBed.configureTestingModule({
2214
imports: [MatAutocompleteModule],

src/components-examples/material/badge/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,5 @@ ng_test_library(
4949

5050
ng_web_test_suite(
5151
name = "unit_tests",
52-
exclude_init_script = True,
5352
deps = [":unit_tests_lib"],
5453
)

src/components-examples/material/badge/badge-harness/badge-harness-example.spec.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
1-
import {TestBed, ComponentFixture} from '@angular/core/testing';
1+
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatBadgeHarness} from '@angular/material/badge/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
5-
import {
6-
BrowserDynamicTestingModule,
7-
platformBrowserDynamicTesting,
8-
} from '@angular/platform-browser-dynamic/testing';
95
import {MatBadgeModule} from '@angular/material/badge';
106
import {BadgeHarnessExample} from './badge-harness-example';
117

128
describe('BadgeHarnessExample', () => {
139
let fixture: ComponentFixture<BadgeHarnessExample>;
1410
let loader: HarnessLoader;
1511

16-
beforeAll(() => {
17-
TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
18-
});
19-
2012
beforeEach(async () => {
2113
await TestBed.configureTestingModule({
2214
imports: [MatBadgeModule],

src/components-examples/material/bottom-sheet/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,5 @@ ng_test_library(
5151

5252
ng_web_test_suite(
5353
name = "unit_tests",
54-
exclude_init_script = True,
5554
deps = [":unit_tests_lib"],
5655
)

src/components-examples/material/bottom-sheet/bottom-sheet-harness/bottom-sheet-harness-example.spec.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
import {TestBed, ComponentFixture} from '@angular/core/testing';
1+
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatBottomSheetHarness} from '@angular/material/bottom-sheet/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
5-
import {
6-
BrowserDynamicTestingModule,
7-
platformBrowserDynamicTesting,
8-
} from '@angular/platform-browser-dynamic/testing';
95
import {MatBottomSheetModule} from '@angular/material/bottom-sheet';
106
import {BottomSheetHarnessExample} from './bottom-sheet-harness-example';
117
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
@@ -14,10 +10,6 @@ describe('BottomSheetHarnessExample', () => {
1410
let fixture: ComponentFixture<BottomSheetHarnessExample>;
1511
let loader: HarnessLoader;
1612

17-
beforeAll(() => {
18-
TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
19-
});
20-
2113
beforeEach(async () => {
2214
await TestBed.configureTestingModule({
2315
imports: [MatBottomSheetModule, NoopAnimationsModule],

src/components-examples/material/button-toggle/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,5 @@ ng_test_library(
4848

4949
ng_web_test_suite(
5050
name = "unit_tests",
51-
exclude_init_script = True,
5251
deps = [":unit_tests_lib"],
5352
)

src/components-examples/material/button-toggle/button-toggle-harness/button-toggle-harness-example.spec.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
1-
import {TestBed, ComponentFixture} from '@angular/core/testing';
1+
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatButtonToggleGroupHarness} from '@angular/material/button-toggle/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
5-
import {
6-
BrowserDynamicTestingModule,
7-
platformBrowserDynamicTesting,
8-
} from '@angular/platform-browser-dynamic/testing';
95
import {MatButtonToggleModule} from '@angular/material/button-toggle';
106
import {ButtonToggleHarnessExample} from './button-toggle-harness-example';
117

128
describe('ButtonToggleHarnessExample', () => {
139
let fixture: ComponentFixture<ButtonToggleHarnessExample>;
1410
let loader: HarnessLoader;
1511

16-
beforeAll(() => {
17-
TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
18-
});
19-
2012
beforeEach(async () => {
2113
await TestBed.configureTestingModule({
2214
imports: [MatButtonToggleModule],

0 commit comments

Comments
 (0)