Skip to content

Commit 8ef699d

Browse files
devversionmmalerba
authored andcommitted
build: remove incorrect sass binary for mdc-tabs theme (#18097)
We never want to build a CSS file for Sass partial files. The CSS files would be empty since the sources only contain mixins. The `_mdc-tabs.scss` file is a plain partial consumed by the theming and typography system. Building it through `sass_binary` is unnecessary and causes ambiguous dependency setup (two rules with separate dependencies)
1 parent 9e7ba25 commit 8ef699d

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/material-experimental/mdc-tabs/BUILD.bazel

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ ng_module(
1818
exclude = ["**/*.spec.ts"],
1919
),
2020
assets = [
21-
":tabs_scss",
2221
":tab-body.css",
2322
":tab-header.css",
2423
":tab-group.css",
@@ -53,16 +52,6 @@ sass_library(
5352
],
5453
)
5554

56-
sass_binary(
57-
name = "tabs_scss",
58-
src = "_mdc-tabs.scss",
59-
include_paths = ["external/npm/node_modules"],
60-
deps = [
61-
"//src/material-experimental/mdc-helpers:mdc_helpers_scss_lib",
62-
"//src/material-experimental/mdc-helpers:mdc_scss_deps_lib",
63-
],
64-
)
65-
6655
sass_binary(
6756
name = "mdc_tab_body_scss",
6857
src = "tab-body.scss",

0 commit comments

Comments
 (0)