chore: add support for noImplicitThis (#13404)

Author: crisbeto

e2e/tsconfig.json

@@ -7,6 +7,7 @@
     "experimentalDecorators": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
+    "noImplicitThis": true,
     "inlineSources": true,
     "lib": ["es2015"],
     "module": "commonjs",

e2e/util/asserts.ts

@@ -34,6 +34,6 @@ export function expectLocation(element: FinderResult, {x, y}: Point): void {
  */
 export function expectAlignedWith(element: FinderResult, otherElement: FinderResult): void {
   getElement(otherElement).getLocation().then((location: Point) => {
-    this.expectLocation(getElement(element), location);
+    expectLocation(getElement(element), location);
   });
 }

src/bazel-tsconfig-build.json

@@ -13,6 +13,7 @@
     "strictNullChecks": true,
     "strictFunctionTypes": true,
     "noImplicitAny": true,
+    "noImplicitThis": true,
     "importHelpers": true,
     "newLine": "lf",
     "module": "es2015",

src/cdk-experimental/tsconfig-build.json

@@ -9,6 +9,7 @@
     "strictNullChecks": true,
     "strictFunctionTypes": true,
     "noImplicitAny": true,
+    "noImplicitThis": true,
     "importHelpers": true,
     "newLine": "lf",
     "module": "es2015",

src/cdk/a11y/interactivity-checker/interactivity-checker.spec.ts

@@ -509,7 +509,7 @@ describe('InteractivityChecker', () => {
     }
   }
 
-  function runIf(condition: boolean, runFn: Function): () => void {
+  function runIf(this: any, condition: boolean, runFn: Function): () => void {
     return (...args: any[]) => {
       if (condition) {
         runFn.apply(this, args);

src/cdk/a11y/key-manager/list-key-manager.spec.ts

@@ -37,6 +37,10 @@ class FakeQueryList<T> extends QueryList<T> {
   notifyOnChanges() { this.changes.next(this); }
 }
 
+interface KeyEventTestContext {
+  nextKeyEvent: KeyboardEvent;
+  prevKeyEvent: KeyboardEvent;
+}
 
 describe('Key managers', () => {
   let itemList: FakeQueryList<any>;
@@ -164,7 +168,7 @@ describe('Key managers', () => {
         expect(fakeKeyEvents.downArrow.defaultPrevented).toBe(false);
       });
 
-      describe('with `vertical` direction', () => {
+      describe('with `vertical` direction', function(this: KeyEventTestContext) {
         beforeEach(() => {
           keyManager.withVerticalOrientation();
           this.nextKeyEvent = createKeyboardEvent('keydown', DOWN_ARROW);
@@ -174,7 +178,7 @@ describe('Key managers', () => {
         runDirectionalKeyTests.call(this);
       });
 
-      describe('with `ltr` direction', () => {
+      describe('with `ltr` direction', function(this: KeyEventTestContext) {
         beforeEach(() => {
           keyManager.withHorizontalOrientation('ltr');
           this.nextKeyEvent = createKeyboardEvent('keydown', RIGHT_ARROW);
@@ -184,7 +188,7 @@ describe('Key managers', () => {
         runDirectionalKeyTests.call(this);
       });
 
-      describe('with `rtl` direction', () => {
+      describe('with `rtl` direction', function(this: KeyEventTestContext) {
         beforeEach(() => {
           keyManager.withHorizontalOrientation('rtl');
           this.nextKeyEvent = createKeyboardEvent('keydown', LEFT_ARROW);
@@ -199,7 +203,7 @@ describe('Key managers', () => {
        * parameters have to be passed in via Jasmine's context object (`this` inside a `beforeEach`)
        * because this function has to run before any `beforeEach`, `beforeAll` etc. hooks.
        */
-      function runDirectionalKeyTests() {
+      function runDirectionalKeyTests(this: KeyEventTestContext) {
         it('should set subsequent items as active when the next key is pressed', () => {
           keyManager.onKeydown(this.nextKeyEvent);
 

src/demo-app/tsconfig-aot.json

@@ -10,6 +10,7 @@
     "strictNullChecks": true,
     "strictFunctionTypes": true,
     "noImplicitAny": true,
+    "noImplicitThis": true,
     "outDir": "../../dist/packages/demo-app",
     "rootDirs": [
       ".",

src/demo-app/tsconfig-build.json

@@ -10,6 +10,7 @@
     "noUnusedParameters": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
+    "noImplicitThis": true,
     "lib": ["es6", "es2015", "dom"],
     "skipLibCheck": true,
     "module": "commonjs",

src/e2e-app/tsconfig-build.json

@@ -10,6 +10,7 @@
     // strict-null compliant.
     "strictNullChecks": false,
     "strictFunctionTypes": true,
+    "noImplicitThis": true,
     "lib": ["es6", "es2015", "dom"],
     "module": "commonjs",
     "moduleResolution": "node",

src/lib/tsconfig-build.json

@@ -8,6 +8,7 @@
     "strictNullChecks": true,
     "strictFunctionTypes": true,
     "noImplicitAny": true,
+    "noImplicitThis": true,
     "importHelpers": true,
     "newLine": "lf",
     "module": "es2015",