build: make custom devserver work with e2e tests

For APF v13, we will switch to the custom devserver we have used for
the dev-app as well. We do this because the ConcatJS devserver is no
longer needed due to us bundling the e2e-app.

Note again: This is needed because FW packages do no longer ship UMD
files, and we also need to consolidate our pre-built linker ESM bundles
of the Angular framework packages. A bundler like ESBuild will do that
job for us. It's fast enough that it's subjectively significantly faster
than ConcatJS/RequireJS resolving deps at runtime in the browser..

Author: devversion

src/e2e-app/start-devserver.js

@@ -10,7 +10,7 @@ const utils = require('@bazel/protractor/protractor-utils.js');
  * starting up the devserver and updating the Protractor base URL to the proper port.
  */
 module.exports = async function(config) {
-  const {port} = await utils.runServer(config.workspace, config.server, '-port', []);
+  const {port} = await utils.runServer(config.workspace, config.server, '--port', []);
   const baseUrl = `http://localhost:${port}`;
   const processedConfig = await protractor.browser.getProcessedConfig();
 

tools/dev-server/ibazel.ts

@@ -18,6 +18,11 @@ const ibazelNotifySuccessMessage = 'IBAZEL_BUILD_COMPLETED SUCCESS';
  * over "stdin", the devserver can be reloaded.
  */
 export function setupBazelWatcherSupport(server: DevServer) {
+  // If iBazel is not configured for this process, we do not setup the watcher.
+  if (process.env['IBAZEL_NOTIFY_CHANGES'] !== 'y') {
+    return;
+  }
+
   // ibazel communicates via the stdin interface.
   const rl = createInterface({input: process.stdin, terminal: false});
 

tools/dev-server/index.bzl

@@ -41,7 +41,6 @@ def _dev_server_rule_impl(ctx):
     # into a string representing the command line arguments. It looks like bazel has some
     # internal logic to compute the string representation of "ctx.actions.args()".
     args = '--root_paths="%s" ' % ",".join(root_paths)
-    args += "--port=%s " % ctx.attr.port
 
     if ctx.attr.historyApiFallback:
         args += "--historyApiFallback "
@@ -87,10 +86,6 @@ dev_server_rule = rule(
             This is helpful for single page applications using the HTML history API.
           """,
         ),
-        "port": attr.int(
-            default = 4200,
-            doc = """The port that the devserver will listen on.""",
-        ),
         "srcs": attr.label_list(allow_files = True, doc = """
           Sources that should be available to the dev-server. This attribute can be
           used for explicit files. This attribute only uses the files exposed by the
@@ -110,11 +105,12 @@ dev_server_rule = rule(
   request files through their manifest path: "my_workspace/src/dev-app/my-genfile".
 """
 
-def dev_server(name, testonly = False, tags = [], **kwargs):
+def dev_server(name, testonly = False, port = 4200, tags = [], **kwargs):
     dev_server_rule(
         name = "%s_launcher" % name,
         visibility = ["//visibility:private"],
         tags = tags,
+        testonly = testonly,
         **kwargs
     )
 
@@ -125,5 +121,6 @@ def dev_server(name, testonly = False, tags = [], **kwargs):
         tags = tags + ["ibazel_notify_changes"],
         srcs = ["%s_launcher.sh" % name],
         data = [":%s_launcher" % name],
+        args = ["--port=%s" % port],
         testonly = testonly,
     )

tools/dev-server/launcher_template.sh

@@ -14,10 +14,6 @@ source "$(grep -sm1 "^$f " "$0.exe.runfiles_manifest" | cut -f2- -d' ')" 2>/dev/
 { echo>&2 "ERROR: cannot find $f"; exit 1; }; f=; set -e
 # --- end runfiles.bash initialization v2 ---
 
-if [[ ! -z "RUNFILES_DIR" ]]; then
-  export RUNFILES_MANIFEST_ONLY="1"
-fi
-
 # Resolve the path of the dev-server binary. Note: usually we either need to
 # resolve the "nodejs_binary" executable with different file extensions on
 # windows, but since we already run this launcher as part of a "sh_binary", we
@@ -26,4 +22,4 @@ devserverBin=$(rlocation "angular_material/tools/dev-server/dev-server_bin.sh")
 
 # Start the devserver with the given arguments. The arguments will be
 # substituted based on the rule attributes.
-${devserverBin} TEMPLATED_args
+${devserverBin} TEMPLATED_args "$@"