build: no longer depend on gulp for lint tasks (#17516)

* Fixes the `prefer-literal` lint rule not actually running because it wasn't loaded in the tslint.json.
* Converts the CODEOWNERS linting task into a regular Node script that doesn't depend on Gulp.
* Turns the `stylelint` and `tslint` tasks into npm scripts.
* Runs the new npm scripts directly rather than through Gulp on the CI.

Author: crisbeto

.circleci/config.yml

@@ -252,7 +252,7 @@ jobs:
     - run: ./scripts/circleci/run-saucelabs-tests.sh
 
   # ----------------------------------
-  # Lint job. Runs the gulp lint task.
+  # Lint job.
   # ----------------------------------
   lint:
     <<: *job_defaults
@@ -271,7 +271,9 @@ jobs:
             yarn check-rollup-globals $(bazel info bazel-bin)/rollup_globals.json
 
       - run: ./scripts/circleci/lint-bazel-files.sh
-      - run: yarn gulp ci:lint
+      - run: yarn ownerslint
+      - run: yarn stylelint
+      - run: yarn tslint
 
       - *save_cache
 

package.json

@@ -35,7 +35,10 @@
     "format:bazel": "yarn -s bazel:buildifier --lint=fix --mode=fix",
     "format": "yarn -s format:ts && yarn -s format:bazel",
     "cherry-pick-patch": "ts-node --project tools/cherry-pick-patch/ tools/cherry-pick-patch/cherry-pick-patch.ts",
-    "check-rollup-globals": "ts-node --project scripts/ scripts/check-rollup-globals.ts"
+    "check-rollup-globals": "ts-node --project scripts/ scripts/check-rollup-globals.ts",
+    "ownerslint": "ts-node --project scripts/ scripts/ownerslint.ts",
+    "tslint": "tslint -c tslint.json --project ./tsconfig.json",
+    "stylelint": "stylelint \"src/**/*.+(css|scss)\" --config .stylelintrc.json --syntax scss"
   },
   "version": "9.0.0-next.1",
   "requiredAngularVersion": "^9.0.0-0 || ^10.0.0-0",

scripts/ownerslint.ts

@@ -0,0 +1,73 @@
+import chalk from 'chalk';
+import {readdirSync, readFileSync, statSync} from 'fs';
+import {IMinimatch, Minimatch} from 'minimatch';
+import {join} from 'path';
+
+/**
+ * Script that lints the CODEOWNERS file and makes sure that all files have an owner.
+ */
+
+/** Path for the Github owners file. */
+const ownersFilePath = '.github/CODEOWNERS';
+
+/** Path for the .gitignore file. */
+const gitIgnorePath = '.gitignore';
+
+let errors = 0;
+const ownedPaths = readFileSync(ownersFilePath, 'utf8').split('\n')
+    // Trim lines.
+    .map(line => line.trim())
+    // Remove empty lines and comments.
+    .filter(line => line && !line.startsWith('#'))
+    // Split off just the path glob.
+    .map(line => line.split(/\s+/)[0])
+    // Turn paths into Minimatch objects.
+    .map(path => new Minimatch(path, {dot: true, matchBase: true}));
+
+const ignoredPaths = readFileSync(gitIgnorePath, 'utf8').split('\n')
+    // Trim lines.
+    .map(line => line.trim())
+    // Remove empty lines and comments.
+    .filter(line => line && !line.startsWith('#'))
+    // Turn paths into Minimatch objects.
+    .map(path => new Minimatch(path, {dot: true, matchBase: true}));
+
+for (let paths = getChildPaths('.'); paths.length;) {
+  paths = Array.prototype.concat(...paths
+      // Remove ignored paths
+      .filter(path => !ignoredPaths.reduce(
+          (isIgnored, ignoredPath) => isIgnored || ignoredPath.match('/' + path), false))
+      // Remove paths that match an owned path.
+      .filter(path => !ownedPaths.reduce(
+          (isOwned, ownedPath) => isOwned || isOwnedBy(path, ownedPath), false))
+      // Report an error for any files that didn't match any owned paths.
+      .filter(path => {
+        if (statSync(path).isFile()) {
+          console.log(chalk.red(`No code owner found for "${path}".`));
+          errors++;
+          return false;
+        }
+        return true;
+      })
+      // Get the next level of children for any directories.
+      .map(path => getChildPaths(path)));
+}
+
+if (errors) {
+  throw Error(`Found ${errors} files with no owner. Code owners for the files ` +
+              `should be added in the CODEOWNERS file.`);
+}
+
+/** Check if the given path is owned by the given owned path matcher. */
+function isOwnedBy(path: string, ownedPath: IMinimatch) {
+  // If the owned path ends with `**` its safe to eliminate whole directories.
+  if (ownedPath.pattern.endsWith('**') || statSync(path).isFile()) {
+    return ownedPath.match('/' + path);
+  }
+  return false;
+}
+
+/** Get the immediate child paths of the given path. */
+function getChildPaths(path: string) {
+  return readdirSync(path).map(child => join(path, child));
+}

tools/gulp/gulpfile.ts

@@ -25,7 +25,6 @@ import './tasks/ci';
 import './tasks/clean';
 import './tasks/default';
 import './tasks/example-module';
-import './tasks/lint';
 import './tasks/material-release';
 import './tasks/unit-test';
 

tools/gulp/tasks/ci.ts

@@ -1,7 +1,5 @@
 import {task} from 'gulp';
 
-task('ci:lint', ['lint']);
-
 // Gulp sometimes does not exit properly on CI. This is to prevent that.
 // TODO(devversion): look if there is some blocking child process.
 task('ci:test', ['test:single-run'], () => process.exit(0));

tools/gulp/tasks/lint.ts

@@ -1,6 +1,7 @@
 {
   "rulesDirectory": [
     "./tools/tslint-rules/",
+    "node_modules/vrsource-tslint-rules/rules",
     "node_modules/codelyzer"
   ],
   "rules": {