refactor: lint and tests

Author: andrewseguin

src/material/core/theming/_theming.scss

@@ -4,6 +4,10 @@
 @use 'sass:meta';
 @use 'sass:color';
 
+// Deprecated flag that is no longer used to control duplication warnings.
+// Remove in v22
+$theme-ignore-duplication-warnings: false;
+
 // Whether to enable compatibility with legacy methods for accessing theme information.
 $theme-legacy-inspection-api-compatibility: true !default;
 

src/material/core/theming/tests/test-theming-api.scss

@@ -9,10 +9,6 @@
 @use '../theming';
 @use 'sass:map';
 
-// Disable theme style duplication warnings. This test intentionally generates
-// the same themes multiple times.
-theming.$theme-ignore-duplication-warnings: true;
-
 // A new way to configure themes has been introduced. This Sass file ensures that the theming
 // API is backwards compatible, so that the old pattern for configuring themes can be still
 // used. The Sass compilation of this file will fail if one of the tests/assertions fails.

src/material/core/theming/tests/test-theming-bundle.scss

@@ -3,10 +3,6 @@
 // with the include paths being set to the `bazel-bin` directory.
 @use '../../../index' as mat;
 
-// Disable theme style duplication warnings. This test intentionally generates
-// the same themes multiple times.
-mat.$theme-ignore-duplication-warnings: true;
-
 // If one of these mixins or function is not available, the compilation will fail and the
 // test will be reported as failing.
 

src/material/core/theming/tests/theming-mixin-api.spec.ts

@@ -29,150 +29,6 @@ describe('theming api', () => {
     });
   });
 
-  it('should warn if color styles are duplicated', () => {
-    spyOn(process.stderr, 'write');
-
-    transpile(`
-      $theme: mat.m2-define-light-theme((
-        color: (
-          primary: mat.m2-define-palette(mat.$m2-red-palette),
-          accent: mat.m2-define-palette(mat.$m2-red-palette),
-        )
-      ));
-
-      @include mat.all-component-themes($theme);
-
-      .dark-theme {
-        @include mat.all-component-themes($theme);
-      }
-    `);
-
-    expectWarning(/The same color styles are generated multiple times/);
-  });
-
-  it('should not warn if color styles and density are not duplicated', () => {
-    const parsed = parse(
-      transpile(`
-      $theme: mat.m2-define-light-theme((
-        color: (
-          primary: mat.m2-define-palette(mat.$m2-red-palette),
-          accent: mat.m2-define-palette(mat.$m2-red-palette),
-        )
-      ));
-      $theme2: mat.m2-define-light-theme((
-        color: (
-          primary: mat.m2-define-palette(mat.$m2-red-palette),
-          accent: mat.m2-define-palette(mat.$m2-blue-palette),
-        )
-      ));
-
-      @include mat.all-component-themes($theme);
-
-      .dark-theme {
-        @include mat.all-component-colors($theme2);
-      }
-    `),
-    );
-
-    expect(hasDensityStyles(parsed, null)).toBe('all');
-    expect(hasDensityStyles(parsed, '.dark-theme')).toBe('none');
-    expectNoWarning(/The same color styles are generated multiple times/);
-  });
-
-  it('should warn if default density styles are duplicated', () => {
-    spyOn(process.stderr, 'write');
-
-    const parsed = parse(
-      transpile(`
-      @include mat.all-component-themes((color: null));
-
-      .dark-theme {
-        @include mat.all-component-themes((color: null));
-      }
-    `),
-    );
-
-    expect(hasDensityStyles(parsed, null)).toBe('all');
-    // TODO(mmalerba): Re-enable - disabled because this test does not account
-    //  for the fact that:
-    //  ```scss
-    //  @include mat.button-theme($theme);
-    //  @include mat.checkbox-theme($theme);
-    //  ```
-    //  produces different results than:
-    //  ```scss
-    //  html {
-    //    @include mat.button-theme($theme);
-    //    @include mat.checkbox-theme($theme);
-    //  }
-    //  ```
-    // expect(hasDensityStyles(parsed, '.dark-theme')).toBe('all');
-    expectWarning(/The same density styles are generated multiple times/);
-  });
-
-  it('should warn if density styles are duplicated', () => {
-    spyOn(process.stderr, 'write');
-
-    transpile(`
-      @include mat.all-component-themes((density: -1));
-
-      .dark-theme {
-        @include mat.all-component-themes((density: -1));
-      }
-    `);
-
-    expectWarning(/The same density styles are generated multiple times/);
-  });
-
-  it('should not warn if density styles are not duplicated', () => {
-    spyOn(process.stderr, 'write');
-
-    transpile(`
-      @include mat.all-component-themes((density: -1));
-
-      .dark-theme {
-        @include mat.all-component-themes((density: -2));
-      }
-    `);
-
-    expect(process.stderr.write).toHaveBeenCalledTimes(0);
-  });
-
-  it('should warn if typography styles are duplicated', () => {
-    spyOn(process.stderr, 'write');
-
-    transpile(`
-      $theme: (typography: mat.m2-define-typography-config(), density: null);
-      @include mat.all-component-themes($theme);
-
-      .dark-theme {
-        @include mat.all-component-themes($theme);
-      }
-    `);
-
-    expectWarning(/The same typography styles are generated multiple times/);
-  });
-
-  it('should not warn if typography styles are not duplicated', () => {
-    spyOn(process.stderr, 'write');
-
-    transpile(`
-      @include mat.all-component-themes((
-        typography: mat.m2-define-typography-config(),
-        density: null,
-      ));
-
-      .dark-theme {
-        @include mat.all-component-themes((
-          typography: mat.m2-define-typography-config($font-family: "sans-serif"),
-          density: null,
-        ));
-      }
-    `);
-
-    expect(process.stderr.write).toHaveBeenCalledTimes(0);
-  });
-
   /**
    * Checks whether the given parsed stylesheet contains density styles scoped to
    * a given selector. If the selector is `null`, then density is expected to be