Skip to content

Commit b5ff571

Browse files
committed
build: remove usages of CommonModule in the dev app (#29869)
`CommonModule` was being used primarily for the control flow directives which have been replaced by the built-in control flow syntax. These changes either remove it or replace it with importing the individual symbols. (cherry picked from commit fe4271f)
1 parent 2d75191 commit b5ff571

File tree

39 files changed

+34
-133
lines changed

39 files changed

+34
-133
lines changed

src/dev-app/autocomplete/autocomplete-demo.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {CommonModule} from '@angular/common';
9+
import {JsonPipe} from '@angular/common';
1010
import {ChangeDetectionStrategy, Component, inject, ViewChild} from '@angular/core';
1111
import {FormControl, FormsModule, NgModel, ReactiveFormsModule} from '@angular/forms';
1212
import {MatAutocompleteModule} from '@angular/material/autocomplete';
@@ -36,7 +36,7 @@ type DisableStateOption = 'none' | 'first-middle-last' | 'all';
3636
styleUrl: 'autocomplete-demo.css',
3737
standalone: true,
3838
imports: [
39-
CommonModule,
39+
JsonPipe,
4040
FormsModule,
4141
MatAutocompleteModule,
4242
MatButtonModule,
@@ -246,7 +246,7 @@ export class AutocompleteDemo {
246246
}
247247
`,
248248
standalone: true,
249-
imports: [CommonModule, FormsModule, MatAutocompleteModule, MatButtonModule, MatInputModule],
249+
imports: [FormsModule, MatAutocompleteModule, MatButtonModule, MatInputModule],
250250
changeDetection: ChangeDetectionStrategy.OnPush,
251251
})
252252
export class AutocompleteDemoExampleDialog {

src/dev-app/badge/badge-demo.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {CommonModule} from '@angular/common';
109
import {ChangeDetectionStrategy, Component} from '@angular/core';
1110
import {FormsModule} from '@angular/forms';
1211
import {MatBadgeModule} from '@angular/material/badge';
@@ -18,7 +17,7 @@ import {MatIconModule} from '@angular/material/icon';
1817
templateUrl: 'badge-demo.html',
1918
styleUrl: 'badge-demo.css',
2019
standalone: true,
21-
imports: [CommonModule, FormsModule, MatBadgeModule, MatButtonModule, MatIconModule],
20+
imports: [FormsModule, MatBadgeModule, MatButtonModule, MatIconModule],
2221
changeDetection: ChangeDetectionStrategy.OnPush,
2322
})
2423
export class BadgeDemo {

src/dev-app/baseline/baseline-demo.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {CommonModule} from '@angular/common';
109
import {ChangeDetectionStrategy, Component} from '@angular/core';
1110
import {MatCardModule} from '@angular/material/card';
1211
import {MatCheckboxModule} from '@angular/material/checkbox';
@@ -22,7 +21,6 @@ import {MatToolbarModule} from '@angular/material/toolbar';
2221
styleUrl: 'baseline-demo.css',
2322
standalone: true,
2423
imports: [
25-
CommonModule,
2624
MatCardModule,
2725
MatCheckboxModule,
2826
MatFormFieldModule,

src/dev-app/bottom-sheet/bottom-sheet-demo.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {CommonModule} from '@angular/common';
109
import {ChangeDetectionStrategy, Component, TemplateRef, ViewChild, inject} from '@angular/core';
1110
import {FormsModule} from '@angular/forms';
1211
import {
@@ -32,7 +31,6 @@ const defaultConfig = new MatBottomSheetConfig();
3231
templateUrl: 'bottom-sheet-demo.html',
3332
standalone: true,
3433
imports: [
35-
CommonModule,
3634
FormsModule,
3735
MatBottomSheetModule,
3836
MatButtonModule,
@@ -80,7 +78,7 @@ export class BottomSheetDemo {
8078
</mat-nav-list>
8179
`,
8280
standalone: true,
83-
imports: [CommonModule, MatListModule],
81+
imports: [MatListModule],
8482
changeDetection: ChangeDetectionStrategy.OnPush,
8583
})
8684
export class ExampleBottomSheet {

src/dev-app/button-toggle/button-toggle-demo.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {CommonModule} from '@angular/common';
109
import {ChangeDetectionStrategy, Component} from '@angular/core';
1110
import {FormsModule} from '@angular/forms';
1211
import {MatButtonToggleModule} from '@angular/material/button-toggle';
@@ -18,7 +17,7 @@ import {MatIconModule} from '@angular/material/icon';
1817
templateUrl: 'button-toggle-demo.html',
1918
styleUrl: 'button-toggle-demo.css',
2019
standalone: true,
21-
imports: [CommonModule, FormsModule, MatButtonToggleModule, MatCheckboxModule, MatIconModule],
20+
imports: [FormsModule, MatButtonToggleModule, MatCheckboxModule, MatIconModule],
2221
changeDetection: ChangeDetectionStrategy.OnPush,
2322
})
2423
export class ButtonToggleDemo {

src/dev-app/cdk-experimental-combobox/cdk-combobox-demo.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,12 @@
77
*/
88

99
import {CdkComboboxModule} from '@angular/cdk-experimental/combobox';
10-
import {CommonModule} from '@angular/common';
1110
import {ChangeDetectionStrategy, Component} from '@angular/core';
1211

1312
@Component({
1413
templateUrl: 'cdk-combobox-demo.html',
1514
standalone: true,
16-
imports: [CdkComboboxModule, CommonModule],
15+
imports: [CdkComboboxModule],
1716
changeDetection: ChangeDetectionStrategy.OnPush,
1817
})
1918
export class CdkComboboxDemo {}

src/dev-app/cdk-menu/cdk-menu-demo.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import {CdkMenuModule} from '@angular/cdk/menu';
1010
import {ConnectedPosition} from '@angular/cdk/overlay';
11-
import {CommonModule} from '@angular/common';
1211
import {
1312
CdkMenuContextExample,
1413
CdkMenuInlineExample,
@@ -25,7 +24,6 @@ import {ChangeDetectionStrategy, Component} from '@angular/core';
2524
standalone: true,
2625
imports: [
2726
CdkMenuModule,
28-
CommonModule,
2927
CdkMenuStandaloneMenuExample,
3028
CdkMenuStandaloneStatefulMenuExample,
3129
CdkMenuMenubarExample,

src/dev-app/checkbox/checkbox-demo.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {CommonModule} from '@angular/common';
109
import {ANIMATION_MODULE_TYPE, ChangeDetectionStrategy, Component, Directive} from '@angular/core';
1110
import {FormsModule, ReactiveFormsModule} from '@angular/forms';
1211
import {MAT_CHECKBOX_DEFAULT_OPTIONS, MatCheckboxModule} from '@angular/material/checkbox';
@@ -51,7 +50,7 @@ export class AnimationsNoop {}
5150
`,
5251
templateUrl: 'nested-checklist.html',
5352
standalone: true,
54-
imports: [CommonModule, MatCheckboxModule, FormsModule],
53+
imports: [MatCheckboxModule, FormsModule],
5554
changeDetection: ChangeDetectionStrategy.OnPush,
5655
})
5756
export class MatCheckboxDemoNestedChecklist {
@@ -104,7 +103,6 @@ export class MatCheckboxDemoNestedChecklist {
104103
styleUrl: 'checkbox-demo.css',
105104
standalone: true,
106105
imports: [
107-
CommonModule,
108106
FormsModule,
109107
MatCheckboxModule,
110108
MatInputModule,

src/dev-app/chips/chips-demo.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import {LiveAnnouncer} from '@angular/cdk/a11y';
1010
import {COMMA, ENTER} from '@angular/cdk/keycodes';
11-
import {CommonModule} from '@angular/common';
1211
import {ChangeDetectionStrategy, Component, inject} from '@angular/core';
1312
import {FormsModule, ReactiveFormsModule} from '@angular/forms';
1413
import {MatButtonModule} from '@angular/material/button';
@@ -35,7 +34,6 @@ export interface DemoColor {
3534
styleUrl: 'chips-demo.css',
3635
standalone: true,
3736
imports: [
38-
CommonModule,
3937
FormsModule,
4038
MatButtonModule,
4139
MatCardModule,

src/dev-app/connected-overlay/connected-overlay-demo.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {
1616
VerticalConnectionPos,
1717
} from '@angular/cdk/overlay';
1818
import {TemplatePortal} from '@angular/cdk/portal';
19-
import {CommonModule} from '@angular/common';
2019
import {CdkOverlayBasicExample} from '@angular/components-examples/cdk/overlay';
2120
import {
2221
ChangeDetectionStrategy,
@@ -40,7 +39,6 @@ import {MatRadioModule} from '@angular/material/radio';
4039
standalone: true,
4140
imports: [
4241
CdkOverlayBasicExample,
43-
CommonModule,
4442
FormsModule,
4543
MatButtonModule,
4644
MatCheckboxModule,

0 commit comments

Comments
 (0)