refactor: fix CI failures for 9.0.x branch (#18300)

Bumps all of the Angular dependencies to 9.0.0-rc.9 and update failing api goldens

Co-authored-by: Kristiyan Kostadinov <[email protected]>

Author: 2 people

package.json

@@ -77,7 +77,7 @@
     "@bazel/typescript": "1.0.0",
     "@firebase/app-types": "^0.3.2",
     "@octokit/rest": "^16.28.7",
-    "@schematics/angular": "^9.0.0-rc.8",
+    "@schematics/angular": "^9.0.0-rc.10",
     "@types/browser-sync": "^2.26.1",
     "@types/fs-extra": "^4.0.3",
     "@types/glob": "^5.0.33",
@@ -146,14 +146,14 @@
     "terser": "^4.3.9",
     "ts-api-guardian": "^0.4.6",
     "ts-node": "^3.0.4",
-    "tsickle": "^0.37.1",
+    "tsickle": "0.38.0",
     "tslint": "^5.20.0",
     "tsutils": "^3.0.0",
-    "typescript": "^3.6.4",
+    "typescript": "~3.7.4",
     "vrsource-tslint-rules": "5.1.1"
   },
   "resolutions": {
-    "dgeni-packages/typescript": "3.6.4",
+    "dgeni-packages/typescript": "3.7.4",
     "**/graceful-fs": "4.2.2"
   }
 }

tools/public_api_guard/cdk/a11y.d.ts

@@ -25,7 +25,8 @@ export declare const CDK_DESCRIBEDBY_HOST_ATTRIBUTE = "cdk-describedby-host";
 export declare const CDK_DESCRIBEDBY_ID_PREFIX = "cdk-describedby-message";
 
 export declare class CdkAriaLive implements OnDestroy {
-    politeness: AriaLivePoliteness;
+    get politeness(): AriaLivePoliteness;
+    set politeness(value: AriaLivePoliteness);
     constructor(_elementRef: ElementRef, _liveAnnouncer: LiveAnnouncer, _contentObserver: ContentObserver, _ngZone: NgZone);
     ngOnDestroy(): void;
     static ɵdir: i0.ɵɵDirectiveDefWithMeta<CdkAriaLive, "[cdkAriaLive]", ["cdkAriaLive"], { "politeness": "cdkAriaLive"; }, {}, never>;
@@ -41,8 +42,10 @@ export declare class CdkMonitorFocus implements OnDestroy {
 }
 
 export declare class CdkTrapFocus implements OnDestroy, AfterContentInit, DoCheck {
-    autoCapture: boolean;
-    enabled: boolean;
+    get autoCapture(): boolean;
+    set autoCapture(value: boolean);
+    get enabled(): boolean;
+    set enabled(value: boolean);
     focusTrap: FocusTrap;
     constructor(_elementRef: ElementRef<HTMLElement>, _focusTrapFactory: FocusTrapFactory, _document: any);
     ngAfterContentInit(): void;
@@ -85,7 +88,8 @@ export interface FocusOptions {
 export declare type FocusOrigin = 'touch' | 'mouse' | 'keyboard' | 'program' | null;
 
 export declare class FocusTrap {
-    enabled: boolean;
+    get enabled(): boolean;
+    set enabled(value: boolean);
     protected endAnchorListener: () => boolean;
     protected startAnchorListener: () => boolean;
     constructor(_element: HTMLElement, _checker: InteractivityChecker, _ngZone: NgZone, _document: Document, deferAnchors?: boolean);
@@ -139,8 +143,8 @@ export declare class InteractivityChecker {
 export declare function isFakeMousedownFromScreenReader(event: MouseEvent): boolean;
 
 export declare class ListKeyManager<T extends ListKeyManagerOption> {
-    readonly activeItem: T | null;
-    readonly activeItemIndex: number | null;
+    get activeItem(): T | null;
+    get activeItemIndex(): number | null;
     change: Subject<number>;
     tabOut: Subject<void>;
     constructor(_items: QueryList<T> | T[]);

tools/public_api_guard/cdk/accordion.d.ts

@@ -2,7 +2,8 @@ export declare class CdkAccordion implements OnDestroy, OnChanges {
     readonly _openCloseAllActions: Subject<boolean>;
     readonly _stateChanges: Subject<SimpleChanges>;
     readonly id: string;
-    multi: boolean;
+    get multi(): boolean;
+    set multi(multi: boolean);
     closeAll(): void;
     ngOnChanges(changes: SimpleChanges): void;
     ngOnDestroy(): void;
@@ -17,8 +18,10 @@ export declare class CdkAccordionItem implements OnDestroy {
     accordion: CdkAccordion;
     closed: EventEmitter<void>;
     destroyed: EventEmitter<void>;
-    disabled: any;
-    expanded: any;
+    get disabled(): any;
+    set disabled(disabled: any);
+    get expanded(): any;
+    set expanded(expanded: any);
     expandedChange: EventEmitter<boolean>;
     readonly id: string;
     opened: EventEmitter<void>;

tools/public_api_guard/cdk/bidi.d.ts

@@ -6,8 +6,9 @@ export declare class BidiModule {
 export declare class Dir implements Directionality, AfterContentInit, OnDestroy {
     _rawDir: string;
     change: EventEmitter<Direction>;
-    dir: Direction;
-    readonly value: Direction;
+    get dir(): Direction;
+    set dir(value: Direction);
+    get value(): Direction;
     ngAfterContentInit(): void;
     ngOnDestroy(): void;
     static ɵdir: i0.ɵɵDirectiveDefWithMeta<Dir, "[dir]", ["dir"], { "dir": "dir"; }, { "change": "dirChange"; }, never>;

tools/public_api_guard/cdk/collections.d.ts

@@ -30,7 +30,7 @@ export interface SelectionChange<T> {
 
 export declare class SelectionModel<T> {
     changed: Subject<SelectionChange<T>>;
-    readonly selected: T[];
+    get selected(): T[];
     constructor(_multiple?: boolean, initiallySelectedValues?: T[], _emitChanges?: boolean);
     clear(): void;
     deselect(...values: T[]): void;

tools/public_api_guard/cdk/drag-drop.d.ts

@@ -12,7 +12,8 @@ export declare class CdkDrag<T = any> implements AfterViewInit, OnChanges, OnDes
     boundaryElement: string | ElementRef<HTMLElement> | HTMLElement;
     constrainPosition?: (point: Point, dragRef: DragRef) => Point;
     data: T;
-    disabled: boolean;
+    get disabled(): boolean;
+    set disabled(value: boolean);
     dragStartDelay: number | {
         touch: number;
         mouse: number;
@@ -86,7 +87,8 @@ export interface CdkDragExit<T = any, I = T> {
 export declare class CdkDragHandle implements OnDestroy {
     _parentDrag: {} | undefined;
     _stateChanges: Subject<CdkDragHandle>;
-    disabled: boolean;
+    get disabled(): boolean;
+    set disabled(value: boolean);
     element: ElementRef<HTMLElement>;
     constructor(element: ElementRef<HTMLElement>, parentDrag?: any);
     ngOnDestroy(): void;
@@ -149,7 +151,8 @@ export declare class CdkDropList<T = any> implements AfterContentInit, OnDestroy
     autoScrollDisabled: boolean;
     connectedTo: (CdkDropList | string)[] | CdkDropList | string;
     data: T;
-    disabled: boolean;
+    get disabled(): boolean;
+    set disabled(value: boolean);
     dropped: EventEmitter<CdkDragDrop<T, any>>;
     element: ElementRef<HTMLElement>;
     enterPredicate: (drag: CdkDrag, drop: CdkDropList) => boolean;
@@ -178,7 +181,8 @@ export declare class CdkDropList<T = any> implements AfterContentInit, OnDestroy
 
 export declare class CdkDropListGroup<T> implements OnDestroy {
     readonly _items: Set<T>;
-    disabled: boolean;
+    get disabled(): boolean;
+    set disabled(value: boolean);
     ngOnDestroy(): void;
     static ngAcceptInputType_disabled: BooleanInput;
     static ɵdir: i0.ɵɵDirectiveDefWithMeta<CdkDropListGroup<any>, "[cdkDropListGroup]", ["cdkDropListGroup"], { "disabled": "cdkDropListGroupDisabled"; }, {}, never>;
@@ -221,7 +225,8 @@ export declare class DragRef<T = any> {
     beforeStarted: Subject<void>;
     constrainPosition?: (point: Point, dragRef: DragRef) => Point;
     data: T;
-    disabled: boolean;
+    get disabled(): boolean;
+    set disabled(value: boolean);
     dragStartDelay: number | {
         touch: number;
         mouse: number;

tools/public_api_guard/cdk/observers.d.ts

@@ -1,6 +1,8 @@
 export declare class CdkObserveContent implements AfterContentInit, OnDestroy {
-    debounce: number;
-    disabled: any;
+    get debounce(): number;
+    set debounce(value: number);
+    get disabled(): any;
+    set disabled(value: any);
     event: EventEmitter<MutationRecord[]>;
     constructor(_contentObserver: ContentObserver, _elementRef: ElementRef<HTMLElement>, _ngZone: NgZone);
     ngAfterContentInit(): void;

tools/public_api_guard/cdk/overlay.d.ts

@@ -10,25 +10,32 @@ export declare class CdkConnectedOverlay implements OnDestroy, OnChanges {
     backdropClass: string;
     backdropClick: EventEmitter<MouseEvent>;
     detach: EventEmitter<void>;
-    readonly dir: Direction;
-    flexibleDimensions: boolean;
-    growAfterOpen: boolean;
-    hasBackdrop: any;
+    get dir(): Direction;
+    get flexibleDimensions(): boolean;
+    set flexibleDimensions(value: boolean);
+    get growAfterOpen(): boolean;
+    set growAfterOpen(value: boolean);
+    get hasBackdrop(): any;
+    set hasBackdrop(value: any);
     height: number | string;
-    lockPosition: any;
+    get lockPosition(): any;
+    set lockPosition(value: any);
     minHeight: number | string;
     minWidth: number | string;
-    offsetX: number;
-    offsetY: number;
+    get offsetX(): number;
+    set offsetX(offsetX: number);
+    get offsetY(): number;
+    set offsetY(offsetY: number);
     open: boolean;
     origin: CdkOverlayOrigin;
     overlayKeydown: EventEmitter<KeyboardEvent>;
-    readonly overlayRef: OverlayRef;
+    get overlayRef(): OverlayRef;
     panelClass: string | string[];
     positionChange: EventEmitter<ConnectedOverlayPositionChange>;
     positionStrategy: FlexibleConnectedPositionStrategy;
     positions: ConnectedPosition[];
-    push: boolean;
+    get push(): boolean;
+    set push(value: boolean);
     scrollStrategy: ScrollStrategy;
     transformOriginSelector: string;
     viewportMargin: number;
@@ -81,11 +88,11 @@ export interface ConnectedPosition {
 }
 
 export declare class ConnectedPositionStrategy implements PositionStrategy {
-    readonly _isRtl: boolean;
+    get _isRtl(): boolean;
     _positionStrategy: FlexibleConnectedPositionStrategy;
     _preferredPositions: ConnectionPositionPair[];
-    readonly onPositionChange: Observable<ConnectedOverlayPositionChange>;
-    readonly positions: ConnectionPositionPair[];
+    get onPositionChange(): Observable<ConnectedOverlayPositionChange>;
+    get positions(): ConnectionPositionPair[];
     constructor(originPos: OriginConnectionPosition, overlayPos: OverlayConnectionPosition, connectedTo: ElementRef<HTMLElement>, viewportRuler: ViewportRuler, document: Document, platform: Platform, overlayContainer: OverlayContainer);
     apply(): void;
     attach(overlayRef: OverlayReference): void;
@@ -119,7 +126,7 @@ export declare class ConnectionPositionPair {
 export declare class FlexibleConnectedPositionStrategy implements PositionStrategy {
     _preferredPositions: ConnectionPositionPair[];
     positionChanges: Observable<ConnectedOverlayPositionChange>;
-    readonly positions: ConnectionPositionPair[];
+    get positions(): ConnectionPositionPair[];
     constructor(connectedTo: FlexibleConnectedPositionStrategyOrigin, _viewportRuler: ViewportRuler, _document: Document, _platform: Platform, _overlayContainer: OverlayContainer);
     apply(): void;
     attach(overlayRef: OverlayReference): void;
@@ -255,9 +262,9 @@ export declare class OverlayPositionBuilder {
 export declare class OverlayRef implements PortalOutlet, OverlayReference {
     _keydownEventSubscriptions: number;
     _keydownEvents: Subject<KeyboardEvent>;
-    readonly backdropElement: HTMLElement | null;
-    readonly hostElement: HTMLElement;
-    readonly overlayElement: HTMLElement;
+    get backdropElement(): HTMLElement | null;
+    get hostElement(): HTMLElement;
+    get overlayElement(): HTMLElement;
     constructor(_portalOutlet: PortalOutlet, _host: HTMLElement, _pane: HTMLElement, _config: ImmutableObject<OverlayConfig>, _ngZone: NgZone, _keyboardDispatcher: OverlayKeyboardDispatcher, _document: Document, _location?: Location | undefined);
     addPanelClass(classes: string | string[]): void;
     attach<T>(portal: ComponentPortal<T>): ComponentRef<T>;

tools/public_api_guard/cdk/portal.d.ts

@@ -24,8 +24,9 @@ export declare class CdkPortal extends TemplatePortal {
 export declare class CdkPortalOutlet extends BasePortalOutlet implements OnInit, OnDestroy {
     attachDomPortal: (portal: DomPortal<HTMLElement>) => void;
     attached: EventEmitter<CdkPortalOutletAttachedRef>;
-    readonly attachedRef: CdkPortalOutletAttachedRef;
-    portal: Portal<any> | null;
+    get attachedRef(): CdkPortalOutletAttachedRef;
+    get portal(): Portal<any> | null;
+    set portal(portal: Portal<any> | null);
     constructor(_componentFactoryResolver: ComponentFactoryResolver, _viewContainerRef: ViewContainerRef,
     _document?: any);
     attachComponentPortal<T>(portal: ComponentPortal<T>): ComponentRef<T>;
@@ -71,7 +72,7 @@ export declare class DomPortalOutlet extends BasePortalOutlet {
 }
 
 export declare abstract class Portal<T> {
-    readonly isAttached: boolean;
+    get isAttached(): boolean;
     attach(host: PortalOutlet): T;
     detach(): void;
     setAttachedHost(host: PortalOutlet | null): void;
@@ -103,7 +104,7 @@ export interface PortalOutlet {
 
 export declare class TemplatePortal<C = any> extends Portal<EmbeddedViewRef<C>> {
     context: C | undefined;
-    readonly origin: ElementRef;
+    get origin(): ElementRef;
     templateRef: TemplateRef<C>;
     viewContainerRef: ViewContainerRef;
     constructor(template: TemplateRef<C>, viewContainerRef: ViewContainerRef, context?: C);

tools/public_api_guard/cdk/scrolling.d.ts

@@ -39,9 +39,12 @@ export declare class CdkFixedSizeVirtualScroll implements OnChanges {
     _maxBufferPx: number;
     _minBufferPx: number;
     _scrollStrategy: FixedSizeVirtualScrollStrategy;
-    itemSize: number;
-    maxBufferPx: number;
-    minBufferPx: number;
+    get itemSize(): number;
+    set itemSize(value: number);
+    get maxBufferPx(): number;
+    set maxBufferPx(value: number);
+    get minBufferPx(): number;
+    set minBufferPx(value: number);
     ngOnChanges(): void;
     static ngAcceptInputType_itemSize: NumberInput;
     static ngAcceptInputType_maxBufferPx: NumberInput;
@@ -68,10 +71,12 @@ export declare class CdkScrollable implements OnInit, OnDestroy {
 
 export declare class CdkVirtualForOf<T> implements CollectionViewer, DoCheck, OnDestroy {
     _cdkVirtualForOf: DataSource<T> | Observable<T[]> | NgIterable<T> | null | undefined;
-    cdkVirtualForOf: DataSource<T> | Observable<T[]> | NgIterable<T> | null | undefined;
-    cdkVirtualForTemplate: TemplateRef<CdkVirtualForOfContext<T>>;
+    get cdkVirtualForOf(): DataSource<T> | Observable<T[]> | NgIterable<T> | null | undefined;
+    set cdkVirtualForOf(value: DataSource<T> | Observable<T[]> | NgIterable<T> | null | undefined);
+    set cdkVirtualForTemplate(value: TemplateRef<CdkVirtualForOfContext<T>>);
     cdkVirtualForTemplateCacheSize: number;
-    cdkVirtualForTrackBy: TrackByFunction<T> | undefined;
+    get cdkVirtualForTrackBy(): TrackByFunction<T> | undefined;
+    set cdkVirtualForTrackBy(fn: TrackByFunction<T> | undefined);
     dataStream: Observable<T[] | ReadonlyArray<T>>;
     viewChange: Subject<ListRange>;
     constructor(
@@ -102,7 +107,8 @@ export declare class CdkVirtualScrollViewport extends CdkScrollable implements O
     _totalContentHeight: string;
     _totalContentWidth: string;
     elementRef: ElementRef<HTMLElement>;
-    orientation: 'horizontal' | 'vertical';
+    get orientation(): 'horizontal' | 'vertical';
+    set orientation(orientation: 'horizontal' | 'vertical');
     renderedRangeStream: Observable<ListRange>;
     scrolledIndexChange: Observable<number>;
     constructor(elementRef: ElementRef<HTMLElement>, _changeDetectorRef: ChangeDetectorRef, ngZone: NgZone, _scrollStrategy: VirtualScrollStrategy, dir: Directionality, scrollDispatcher: ScrollDispatcher,