Skip to content

Commit c6a1d15

Browse files
authored
feat(cdk/dialog): move experimental CDK dialog into stable (#24804)
Moves the `cdk-experimental/dialog` package into the CDK.
1 parent 25cf877 commit c6a1d15

23 files changed

+231
-16
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
/src/cdk/clipboard/** @andrewseguin @xkxx
7474
/src/cdk/coercion/** @andrewseguin
7575
/src/cdk/collections/** @crisbeto @andrewseguin
76+
/src/cdk/dialog/** @jelbourn @crisbeto
7677
/src/cdk/drag-drop/** @crisbeto
7778
/src/cdk/keycodes/** @andrewseguin
7879
/src/cdk/layout/** @andrewseguin
@@ -131,7 +132,6 @@
131132
/src/cdk-experimental/* @andrewseguin
132133
/src/cdk-experimental/column-resize/** @kseamon @andrewseguin
133134
/src/cdk-experimental/combobox/** @jelbourn
134-
/src/cdk-experimental/dialog/** @jelbourn @crisbeto
135135
/src/cdk-experimental/menu/** @jelbourn
136136
/src/cdk-experimental/popover-edit/** @kseamon @andrewseguin
137137
/src/cdk-experimental/scrolling/** @mmalerba

.ng-dev/commit-message.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export const commitMessage: CommitMessageConfig = {
1111
'multiple', // For when a commit applies to multiple components.
1212
'cdk-experimental/column-resize',
1313
'cdk-experimental/combobox',
14-
'cdk-experimental/dialog',
1514
'cdk-experimental/listbox',
1615
'cdk-experimental/menu',
1716
'cdk-experimental/popover-edit',
@@ -24,6 +23,7 @@ export const commitMessage: CommitMessageConfig = {
2423
'cdk/clipboard',
2524
'cdk/coercion',
2625
'cdk/collections',
26+
'cdk/dialog',
2727
'cdk/drag-drop',
2828
'cdk/keycodes',
2929
'cdk/layout',

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ If you would like to chat about the question in real-time, you can reach out via
3131

3232
## <a name="issue"></a> Found an Issue?
3333
If you find a bug in the source code or a mistake in the documentation, you can help us by
34-
[submitting an issue](#submit-issue) to our [GitHub Repository][github]. Including an issue
34+
[submitting an issue](#submit-issue) to our [GitHub Repository][github]. Including an issue
3535
reproduction (via CodePen, JsBin, Plunkr, etc.) is the absolute best way to help the team quickly
3636
diagnose the problem. Screenshots are also helpful.
3737

@@ -40,7 +40,7 @@ You can help the team even more and [submit a Pull Request](#submit-pr) with a f
4040
## <a name="feature"></a> Want a Feature?
4141
You can *request* a new feature by [submitting an issue](#submit-issue) to our [GitHub
4242
Repository][github]. If you would like to *implement* a new feature, please submit an issue with
43-
a proposal for your work first, to be sure that we can use it.
43+
a proposal for your work first, to be sure that we can use it.
4444
Please consider what kind of change it is:
4545

4646
* For a **Major Feature**, first open an issue and outline your proposal so that it can be
@@ -194,7 +194,7 @@ Fixes a bug in the Angular Material `button` component where buttons
194194
cannot be disabled through an binding. This is because the `disabled`
195195
input did not set the `.mat-button-disabled` class on the host element.
196196
197-
Fixes #1234
197+
Fixes #1234
198198
```
199199

200200
### Revert
@@ -221,7 +221,7 @@ The commit message should specify which package is affected by the change. For e
221221
222222
### Scope
223223
The scope specifies place of the commit change. For example
224-
`material/datepicker`, `cdk-experimental/dialog`, etc.
224+
`material/datepicker`, `cdk/dialog`, etc.
225225
See full list [here][commit-message-scopes].
226226
227227
### Subject

src/cdk-experimental/config.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
CDK_EXPERIMENTAL_ENTRYPOINTS = [
33
"column-resize",
44
"combobox",
5-
"dialog",
65
"menu",
76
"listbox",
87
"popover-edit",

src/cdk/config.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ CDK_ENTRYPOINTS = [
66
"clipboard",
77
"coercion",
88
"collections",
9+
"dialog",
910
"drag-drop",
1011
"keycodes",
1112
"layout",

src/cdk-experimental/dialog/BUILD.bazel renamed to src/cdk/dialog/BUILD.bazel

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
1+
load(
2+
"//tools:defaults.bzl",
3+
"markdown_to_html",
4+
"ng_module",
5+
"ng_test_library",
6+
"ng_web_test_suite",
7+
)
28

39
package(default_visibility = ["//visibility:public"])
410

@@ -45,3 +51,13 @@ ng_web_test_suite(
4551
name = "unit_tests",
4652
deps = [":unit_test_sources"],
4753
)
54+
55+
markdown_to_html(
56+
name = "overview",
57+
srcs = [":dialog.md"],
58+
)
59+
60+
filegroup(
61+
name = "source-files",
62+
srcs = glob(["**/*.ts"]),
63+
)

0 commit comments

Comments
 (0)