build: remove view engine workarounds for old APF output

Removes all View Engine workarounds that we previously needed to
generate the APF package output with View Engine.

Author: devversion

WORKSPACE

@@ -49,11 +49,10 @@ node_repositories(
 
 yarn_install(
     name = "npm",
-    # We add the postinstall patches file, and ngcc main fields update script here so
-    # that Yarn will rerun whenever one of these files has been modified.
+    # We add the postinstall patches file here so that Yarn will rerun whenever
+    # the file is modified.
     data = [
         "//:tools/postinstall/apply-patches.js",
-        "//:tools/postinstall/update-ngcc-main-fields.js",
     ],
     package_json = "//:package.json",
     quiet = False,

angular-tsconfig.json

@@ -14,7 +14,7 @@
     "npm": "Please use Yarn instead of NPM to install dependencies. See: https://yarnpkg.com/lang/en/docs/install/"
   },
   "scripts": {
-    "postinstall": "node tools/postinstall/apply-patches.js && ngcc --properties module main --create-ivy-entry-points && node tools/postinstall/update-ngcc-main-fields.js",
+    "postinstall": "node tools/postinstall/apply-patches.js",
     "build": "ts-node --project scripts/tsconfig.json ./scripts/build-packages-dist.ts",
     "build-and-check-release-output": "ts-node --project scripts/tsconfig.json scripts/build-and-check-release-output.ts",
     "build-docs-content": "node ./scripts/build-docs-content.js",

package.json

@@ -52,69 +52,13 @@ async function main() {
 }
 
 function applyPatches() {
-  // Workaround for https://github.com/angular/angular/issues/18810.
-  shelljs.exec('ngc -p angular-tsconfig.json');
-
-  // Workaround for: https://github.com/angular/angular/issues/32651. We just do not
-  // generate re-exports for secondary entry-points. Similar to what "ng-packagr" does.
-  searchAndReplace(
-      /(?!function\s+)createMetadataReexportFile\([^)]+\);/, '',
-      'node_modules/@angular/bazel/src/ng_package/packager.js');
-  searchAndReplace(
-      /(?!function\s+)createTypingsReexportFile\([^)]+\);/, '',
-      'node_modules/@angular/bazel/src/ng_package/packager.js');
-
   // Workaround for: https://github.com/angular/angular/pull/32650
   searchAndReplace(
-      'var indexFile;', `
-    var indexFile = files.find(f => f.endsWith('/public-api.ts'));
+      'let resolvedEntryPoint = null;', `
+    let resolvedEntryPoint = tsFiles.find(f => f.endsWith('/public-api.ts')) || null;
   `,
-      'node_modules/@angular/compiler-cli/src/metadata/bundle_index_host.js');
-  searchAndReplace(
-      'var resolvedEntryPoint = null;', `
-    var resolvedEntryPoint = tsFiles.find(f => f.endsWith('/public-api.ts')) || null;
-  `,
-      'node_modules/@angular/compiler-cli/src/ngtsc/entry_point/src/logic.js');
-
-  // Workaround for: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ?both. We only want to discard
-  // the metadata of files in the bazel managed node modules. That way we keep the default
-  // behavior of ngc-wrapped except for dependencies between sources of the library. This makes
-  // the "generateCodeForLibraries" flag more accurate in the Bazel environment where previous
-  // compilations should not be treated as external libraries. Read more about this in the document.
-  searchAndReplace(
-      /if \((this\.options\.generateCodeForLibraries === false)/, `
-    const fs = require('fs');
-    const hasFlatModuleBundle = fs.existsSync(filePath.replace('.d.ts', '.metadata.json'));
-    if ((filePath.includes('node_modules/') || !hasFlatModuleBundle) && $1`,
-      'node_modules/@angular/compiler-cli/src/transformers/compiler_host.js');
-  applyPatch(path.join(__dirname, './flat_module_factory_resolution.patch'));
-  // The three replacements below ensure that metadata files can be read by NGC and
-  // that metadata files are collected as Bazel action inputs.
-  searchAndReplace(
-      /(const NGC_ASSETS = \/[^(]+\()([^)]*)(\).*\/;)/, '$1$2|metadata.json$3',
-      'node_modules/@angular/bazel/src/ngc-wrapped/index.js');
-  searchAndReplace(
-      /^((\s*)results = depset\(dep.angular.summaries, transitive = \[results]\))$/m,
-      `$1#\n$2results = depset(dep.angular.metadata, transitive = [results])`,
-      'node_modules/@angular/bazel/src/ng_module.bzl');
-  searchAndReplace(
-      /^((\s*)results = depset\(target.angular\.summaries if _has_target_angular_summaries\(target\) else \[]\))$/m,
-      `$1#\n$2results = depset(target.angular.metadata if _has_target_angular_summaries(target) else [], transitive = [results])`,
-      'node_modules/@angular/bazel/src/ng_module.bzl');
-  // Ensure that "metadata" of transitive dependencies can be collected.
-  searchAndReplace(
-      /providers\["angular"]\["metadata"] = outs\.metadata/,
-      `$& + [m for dep in ctx.attr.deps if (hasattr(dep, "angular") and hasattr(dep.angular, "metadata")) for m in dep.angular.metadata]`,
-      'node_modules/@angular/bazel/src/ng_module.bzl');
-
-  // Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1208.
-  applyPatch(path.join(__dirname, './manifest_externs_hermeticity.patch'));
+      'node_modules/@angular/compiler-cli/bundles/index.js');
 
-  // Workaround for https://github.com/angular/angular/issues/33452:
-  searchAndReplace(
-      /angular_compiler_options = {/, `$&
-          "strictTemplates": True,`,
-      'node_modules/@angular/bazel/src/ng_module.bzl');
 
   // More info in https://github.com/angular/angular/pull/33786
   shelljs.rm('-rf', [