Skip to content

Commit dbf1f1b

Browse files
committed
refactor(cdk-experimental/popover-edit): fix strict property initialization errors
Updates the code to be compatible with strict property initialization.
1 parent 204788b commit dbf1f1b

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

src/cdk-experimental/popover-edit/edit-ref.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export class EditRef<FormValue> implements OnDestroy {
3131
readonly blurred: Observable<void> = this._blurredSubject;
3232

3333
/** The value to set the form back to on revert. */
34-
private _revertFormValue: FormValue;
34+
private _revertFormValue!: FormValue;
3535

3636
private _injector = inject(Injector);
3737

src/cdk-experimental/popover-edit/focus-dispatcher.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,9 @@ export class FocusDispatcher {
2828
protected readonly directionality = inject(Directionality);
2929

3030
/** Observes keydown events triggered from the table. */
31-
readonly keyObserver: PartialObserver<KeyboardEvent>;
32-
33-
constructor() {
34-
this.keyObserver = {next: event => this.handleKeyboardEvent(event)};
35-
}
31+
readonly keyObserver: PartialObserver<KeyboardEvent> = {
32+
next: event => this.handleKeyboardEvent(event),
33+
};
3634

3735
/**
3836
* Moves focus to earlier or later cells (in dom order) by offset cells relative to

src/cdk-experimental/popover-edit/popover-edit.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ cdkPopoverEditTabOut`, fakeAsync(() => {
687687

688688
@Directive()
689689
abstract class BaseTestComponent {
690-
@ViewChild('table') table: ElementRef;
690+
@ViewChild('table') table!: ElementRef;
691691

692692
preservedValues = new FormValueContainer<PeriodicElement, {'name': string}>();
693693
nameEditDisabled = false;
@@ -860,7 +860,7 @@ abstract class BaseTestComponent {
860860
imports: [CdkPopoverEditModule, FormsModule, CdkTableModule, BidiModule],
861861
})
862862
class VanillaTableOutOfCell extends BaseTestComponent {
863-
elements: ChemicalElement[];
863+
elements!: ChemicalElement[];
864864

865865
renderData() {
866866
this.elements = createElementData();
@@ -921,7 +921,7 @@ class VanillaTableOutOfCell extends BaseTestComponent {
921921
imports: [CdkPopoverEditModule, FormsModule, CdkTableModule, BidiModule],
922922
})
923923
class VanillaTableInCell extends BaseTestComponent {
924-
elements: ChemicalElement[];
924+
elements!: ChemicalElement[];
925925

926926
renderData() {
927927
this.elements = createElementData();
@@ -1007,7 +1007,7 @@ class ElementDataSource extends DataSource<PeriodicElement> {
10071007
})
10081008
class CdkFlexTableInCell extends BaseTestComponent {
10091009
displayedColumns = ['before', 'name', 'weight'];
1010-
dataSource: ElementDataSource;
1010+
dataSource!: ElementDataSource;
10111011

10121012
renderData() {
10131013
this.dataSource = new ElementDataSource();
@@ -1081,7 +1081,7 @@ class CdkFlexTableInCell extends BaseTestComponent {
10811081
})
10821082
class CdkTableInCell extends BaseTestComponent {
10831083
displayedColumns = ['before', 'name', 'weight'];
1084-
dataSource: ElementDataSource;
1084+
dataSource!: ElementDataSource;
10851085

10861086
renderData() {
10871087
this.dataSource = new ElementDataSource();
@@ -1162,7 +1162,7 @@ class CdkTableInCell extends BaseTestComponent {
11621162
})
11631163
class CdkTableWithSkipRows extends BaseTestComponent {
11641164
displayedColumns = ['before', 'name', 'weight'];
1165-
dataSource: ElementDataSource;
1165+
dataSource!: ElementDataSource;
11661166

11671167
renderData() {
11681168
this.dataSource = new ElementDataSource();

src/cdk-experimental/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"compilerOptions": {
55
"rootDir": "..",
66
"baseUrl": ".",
7+
"strictPropertyInitialization": true,
78
"paths": {
89
"@angular/cdk/*": ["../cdk/*"],
910
"@angular/cdk-experimental/*": ["../cdk-experimental/*"]

0 commit comments

Comments
 (0)