refactor: shorter error constructors (#5135)

Author: crisbeto

src/lib/autocomplete/autocomplete-trigger.ts

@@ -62,7 +62,7 @@ export const MD_AUTOCOMPLETE_VALUE_ACCESSOR: any = {
  * Creates an error to be thrown when attempting to use an autocomplete trigger without a panel.
  */
 export function getMdAutocompleteMissingPanelError(): Error {
-  return new Error('Attempting to open an undefined instance of `md-autocomplete`. ' +
+  return Error('Attempting to open an undefined instance of `md-autocomplete`. ' +
                    'Make sure that the id passed to the `mdAutocomplete` is correct and that ' +
                    'you\'re attempting to open it after the ngAfterContentInit hook.');
 }

src/lib/core/compatibility/compatibility.ts

@@ -16,7 +16,7 @@ export const MATERIAL_COMPATIBILITY_MODE = new InjectionToken<boolean>('md-compa
  * @docs-private
  */
 export function getMdCompatibilityInvalidPrefixError(prefix: string, nodeName: string) {
-  return new Error(`The "${prefix}-" prefix cannot be used in ng-material v1 compatibility mode. ` +
+  return Error(`The "${prefix}-" prefix cannot be used in ng-material v1 compatibility mode. ` +
                    `It was used on an "${nodeName.toLowerCase()}" element.`);
 }
 

src/lib/core/portal/portal-errors.ts

@@ -11,31 +11,31 @@
  * @docs-private
  */
 export function throwNullPortalError() {
-  throw new Error('Must provide a portal to attach');
+  throw Error('Must provide a portal to attach');
 }
 
 /**
  * Throws an exception when attempting to attach a portal to a host that is already attached.
  * @docs-private
  */
 export function throwPortalAlreadyAttachedError() {
-  throw new Error('Host already has a portal attached');
+  throw Error('Host already has a portal attached');
 }
 
 /**
  * Throws an exception when attempting to attach a portal to an already-disposed host.
  * @docs-private
  */
 export function throwPortalHostAlreadyDisposedError() {
-  throw new Error('This PortalHost has already been disposed');
+  throw Error('This PortalHost has already been disposed');
 }
 
 /**
  * Throws an exception when attempting to attach an unknown portal type.
  * @docs-private
  */
 export function throwUnknownPortalTypeError() {
-  throw new Error('Attempting to attach an unknown Portal type. BasePortalHost accepts either' +
+  throw Error('Attempting to attach an unknown Portal type. BasePortalHost accepts either' +
                   'a ComponentPortal or a TemplatePortal.');
 }
 
@@ -44,13 +44,13 @@ export function throwUnknownPortalTypeError() {
  * @docs-private
  */
 export function throwNullPortalHostError() {
-  throw new Error('Attempting to attach a portal to a null PortalHost');
+  throw Error('Attempting to attach a portal to a null PortalHost');
 }
 
 /**
  * Throws an exception when attempting to detach a portal that is not attached.
  * @docs-privatew
  */
 export function throwNoPortalAttachedError() {
-  throw new Error('Attempting to detach a portal that is not attached to a host');
+  throw Error('Attempting to detach a portal that is not attached to a host');
 }

src/lib/datepicker/datepicker-errors.ts

@@ -8,7 +8,7 @@
 
 /** @docs-private */
 export function createMissingDateImplError(provider: string) {
-  return new Error(
+  return Error(
       `MdDatepicker: No provider found for ${provider}. You must import one of the following` +
       `modules at your application root: MdNativeDateModule, or provide a custom implementation.`);
 }

src/lib/datepicker/datepicker.ts

@@ -198,7 +198,7 @@ export class MdDatepicker<D> implements OnDestroy {
    */
   _registerInput(input: MdDatepickerInput<D>): void {
     if (this._datepickerInput) {
-      throw new Error('An MdDatepicker can only be associated with a single input.');
+      throw Error('An MdDatepicker can only be associated with a single input.');
     }
     this._datepickerInput = input;
     this._inputSubscription =
@@ -211,7 +211,7 @@ export class MdDatepicker<D> implements OnDestroy {
       return;
     }
     if (!this._datepickerInput) {
-      throw new Error('Attempted to open an MdDatepicker with no associated input.');
+      throw Error('Attempted to open an MdDatepicker with no associated input.');
     }
 
     this.touchUi ? this._openAsDialog() : this._openAsPopup();

src/lib/dialog/dialog-container.ts

@@ -37,7 +37,7 @@ import {FocusTrapFactory, FocusTrap} from '../core/a11y/focus-trap';
  * @docs-private
  */
 export function throwMdDialogContentAlreadyAttachedError() {
-  throw new Error('Attempting to attach dialog content after content is already attached');
+  throw Error('Attempting to attach dialog content after content is already attached');
 }
 
 /**

src/lib/grid-list/grid-list.ts

@@ -104,7 +104,7 @@ export class MdGridList implements OnInit, AfterContentChecked {
   /** Throw a friendly error if cols property is missing */
   private _checkCols() {
     if (!this.cols) {
-      throw new Error(`md-grid-list: must pass in number of columns. ` +
+      throw Error(`md-grid-list: must pass in number of columns. ` +
                       `Example: <md-grid-list cols="3">`);
     }
   }

src/lib/grid-list/tile-coordinator.ts

@@ -76,7 +76,7 @@ export class TileCoordinator {
   /** Finds the next available space large enough to fit the tile. */
   private _findMatchingGap(tileCols: number): number {
     if (tileCols > this.tracker.length) {
-      throw new Error(`md-grid-list: tile with colspan ${tileCols} is wider than ` +
+      throw Error(`md-grid-list: tile with colspan ${tileCols} is wider than ` +
                       `grid with cols="${this.tracker.length}".`);
     }
 

src/lib/grid-list/tile-styler.ts

@@ -207,7 +207,7 @@ export class RatioTileStyler extends TileStyler {
     let ratioParts = value.split(':');
 
     if (ratioParts.length !== 2) {
-      throw new Error(`md-grid-list: invalid ratio given for row-height: "${value}"`);
+      throw Error(`md-grid-list: invalid ratio given for row-height: "${value}"`);
     }
 
     this.rowHeightRatio = parseFloat(ratioParts[0]) / parseFloat(ratioParts[1]);

src/lib/icon/icon-registry.ts

@@ -27,7 +27,7 @@ import 'rxjs/add/observable/throw';
  * @docs-private
  */
 export function getMdIconNameNotFoundError(iconName: string): Error {
-  return new Error(`Unable to find icon with the name "${iconName}"`);
+  return Error(`Unable to find icon with the name "${iconName}"`);
 }
 
 
@@ -37,7 +37,7 @@ export function getMdIconNameNotFoundError(iconName: string): Error {
  * @docs-private
  */
 export function getMdIconNoHttpProviderError(): Error {
-  return new Error('Could not find Http provider for use with Angular Material icons. ' +
+  return Error('Could not find Http provider for use with Angular Material icons. ' +
                    'Please include the HttpModule from @angular/http in your app imports.');
 }
 
@@ -375,7 +375,7 @@ export class MdIconRegistry {
     div.innerHTML = str;
     const svg = div.querySelector('svg') as SVGElement;
     if (!svg) {
-      throw new Error('<svg> tag not found');
+      throw Error('<svg> tag not found');
     }
     return svg;
   }