build: migrate all nodejs_binary targets to rules_js

Migrate all `nodejs_binary` targets to `rules_js`.

Author: devversion

package.json

@@ -189,6 +189,11 @@
       "@angular/[email protected]": "patches/@angular__compiler-cli.patch"
     },
     "packageExtensions": {
+      "dgeni-packages": {
+        "dependencies": {
+          "clonedeep": "*"
+        }
+      },
       "@angular/animations": {
         "dependencies": {
           "@nginfra/angular-linking": "1.0.2"

pnpm-lock.yaml

@@ -79,6 +79,8 @@ genrule(
       echo "$(execpaths //src/components-examples:example-source-files)" \
           > $(execpath _example_module.MF)
 
+      export JS_BINARY__NO_CD_BINDIR="1"
+
       # Run the bazel entry-point for generating the example module.
       ./$(execpath //tools/example-module:bazel-bin) \
           "$(execpath _example_module.MF)" \

src/components-examples/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary", "npm_package_bin")
+load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_run_binary")
 load("//src/cdk:config.bzl", "CDK_TARGETS")
 load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_TARGETS")
 load("//src/components-examples:config.bzl", "ALL_EXAMPLES")
@@ -78,19 +78,14 @@ sass_binary(
     ],
 )
 
-nodejs_binary(
+js_binary(
     name = "prerender",
     data = [
         "index-source.html",
         ":prerender_bundle",
         ":styles_scss",
     ],
     entry_point = ":prerender_bundle.js",
-    templated_args = [
-        # TODO(josephperrott): update dependency usages to no longer need bazel patch module resolver
-        # See: https://github.com/bazelbuild/rules_nodejs/wiki#--bazel_patch_module_resolver-now-defaults-to-false-2324
-        "--bazel_patch_module_resolver",
-    ],
 )
 
 devmode_esbuild(
@@ -117,19 +112,19 @@ devmode_esbuild(
     ],
 )
 
-npm_package_bin(
+js_run_binary(
     name = "prerender_test_bin",
     outs = ["index-prerendered.html"],
-    args = ["$@"],
+    args = ["../../../$@"],
     tool = ":prerender",
 )
 
-npm_package_bin(
+js_run_binary(
     name = "debug_prerender_bin",
     # Note: the file needs to be called `index.html` specifically so the server can pick it up.
     outs = ["index.html"],
     args = [
-        "$@",
+        "../../../$@",
         "--debug",  # Disables some testing behavior that can be annoying while debugging.
     ],
     tool = ":prerender",

src/universal-app/BUILD.bazel

@@ -1,19 +1,14 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+load("@aspect_rules_js//js:defs.bzl", "js_binary")
 load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-nodejs_binary(
+js_binary(
     name = "dgeni",
     data = [
-        ":sources_legacy",
-        "@npm//dgeni",
-        "@npm//dgeni-packages",
+        ":sources",
     ],
-    entry_point = ":bazel-bin.ts",
-    # TODO(josephperrott): update dependency usages to no longer need bazel patch module resolver
-    # See: https://github.com/bazelbuild/rules_nodejs/wiki#--bazel_patch_module_resolver-now-defaults-to-false-2324
-    templated_args = ["--bazel_patch_module_resolver"],
+    entry_point = ":bazel-bin.js",
 )
 
 ts_project(

tools/dgeni/BUILD.bazel

@@ -35,26 +35,30 @@ def _dgeni_api_docs(ctx):
         args.add_joined(entry_points, join_with = ",")
 
         for entry_point in entry_points:
-            expected_outputs += [
+            expected_outputs.append(
                 # Declare the output for the current entry-point. The output file will always follow the
                 # same format: "{output_folder}/{package_name}-{entry_point_name}.html"
                 # (e.g. "api-docs/material-slider-testing.html")
                 ctx.actions.declare_file("%s-%s.html" %
                                          (package_name, entry_point.replace("/", "-"))),
-            ]
+            )
 
         # Small workaround that ensures that the "ripple" API doc is properly exposed as an output
         # of the packaging rule. Technically Dgeni should not output the "ripple" directory as
         # its own entry-point. TODO(devversion): Support sub API docs for entry-points
         if package_name == "material":
-            expected_outputs += [ctx.actions.declare_file("%s-%s.html" % (package_name, "ripple"))]
+            expected_outputs.append(ctx.actions.declare_file("%s-%s.html" % (package_name, "ripple")))
 
     # Run the Dgeni bazel executable which builds the documentation output based on the
     # configured rule attributes.
     ctx.actions.run(
         # Note that we want to add the dgeni template files as well. This makes sure that the
         # templates are available in the sandbox execution and can be read by Dgeni.
         inputs = input_files + ctx.files._dgeni_templates,
+        env = {
+            # Not needed as we operate with source files outside bazel-bin.
+            "JS_BINARY__NO_CD_BINDIR": "1",
+        },
         executable = ctx.executable._dgeni_bin,
         outputs = expected_outputs,
         arguments = [args],
@@ -83,7 +87,7 @@ dgeni_api_docs = rule(
         "_dgeni_bin": attr.label(
             default = Label("//tools/dgeni"),
             executable = True,
-            cfg = "host",
+            cfg = "exec",
         ),
 
         # Dgeni document templates that should be be available as inputs to the

tools/dgeni/index.bzl

@@ -1,4 +1,4 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+load("@aspect_rules_js//js:defs.bzl", "js_binary")
 load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
@@ -12,15 +12,11 @@ ts_project(
     ],
 )
 
-nodejs_binary(
+js_binary(
     name = "bazel-bin",
     data = [
         ":example-module.template",
-        ":example-module-lib_legacy",
-        "@npm//typescript",
+        ":example-module-lib",
     ],
-    entry_point = ":bazel-bin.ts",
-    # TODO(josephperrott): update dependency usages to no longer need bazel patch module resolver
-    # See: https://github.com/bazelbuild/rules_nodejs/wiki#--bazel_patch_module_resolver-now-defaults-to-false-2324
-    templated_args = ["--bazel_patch_module_resolver"],
+    entry_point = ":bazel-bin.js",
 )

tools/example-module/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+load("@aspect_rules_js//js:defs.bzl", "js_binary")
 load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
@@ -13,13 +13,10 @@ ts_project(
     ],
 )
 
-nodejs_binary(
+js_binary(
     name = "extract-tokens",
     data = [
-        ":extract_tokens_lib_legacy",
-        "@npm//highlight.js",
-        "@npm//sass",
+        ":extract_tokens_lib",
     ],
-    entry_point = ":extract-tokens.ts",
-    templated_args = ["--bazel_patch_module_resolver"],
+    entry_point = ":extract-tokens.js",
 )

tools/extract-tokens/BUILD.bazel

@@ -25,6 +25,10 @@ def _extract_tokens(ctx):
     # can throw an error if the script didn't generate the required outputs.
     ctx.actions.run(
         inputs = input_files,
+        env = {
+            # Not needed as we operate with source files; not inside `bazel-bin`.
+            "JS_BINARY__NO_CD_BINDIR": "1",
+        },
         executable = ctx.executable._extract_tokens,
         outputs = expected_outputs,
         arguments = [args],

tools/extract-tokens/index.bzl

@@ -1,5 +1,5 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
 load("//tools:defaults2.bzl", "ts_project")
+load("@aspect_rules_js//js:defs.bzl", "js_binary")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -15,15 +15,10 @@ ts_project(
     ],
 )
 
-nodejs_binary(
+js_binary(
     name = "highlight-files",
     data = [
-        ":sources_legacy",
-    ],
-    entry_point = ":highlight-files.ts",
-    templated_args = [
-        # TODO(josephperrott): update dependency usages to no longer need bazel patch module resolver
-        # See: https://github.com/bazelbuild/rules_nodejs/wiki#--bazel_patch_module_resolver-now-defaults-to-false-2324
-        "--bazel_patch_module_resolver",
+        ":sources",
     ],
+    entry_point = ":highlight-files.js",
 )