NullInjectorError errors after Angular 19 upgrade

[Lightw3ight]

Which @angular/* package(s) are the source of the bug?

core and cdk

Is this a regression?

Yes

Description

After upgrading to Angular 19, many of our "Modal" componants throw NullInjectorError errors.
We use ComponentPortals to dynamically create a component and display it as a modal/dialog we also pass in the injector of the "host" component to ensure the modal component has DI access to all the same services as the host.
However this issue is also reproduceable using the Dialog service from the cdk as illustrated in the attached github project.

Our project is very large and we have been slowly transitioning to standalone components, but this is a long process and the majority of the code still uses modules.

Please provide a link to a minimal reproduction of the bug

https://github.com/Lightw3ight/ng-19-di-bug

Please provide the exception or error you saw

module-based-thing.component.html:1 ERROR NullInjectorError: R3InjectorError(Environment Injector)[_MyTestService -> _MyTestService]: 
  NullInjectorError: No provider for _MyTestService!
    at <instance_members_initializer> (dynamic-thing.component.ts:10:29)

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 19.1.8
Node: 22.14.0
Package Manager: npm 10.9.2
OS: win32 x64

Angular: 19.1.7
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1901.8
@angular-devkit/build-angular   19.1.8
@angular-devkit/core            19.1.8
@angular-devkit/schematics      19.1.8
@angular/cdk                    19.1.5
@angular/cli                    19.1.8
@schematics/angular             19.1.8
rxjs                            7.8.2
typescript                      5.7.3
zone.js                         0.15.0

Anything else?

No response

[JeanMeche]

You need to give the dialog an EnvironmentInjector as the provider is registered on the module.

export class ModuleBasedThingComponent implements OnInit {
    private myTestService = inject(MyTestService);
    private injector = inject(EnvironmentInjector);
    private dialog = inject(Dialog);


    public ngOnInit() {
        this.myTestService.sayHello('ModuleBasedThingComponent');
    }

    public handleClick() {
        this.dialog.open(DynamicThingComponent, { injector: this.injector, });
    }
}

[JoostK]

I'm reopening this, because I'd also expect this to work. The node injector is expected to be a true child injector of its ancestor hierarchy and hence I'd expect it to be able to reach into its host component's standalone injector.

[JoostK]

@Lightw3ight you mention this is a regression that comes to light during an update. In which version did this work and could you narrow down the exact version in which it broke?

[Lightw3ight]

Using Injector (Not EnvironmentInjector) has worked right up until we upgraded from 18.1.2 to 19 (specifically 19.1.2)
I have tried EnvironmentInjector and it does work, but but I used to be able to just use Injector and it would work too

[JeanMeche]

I could reproduce the error in 18.1/18.2 and 19.0. Doesn't look like a regression. There might be something else at work here.

[Lightw3ight]

We use ComponentPortal and Overlay in our products, I only used Dialog as it was less code
I will make a demo closer to what we actually use and post a link

[Lightw3ight]

I rolled back our app to the Angular 18.1 version and everything is working fine, but I cannot for the life of me create a reproduction of the working code in a demo app, I just consistently get NullInjectorError errors.
So I guess I will go through all my references of Injector and change them to EnvironmentInjector

I'm a little confused what the difference is between EnvironmentInjector and Injector are you able to point me at any articles to help educate me?

[Azbesciak]

I have exactly the same issue.
I even have some injector which contains the dependency, later I extend that with Injector.create (and it still contain the dependency, validated with Injector.get), and I pass that one to new ComponentPortal(...).

And surprisingly, I get NullInjectorError. It worked before, since angular 14 when it came.
Guys, why most of the issues between upgrades are related to injectors... and these issues are the worst, as it bumps up in runtime, quite often contextualy.

I am updating from 18.1 to 19.1

[Azbesciak]

is there any hope it will be fixed soon? @mmalerba
That blocks the migration

[JeanMeche]

We're still looking for a narrowed down repro that breaks on 19 but works on v18 and lower.

[JochenKtz]

We currently have the same issue that v19 behaves differently and switching to EnvironmentInjector does not fix it (in the real project).

Example project where you just need to install and run:
https://github.com/JochenKtz/angular-60126/blob/main/v18/src/main.ts
https://github.com/JochenKtz/angular-60126/blob/main/v19/src/main.ts

v19 has the NullInjectionError

Initially I've tried to reproduce it with all standalone components, but that seems to behave differently compared to NgModules.

[JoostK]

Are all of these affected situations using CDK portals/dialogs/etc? Because I get the impression there may have been a change in the CDK that affects this behavior.