fix(mat/paginator): fix focus issues with paginator buttons #29379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBowen33
force-pushed
the
paginator-focus-fix-v2-07012024
branch
from
42e7c94 to
fcd35b3
Compare
DBowen33
requested review from
andrewseguin and
crisbeto
and removed request for
a team
crisbeto
reviewed
Jul 4, 2024
crisbeto
reviewed
Jul 8, 2024
crisbeto
approved these changes
Jul 8, 2024
crisbeto
reviewed
Jul 11, 2024
fixed to where if paginator button gets disabled while focused, focus will go to next appropriat button fixes b/286098030
removed console logs fixes b/286098030
update api fixes b/286098030
fix comment fixes #286098030
…tor buttons added disabledInteractive to prevent focus from going to body whenever button becomes disabled fixes b/286098030
fix broken tests fixes b/286098030
fixed more broken tests fixes b/286098030
changed paginator harness test to look for aria-disabled instead of disabled fixes b/286098030
fix unit tests fixes b/286098030
DBowen33
force-pushed
the
paginator-focus-fix-v2-07012024
branch
from
0a57f02 to
b8fd8e8
Compare
andrewseguin
added
the
dev-app preview
|
Deployed dev-app for a87f453 to: https://ng-dev-previews-comp--pr-angular-components-29379-dev-i4go42gm.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
merge fixes b/286098030
fix style issue fixes b/286098030
DBowen33
force-pushed
the
paginator-focus-fix-v2-07012024
branch
from
6c75730 to
3768788
Compare
crisbeto
approved these changes
Oct 3, 2024
remove class fixes b/286098030
andrewseguin
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a rework of #29006, added
disabledInteractivethis time around so that when the paginator buttons becomes disabled, focus will not be lostfixes b/286098030