build: some tokens not being extracted #30084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the token extraction script wasn't exposing some tokens, because it failed to determine their type. The two main root causes I saw were that some tokens aren't defined in M3 and some tokens were hardcoded. I've also added a hard error in case we can't resolve the type of a token. Fixes angular#30082.
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Nov 26, 2024
crisbeto
added a commit
that referenced
this pull request
Nov 26, 2024
Fixes that the token extraction script wasn't exposing some tokens, because it failed to determine their type. The two main root causes I saw were that some tokens aren't defined in M3 and some tokens were hardcoded. I've also added a hard error in case we can't resolve the type of a token. Fixes #30082. (cherry picked from commit 18229a3)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the token extraction script wasn't exposing some tokens, because it failed to determine their type. The two main root causes I saw were that some tokens aren't defined in M3 and some tokens were hardcoded. I've also added a hard error in case we can't resolve the type of a token.
Fixes #30082.