fix(cdk/drag-drop): resolve projected handles #30175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to tracking the registered directive nodes in the registry instead of a private static field. This allows us to reuse the logic in the handles.
Currently the `cdkDragHandle` directive registers itself with the parent by resolving it through DI. This doesn't work if the directive is declared in a separate embedded view (e.g. `ng-template`) that is then projected into the draggable element. It can be problematic when adding dragging support to a `mat-table`. These changes fix the issue by falling back to resolving the draggable directive through the DOM. Fixes angular#29475.
crisbeto
added
target: patch
crisbeto
requested review from
andrewseguin and
mmalerba
and removed request for
a team
|
Thank you very much to the technical experts for solving the problem |
andrewseguin
approved these changes
Dec 12, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
cdkDragHandledirective registers itself with the parent by resolving it through DI. This doesn't work if the directive is declared in a separate embedded view (e.g.ng-template) that is then projected into the draggable element. It can be problematic when adding dragging support to amat-table.These changes fix the issue by falling back to resolving the draggable directive through the DOM.
Fixes #29475.