Add a null check to autocomplete options #30734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
requested review from
crisbeto and
mmalerba
and removed request for
a team
crisbeto
reviewed
Mar 27, 2025
mmalerba
approved these changes
Mar 27, 2025
mmalerba
added
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Apr 2, 2025
* fix a bug with null options * Add a test (cherry picked from commit febc0eb)
mistrykaran91
pushed a commit
to mistrykaran91/components
that referenced
this pull request
Apr 7, 2025
* fix a bug with null options * Add a test
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a mat-autocomplete element does not contain any mat-options it will throw a null pointer when it is unloaded. Adding a simple null check solves this.
Googlers see cl/741219851