Skip to content

refactor(cdk-experimental/ui-patterns): move active index operations … #30922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

refactor(cdk-experimental/ui-patterns): move active index operations … #30922

merged 2 commits into from
Apr 23, 2025

Conversation

wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Apr 22, 2025 •
edited
Loading

…into list-focus

  • Move focus-related things out of the ListNavigation behavior and into ListFocus. This includes activeIndex and isFocusable.
  • Make behaviors that depend on other behaviors extend the inputs of those other behaviors. This is intended to stop us from needing to prop-drill.

Example:

// Before
this.inputs.navigation.inputs.activeIndex()

// After
this.inputs.activeIndex()

@wagnermaciel wagnermaciel marked this pull request as ready for review April 22, 2025 17:03
@wagnermaciel wagnermaciel requested a review from a team as a code owner April 22, 2025 17:03
@wagnermaciel wagnermaciel requested review from adolgachev, andrewseguin, crisbeto and ok7sai and removed request for a team and adolgachev April 22, 2025 17:03
@wagnermaciel wagnermaciel requested a review from mmalerba April 22, 2025 18:13
@wagnermaciel wagnermaciel reopened this Apr 22, 2025
@wagnermaciel
Copy link
Contributor Author

I tried splitting out this change into separate PRs but it ended up being almost the same size:
#30926

The size of this change is primarily due to updating unit test boilerplate to work with the changes

ok7sai
ok7sai reviewed Apr 22, 2025
View reviewed changes
ok7sai
ok7sai reviewed Apr 22, 2025
View reviewed changes
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 22, 2025
@wagnermaciel wagnermaciel merged commit 9f5b154 into angular:main Apr 23, 2025
24 of 26 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ok7sai ok7sai ok7sai approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wagnermaciel @ok7sai