build: remove unused macros and defaults from old toolchain (#2943)

PR Close #2943

Author: josephperrott

bazel/integration/tests/package_mappings/fake_pkg_srcs/BUILD.bazel

@@ -1,13 +1,12 @@
+load("@aspect_rules_js//npm:defs.bzl", "npm_package")
 load("@rules_pkg//:pkg.bzl", "pkg_tar")
-load("//tools:defaults.bzl", "pkg_npm")
 
-pkg_npm(
+npm_package(
     name = "npm_package",
     srcs = [
         "index.mjs",
         "package.json",
     ],
-    validate = False,
 )
 
 pkg_tar(

ng-dev/utils/BUILD.bazel

@@ -36,7 +36,6 @@ ts_project(
         "//github-actions/google-internal-tests:__subpackages__",
         "//github-actions/slash-commands/lib:__subpackages__",
         "//ng-dev:__subpackages__",
-        "//tools/jasmine:__pkg__",
     ],
     deps = [
         ":config_cache_rjs",
@@ -73,7 +72,4 @@ ts_project(
 ts_project(
     name = "config_cache",
     srcs = ["config-cache.ts"],
-    visibility = [
-        "//tools/jasmine:__pkg__",
-    ],
 )

ng-dev/utils/testing/BUILD.bazel

@@ -31,7 +31,6 @@ ts_project(
     ],
     visibility = [
         "//ng-dev/utils/testing:__subpackages__",
-        "//tools/jasmine:__subpackages__",
     ],
     deps = [
         "//ng-dev:node_modules/@types/node",

package.bzl

@@ -26,19 +26,3 @@ NPM_PACKAGE_SUBSTITUTIONS = select({
     "//tools:stamp": dict(basePackageSubstitutions, **stampSubstitutions),
     "//conditions:default": dict(basePackageSubstitutions, **noStampSubstitutions),
 })
-
-# These packages are allowed to use macros from `defaults.bzl`. This is a
-# little safety improvement to avoid accidentally relying on the defaults
-# which are not available when the dev-infra tooling is consumed.
-BZL_DEFAULTS_ALLOW_PACKAGES = [
-    ".github/local-actions",
-    "",
-    "apps",
-    "bazel/api-golden",
-    "github-actions",
-    "ng-dev",
-    "tools",
-    "lint-rules/tslint",
-    "lint-rules/stylelint",
-    "docs",
-]