refactor(ng-dev/ts-circular-dependencies): reorder processing of warnings and golden existence check (#2611)

Move the warnings processing before the initial processing of golden file and approval to always include its output.  Additionally,
provide alternate text output for approval attempts when no golden exists.

PR Close #2611

Author: josephperrott

ng-dev/ts-circular-dependencies/index.ts

@@ -88,18 +88,6 @@ export function main(
 
   Log.info(green(`   Current number of cycles: ${yellow(cycles.length.toString())}`));
 
-  if (goldenFile && approve) {
-    writeFileSync(goldenFile, JSON.stringify(actual, null, 2));
-    Log.info(green('✔  Updated golden file.'));
-    return 0;
-  } else if (!goldenFile) {
-    Log.error(`x  Circular dependency goldens are not allowed.`);
-    return 1;
-  } else if (!existsSync(goldenFile)) {
-    Log.error(`x  Could not find golden file: ${goldenFile}`);
-    return 1;
-  }
-
   const warningsCount = analyzer.unresolvedFiles.size + analyzer.unresolvedModules.size;
 
   // By default, warnings for unresolved files or modules are not printed. This is because
@@ -119,6 +107,33 @@ export function main(
     Log.warn(`   Please rerun with "--warnings" to inspect unresolved imports.`);
   }
 
+  if (goldenFile === undefined) {
+    if (approve) {
+      Log.error(
+        `x  Cannot approve circular depdencies within this repository as no golden file exists.`,
+      );
+      return 1;
+    }
+    if (cycles.length > 0) {
+      Log.error(`x  No circular dependencies are allow within this repository.`);
+      return 1;
+    }
+
+    Log.info(green('✔  No circular dependencies found in this repository.'));
+    return 0;
+  }
+
+  if (approve) {
+    writeFileSync(goldenFile, JSON.stringify(actual, null, 2));
+    Log.info(green('✔  Updated golden file.'));
+    return 0;
+  }
+
+  if (!existsSync(goldenFile)) {
+    Log.error(`x  Could not find golden file: ${goldenFile}`);
+    return 1;
+  }
+
   const expected = goldenFile ? (JSON.parse(readFileSync(goldenFile, 'utf8')) as Golden) : [];
   const {fixedCircularDeps, newCircularDeps} = compareGoldens(actual, expected);
   const isMatching = fixedCircularDeps.length === 0 && newCircularDeps.length === 0;