Skip to content

Commit 0f5e815

Browse files
committed
failing test
1 parent dc20101 commit 0f5e815

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

.github/workflows/pr.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,31 @@ jobs:
2929
- run: yarn install --immutable
3030
- name: Check code format
3131
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
32+
continue-on-error: true
3233
- name: Check commit message
3334
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
35+
continue-on-error: true
3436
- name: Check code lint
3537
run: yarn lint
38+
continue-on-error: true
3639
- name: Confirm code builds with typescript as expected
3740
run: yarn tsc -p tsconfig.json
41+
continue-on-error: true
3842
- name: Check Package Licenses
3943
# We use this action pinned at main because we need to have an actual version for the config to load.
4044
# Since using the local version would end up nearly using `main` anyway, this is essentially equivalent.
4145
uses: angular/dev-infra/github-actions/linting/licenses@main
4246
with:
4347
allow-dependencies-licenses: 'pkg:npm/renovate, pkg:npm/@renovatebot/detect-tools'
48+
continue-on-error: true
49+
- if: ${{ success() }}
50+
name: Conclude Passing
51+
run: exit 0;
52+
- if: ${{ failure() }}
53+
name: Conclude Failing
54+
run: exit 1;
55+
56+
4457

4558
test:
4659
timeout-minutes: 15

ng-dev/release/notes/changelog.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@ export const splitMarker = '<!-- CHANGELOG SPLIT MARKER -->';
2525
*
2626
* <changelog entry content>
2727
*/
28-
const joinMarker = `\n\n${splitMarker}\n\n`;
28+
const joinMarker = `\n\n${splitMarker}\n\n`;
2929

3030
/** A RegExp matcher to extract the version of a changelog entry from the entry content. */
3131
const versionAnchorMatcher = new RegExp(`<a name="(.*)"></a>`);
3232

3333
/** An individual changelog entry. */
3434
interface ChangelogEntry {
3535
content: string;
36-
version: semver.SemVer;
36+
version: semver.SemVer
3737
}
3838

3939
export class Changelog {

0 commit comments

Comments
 (0)