fix(github-actions): handle when no target label is provided for mergeability check (#2715)

Properly return an error meessage when no target label is present.

PR Close #2715

Author: josephperrott

.github/local-actions/branch-manager/lib/main.ts

@@ -11,6 +11,7 @@ import {
 } from '../../../../github-actions/utils.js';
 import {MergeConflictsFatalError} from '../../../../ng-dev/pr/merge/failures.js';
 import {createPullRequestValidationConfig} from '../../../../ng-dev/pr/common/validation/validation-config.js';
+import {InvalidTargetLabelError} from '../../../../ng-dev/pr/common/targeting/target-label.js';
 
 interface CommmitStatus {
   state: 'pending' | 'error' | 'failure' | 'success';
@@ -155,19 +156,22 @@ async function main() {
 
     await setMergeabilityStatusOnPullRequest(statusInfo);
   } catch (e: Error | unknown) {
+    let state: CommmitStatus['state'] = 'error';
     let description: string;
     const {runId, repo, serverUrl} = actionContext;
     const targetUrl = `${serverUrl}/${repo.owner}/${repo.repo}/actions/runs/${runId}`;
-    if (e instanceof Error) {
+
+    if (e instanceof InvalidTargetLabelError) {
+      // For this action, an invalid target label represents that we aren't ready to check the
+      // mergeability yet, rather than an actual failure.
+      state = 'pending';
+      description = e.failureMessage;
+    } else if (e instanceof Error) {
       description = e.message;
     } else {
       description = 'Internal Error, see link for action log';
     }
-    await setMergeabilityStatusOnPullRequest({
-      state: 'error',
-      description,
-      targetUrl,
-    });
+    await setMergeabilityStatusOnPullRequest({state, description, targetUrl});
     // Re-throw the error so that the action run is set as failing.
     throw e;
   }

.github/local-actions/branch-manager/main.js

@@ -69642,19 +69642,19 @@ async function main() {
     })();
     await setMergeabilityStatusOnPullRequest(statusInfo);
   } catch (e) {
+    let state = "error";
     let description;
     const { runId, repo: repo2, serverUrl } = import_github5.context;
     const targetUrl = `${serverUrl}/${repo2.owner}/${repo2.repo}/actions/runs/${runId}`;
-    if (e instanceof Error) {
+    if (e instanceof InvalidTargetLabelError) {
+      state = "pending";
+      description = e.failureMessage;
+    } else if (e instanceof Error) {
       description = e.message;
     } else {
       description = "Internal Error, see link for action log";
     }
-    await setMergeabilityStatusOnPullRequest({
-      state: "error",
-      description,
-      targetUrl
-    });
+    await setMergeabilityStatusOnPullRequest({ state, description, targetUrl });
     throw e;
   }
 }

github-actions/branch-manager/lib/main.ts

@@ -111,7 +111,7 @@ async function createWorkflowForPullRequest(inputs: WorkflowInputs) {
       repo: inputs.repo,
       owner: inputs.owner,
       state: 'pending',
-      description: 'Running mergibility check',
+      description: 'Mergibility check requested',
       sha: inputs.sha,
       context: 'mergeability',
     });

github-actions/branch-manager/main.js

@@ -48159,7 +48159,7 @@ async function createWorkflowForPullRequest(inputs) {
       repo: inputs.repo,
       owner: inputs.owner,
       state: "pending",
-      description: "Running mergibility check",
+      description: "Mergibility check requested",
       sha: inputs.sha,
       context: "mergeability"
     });