Skip to content

Commit 322163a

Browse files
committed
fix(ng-dev): remove formatting expectations around constant only globs (#2348)
Remove the formatting requirement for not including constant only globs. While they are technically less efficient, they are not worth flagging for us compared to the cost of the inefficiency. PR Close #2348
1 parent 9d5ffbf commit 322163a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/local-actions/changelog/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62167,7 +62167,7 @@ var Buildifier = class extends Formatter {
6216762167
};
6216862168
}
6216962169
};
62170-
var BAZEL_WARNING_FLAG = `--warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,constant-glob,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,git-repository,http-archive,integer-division,load,native-build,native-package,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,string-iteration,unused-variable`;
62170+
var BAZEL_WARNING_FLAG = `--warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,git-repository,http-archive,integer-division,load,native-build,native-package,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,string-iteration,unused-variable`;
6217162171

6217262172
//
6217362173
import { join as join3 } from "path";

ng-dev/format/formatters/buildifier.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class Buildifier extends Formatter {
4949
// The warning flag for buildifier copied from angular/angular's usage.
5050
const BAZEL_WARNING_FLAG =
5151
`--warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,` +
52-
`attr-single-file,constant-glob,ctx-args,depset-iteration,depset-union,dict-concatenation,` +
52+
`attr-single-file,ctx-args,depset-iteration,depset-union,dict-concatenation,` +
5353
`duplicated-name,filetype,git-repository,http-archive,integer-division,load,` +
5454
`native-build,native-package,output-group,package-name,package-on-top,positional-args,` +
5555
`redefined-variable,repository-name,string-iteration,unused-variable`;

0 commit comments

Comments
 (0)