Skip to content

Commit 41d3c8f

Browse files
josephperrottalan-agius4
authored andcommitted
fix(ng-dev): prevent fallthrough for switch cases in target label checks (#3062)
PR Close #3062
1 parent 30d78d3 commit 41d3c8f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/local-actions/branch-manager/main.js

Lines changed: 2 additions & 1 deletion
Large diffs are not rendered by default.

ng-dev/pr/common/validation/assert-allowed-target-label.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ class Validation extends PullRequestValidation {
7373
if (hasDeprecations && !releaseTrains.isFeatureFreeze()) {
7474
throw this._createHasDeprecationsError(targetLabel);
7575
}
76+
break;
7677
case targetLabels['TARGET_AUTOMATION']:
7778
if (!automationBots.includes(pullRequest.author.login)) {
7879
throw this._createUserUsingAutomationLabelError(targetLabel, pullRequest.author.login);

0 commit comments

Comments
 (0)