Skip to content

Commit 42608a2

Browse files
thePunderWomanthePunderWoman
committed
fix(ng-dev): fix commitCheck functions for managed labels
Some of the managed labels were incorrectly looking at type rather than scope for their commitCheck function, which resulted in always failing to match.
1 parent 5b4b2a6 commit 42608a2

File tree

6 files changed

+93
-18
lines changed

6 files changed

+93
-18
lines changed

‎.github/local-actions/branch-manager/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62440,19 +62440,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
6244062440
DETECTED_HTTP_CHANGE: {
6244162441
description: "Issues related to HTTP and HTTP Client",
6244262442
name: "area: common/http",
62443-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
62443+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
6244462444
repositories: [ManagedRepositories.ANGULAR]
6244562445
},
6244662446
DETECTED_COMPILER_CHANGE: {
6244762447
description: "Issues related to `ngc`, Angular's template compiler",
6244862448
name: "area: compiler",
62449-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
62449+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
6245062450
repositories: [ManagedRepositories.ANGULAR]
6245162451
},
6245262452
DETECTED_PLATFORM_BROWSER_CHANGE: {
6245362453
description: "Issues related to the framework runtime",
6245462454
name: "area: core",
62455-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
62455+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
62456+
repositories: [ManagedRepositories.ANGULAR]
62457+
},
62458+
DETECTED_PLATFORM_SERVER_CHANGE: {
62459+
description: "Issues related to server-side rendering",
62460+
name: "area: server",
62461+
commitCheck: (c) => c.scope === "platform-server",
62462+
repositories: [ManagedRepositories.ANGULAR]
62463+
},
62464+
DETECTED_ZONES_CHANGE: {
62465+
description: "Issues related to zone.js",
62466+
name: "area: zones",
62467+
commitCheck: (c) => c.scope === "zone.js",
6245662468
repositories: [ManagedRepositories.ANGULAR]
6245762469
}
6245862470
});

‎.github/local-actions/labels-sync/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45864,19 +45864,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4586445864
DETECTED_HTTP_CHANGE: {
4586545865
description: "Issues related to HTTP and HTTP Client",
4586645866
name: "area: common/http",
45867-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
45867+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4586845868
repositories: [ManagedRepositories.ANGULAR]
4586945869
},
4587045870
DETECTED_COMPILER_CHANGE: {
4587145871
description: "Issues related to `ngc`, Angular's template compiler",
4587245872
name: "area: compiler",
45873-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
45873+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4587445874
repositories: [ManagedRepositories.ANGULAR]
4587545875
},
4587645876
DETECTED_PLATFORM_BROWSER_CHANGE: {
4587745877
description: "Issues related to the framework runtime",
4587845878
name: "area: core",
45879-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
45879+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
45880+
repositories: [ManagedRepositories.ANGULAR]
45881+
},
45882+
DETECTED_PLATFORM_SERVER_CHANGE: {
45883+
description: "Issues related to server-side rendering",
45884+
name: "area: server",
45885+
commitCheck: (c) => c.scope === "platform-server",
45886+
repositories: [ManagedRepositories.ANGULAR]
45887+
},
45888+
DETECTED_ZONES_CHANGE: {
45889+
description: "Issues related to zone.js",
45890+
name: "area: zones",
45891+
commitCheck: (c) => c.scope === "zone.js",
4588045892
repositories: [ManagedRepositories.ANGULAR]
4588145893
}
4588245894
});

‎github-actions/branch-manager/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45864,19 +45864,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4586445864
DETECTED_HTTP_CHANGE: {
4586545865
description: "Issues related to HTTP and HTTP Client",
4586645866
name: "area: common/http",
45867-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
45867+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4586845868
repositories: [ManagedRepositories.ANGULAR]
4586945869
},
4587045870
DETECTED_COMPILER_CHANGE: {
4587145871
description: "Issues related to `ngc`, Angular's template compiler",
4587245872
name: "area: compiler",
45873-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
45873+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4587445874
repositories: [ManagedRepositories.ANGULAR]
4587545875
},
4587645876
DETECTED_PLATFORM_BROWSER_CHANGE: {
4587745877
description: "Issues related to the framework runtime",
4587845878
name: "area: core",
45879-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
45879+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
45880+
repositories: [ManagedRepositories.ANGULAR]
45881+
},
45882+
DETECTED_PLATFORM_SERVER_CHANGE: {
45883+
description: "Issues related to server-side rendering",
45884+
name: "area: server",
45885+
commitCheck: (c) => c.scope === "platform-server",
45886+
repositories: [ManagedRepositories.ANGULAR]
45887+
},
45888+
DETECTED_ZONES_CHANGE: {
45889+
description: "Issues related to zone.js",
45890+
name: "area: zones",
45891+
commitCheck: (c) => c.scope === "zone.js",
4588045892
repositories: [ManagedRepositories.ANGULAR]
4588145893
}
4588245894
});

‎github-actions/commit-message-based-labels/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46329,19 +46329,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4632946329
DETECTED_HTTP_CHANGE: {
4633046330
description: "Issues related to HTTP and HTTP Client",
4633146331
name: "area: common/http",
46332-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
46332+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4633346333
repositories: [ManagedRepositories.ANGULAR]
4633446334
},
4633546335
DETECTED_COMPILER_CHANGE: {
4633646336
description: "Issues related to `ngc`, Angular's template compiler",
4633746337
name: "area: compiler",
46338-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
46338+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4633946339
repositories: [ManagedRepositories.ANGULAR]
4634046340
},
4634146341
DETECTED_PLATFORM_BROWSER_CHANGE: {
4634246342
description: "Issues related to the framework runtime",
4634346343
name: "area: core",
46344-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
46344+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
46345+
repositories: [ManagedRepositories.ANGULAR]
46346+
},
46347+
DETECTED_PLATFORM_SERVER_CHANGE: {
46348+
description: "Issues related to server-side rendering",
46349+
name: "area: server",
46350+
commitCheck: (c) => c.scope === "platform-server",
46351+
repositories: [ManagedRepositories.ANGULAR]
46352+
},
46353+
DETECTED_ZONES_CHANGE: {
46354+
description: "Issues related to zone.js",
46355+
name: "area: zones",
46356+
commitCheck: (c) => c.scope === "zone.js",
4634546357
repositories: [ManagedRepositories.ANGULAR]
4634646358
}
4634746359
});

‎github-actions/unified-status-check/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47684,19 +47684,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4768447684
DETECTED_HTTP_CHANGE: {
4768547685
description: "Issues related to HTTP and HTTP Client",
4768647686
name: "area: common/http",
47687-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
47687+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4768847688
repositories: [ManagedRepositories.ANGULAR]
4768947689
},
4769047690
DETECTED_COMPILER_CHANGE: {
4769147691
description: "Issues related to `ngc`, Angular's template compiler",
4769247692
name: "area: compiler",
47693-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
47693+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4769447694
repositories: [ManagedRepositories.ANGULAR]
4769547695
},
4769647696
DETECTED_PLATFORM_BROWSER_CHANGE: {
4769747697
description: "Issues related to the framework runtime",
4769847698
name: "area: core",
47699-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
47699+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
47700+
repositories: [ManagedRepositories.ANGULAR]
47701+
},
47702+
DETECTED_PLATFORM_SERVER_CHANGE: {
47703+
description: "Issues related to server-side rendering",
47704+
name: "area: server",
47705+
commitCheck: (c) => c.scope === "platform-server",
47706+
repositories: [ManagedRepositories.ANGULAR]
47707+
},
47708+
DETECTED_ZONES_CHANGE: {
47709+
description: "Issues related to zone.js",
47710+
name: "area: zones",
47711+
commitCheck: (c) => c.scope === "zone.js",
4770047712
repositories: [ManagedRepositories.ANGULAR]
4770147713
}
4770247714
});

‎ng-dev/pr/common/labels/managed.ts‎

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,34 @@ export const managedLabels = createTypedObject(ManagedLabel)({
4747
DETECTED_HTTP_CHANGE: {
4848
description: 'Issues related to HTTP and HTTP Client',
4949
name: 'area: common/http',
50-
commitCheck: (c: Commit) => c.type === 'common/http' || c.type === 'http',
50+
commitCheck: (c: Commit) => c.scope === 'common/http' || c.scope === 'http',
5151
repositories: [ManagedRepositories.ANGULAR],
5252
},
5353
DETECTED_COMPILER_CHANGE: {
5454
description: "Issues related to `ngc`, Angular's template compiler",
5555
name: 'area: compiler',
56-
commitCheck: (c: Commit) => c.type === 'compiler' || c.type === 'compiler-cli',
56+
commitCheck: (c: Commit) => c.scope === 'compiler' || c.scope === 'compiler-cli',
5757
repositories: [ManagedRepositories.ANGULAR],
5858
},
5959
DETECTED_PLATFORM_BROWSER_CHANGE: {
6060
description: 'Issues related to the framework runtime',
6161
name: 'area: core',
62-
commitCheck: (c: Commit) => c.type === 'platform-browser' || c.type === 'core',
62+
commitCheck: (c: Commit) =>
63+
c.scope === 'platform-browser' ||
64+
c.scope === 'core' ||
65+
c.scope === 'platform-browser-dynamic',
66+
repositories: [ManagedRepositories.ANGULAR],
67+
},
68+
DETECTED_PLATFORM_SERVER_CHANGE: {
69+
description: 'Issues related to server-side rendering',
70+
name: 'area: server',
71+
commitCheck: (c: Commit) => c.scope === 'platform-server',
72+
repositories: [ManagedRepositories.ANGULAR],
73+
},
74+
DETECTED_ZONES_CHANGE: {
75+
description: 'Issues related to zone.js',
76+
name: 'area: zones',
77+
commitCheck: (c: Commit) => c.scope === 'zone.js',
6378
repositories: [ManagedRepositories.ANGULAR],
6479
},
6580
});

0 commit comments

Comments
 (0)