Skip to content

Commit 46a3dd8

Browse files
committed
failing test
1 parent dc20101 commit 46a3dd8

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

.github/workflows/pr.yml

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,30 @@ jobs:
2727
- uses: ./github-actions/bazel/setup
2828
- uses: ./github-actions/bazel/configure-remote
2929
- run: yarn install --immutable
30-
- name: Check code format
30+
- if: always()
31+
name: Check code format
3132
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
32-
- name: Check commit message
33+
- if: always()
34+
name: Check commit message
3335
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
34-
- name: Check code lint
36+
- if: always()
37+
name: Check code lint
3538
run: yarn lint
36-
- name: Confirm code builds with typescript as expected
39+
- if: always()
40+
name: Confirm code builds with typescript as expected
3741
run: yarn tsc -p tsconfig.json
38-
- name: Check Package Licenses
42+
- if: always()
43+
name: Check Package Licenses
3944
# We use this action pinned at main because we need to have an actual version for the config to load.
4045
# Since using the local version would end up nearly using `main` anyway, this is essentially equivalent.
4146
uses: angular/dev-infra/github-actions/linting/licenses@main
4247
with:
4348
allow-dependencies-licenses: 'pkg:npm/renovate, pkg:npm/@renovatebot/detect-tools'
49+
- name: The job has failed
50+
if: ${{ failure() }}
51+
run: exit 1
52+
53+
4454

4555
test:
4656
timeout-minutes: 15

ng-dev/release/notes/changelog.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@ export const splitMarker = '<!-- CHANGELOG SPLIT MARKER -->';
2525
*
2626
* <changelog entry content>
2727
*/
28-
const joinMarker = `\n\n${splitMarker}\n\n`;
28+
const joinMarker = `\n\n${splitMarker}\n\n`;
2929

3030
/** A RegExp matcher to extract the version of a changelog entry from the entry content. */
3131
const versionAnchorMatcher = new RegExp(`<a name="(.*)"></a>`);
3232

3333
/** An individual changelog entry. */
3434
interface ChangelogEntry {
3535
content: string;
36-
version: semver.SemVer;
36+
version: semver.SemVer
3737
}
3838

3939
export class Changelog {

0 commit comments

Comments
 (0)