fix(ng-dev): move disallowFixup to commit message config

This option needs to be configurable from the config

Author: alan-agius4

ng-dev/commit-message/config.ts

@@ -14,12 +14,13 @@ export interface CommitMessageConfig {
   minBodyLength: number;
   minBodyLengthTypeExcludes?: string[];
   scopes: string[];
+  disallowFixup?: boolean;
 }
 
 /** Assert the provided config contains a `CommitMessageConfig`. */
 export function assertValidCommitMessageConfig<T extends NgDevConfig>(
-  config: T & Partial<{commitMessage: CommitMessageConfig}>,
-): asserts config is T & {commitMessage: CommitMessageConfig} {
+  config: T & Partial<{commitMessage: CommitMessageConfig; disallowFixup?: boolean}>,
+): asserts config is T & {commitMessage: CommitMessageConfig; disallowFixup?: boolean} {
   if (config.commitMessage === undefined) {
     throw new ConfigValidationError(`No configuration defined for "commitMessage"`);
   }

ng-dev/commit-message/validate.spec.ts

@@ -269,24 +269,27 @@ describe('validate-commit-message.js', () => {
 
       describe('with `disallowFixup`', () => {
         it('when true should fail', async () => {
+          setConfig({...config, commitMessage: {...config.commitMessage, disallowFixup: true}});
+
           const msg = 'fixup! foo';
 
           expectValidationResult(
             await validateCommitMessage(msg, {
-              disallowFixup: true,
               nonFixupCommitHeaders: ['foo', 'bar', 'baz'],
             }),
             INVALID,
-            ['The commit must be manually fixed-up into the target commit as fixup commits are disallowed'],
+            [
+              'The commit must be manually fixed-up into the target commit as fixup commits are disallowed',
+            ],
           );
         });
 
         it('when false should pass', async () => {
+          setConfig({...config, commitMessage: {...config.commitMessage, disallowFixup: false}});
           const msg = 'fixup! foo';
 
           expectValidationResult(
             await validateCommitMessage(msg, {
-              disallowFixup: false,
               nonFixupCommitHeaders: ['foo', 'bar', 'baz'],
             }),
             VALID,

ng-dev/commit-message/validate.ts

@@ -15,7 +15,6 @@ import {Commit, parseCommitMessage} from './parse.js';
 /** Options for commit message validation. */
 export interface ValidateCommitMessageOptions {
   disallowSquash?: boolean;
-  disallowFixup?: boolean;
   nonFixupCommitHeaders?: string[];
 }
 
@@ -91,7 +90,7 @@ export async function validateCommitMessage(
     // stripping the `fixup! ` prefix), otherwise we assume this verification will happen in another
     // check.
     if (commit.isFixup) {
-      if (options.disallowFixup) {
+      if (config.disallowFixup) {
         errors.push(
           'The commit must be manually fixed-up into the target commit as fixup commits are disallowed',
         );