Skip to content

Commit 8d943d6

Browse files
committed
refactor: remove outdated TODOs
Remove TODOs which are already fixed but the comment was not removed.
1 parent b34c3cb commit 8d943d6

File tree

4 files changed

+2
-6
lines changed
  • .github/local-actions
  • github-actions

4 files changed

+2
-6
lines changed

.github/local-actions/labels-sync/lib/main.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ async function syncLabelsInRepo(github: Octokit, repoName: string, managedLabels
7070

7171
async function main() {
7272
/** The Github API instance to use for requests. */
73-
// TODO: remove once GHA supports node18 as a target runner for Javascript action
7473
const github = new Octokit({auth: await getAuthTokenFor(ANGULAR_ROBOT)});
7574

7675
try {

.github/local-actions/lock-closed/lib/main.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ async function main() {
3737
const token = await getAuthTokenFor(ANGULAR_LOCK_BOT, {org: 'angular'});
3838

3939
try {
40-
// TODO: remove once GHA supports node18 as a target runner for Javascript action
4140
const github = new Octokit({auth: token});
4241
for (let repo of reposToBeChecked) {
4342
await runLockClosedAction(github, repo);

github-actions/post-approval-changes/lib/main.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@ async function main() {
1515
const repoToken = await getAuthTokenFor(ANGULAR_ROBOT, context.repo);
1616
const googlersOrgToken = await getGooglersOrgInstallationToken();
1717

18-
// TODO: remove once GHA supports node18 as a target runner for Javascript action
19-
repoClient = new Octokit({auth: repoToken, request: {fetch}});
18+
repoClient = new Octokit({auth: repoToken});
2019

2120
if (googlersOrgToken !== null) {
22-
googlersOrgClient = new Octokit({auth: googlersOrgToken, request: {fetch}});
21+
googlersOrgClient = new Octokit({auth: googlersOrgToken});
2322
}
2423

2524
await runPostApprovalChangesAction(googlersOrgClient ?? repoClient, repoClient);

github-actions/pull-request-labeling/lib/main.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ class PullRequestLabeling {
1515
/** Run the commit message based labelling process. */
1616
static run = async () => {
1717
const token = await getAuthTokenFor(ANGULAR_ROBOT);
18-
// TODO: remove once GHA supports node18 as a target runner for Javascript action
1918
const git = new Octokit({auth: token});
2019
try {
2120
const inst = new this(git);

0 commit comments

Comments
 (0)