fix(ng-dev): only fail PR merge for target: automation if its a non-bot

josephperrott · josephperrott · commit 9729da36859f · 2025-09-12T22:11:12.000Z
We should only fail if a target: automation label is used for a non-bot user
diff --git a/ng-dev/pr/common/validation/assert-allowed-target-label.ts b/ng-dev/pr/common/validation/assert-allowed-target-label.ts
@@ -74,7 +74,7 @@ class Validation extends PullRequestValidation {
           throw this._createHasDeprecationsError(targetLabel);
         }
       case targetLabels['TARGET_AUTOMATION']:
-        if (!automationBots.includes(pullRequest.author.login)) {
+        if (automationBots.includes(pullRequest.author.login)) {
           throw this._createUserUsingAutomationLabelError(targetLabel, pullRequest.author.login);
         }
         break;

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ class Validation extends PullRequestValidation {`
`74`	`74`	`throw this._createHasDeprecationsError(targetLabel);`
`75`	`75`	`}`
`76`	`76`	`case targetLabels['TARGET_AUTOMATION']:`
`77`		`- if (!automationBots.includes(pullRequest.author.login)) {`
	`77`	`+ if (automationBots.includes(pullRequest.author.login)) {`
`78`	`78`	`throw this._createUserUsingAutomationLabelError(targetLabel, pullRequest.author.login);`
`79`	`79`	`}`
`80`	`80`	`break;`